1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/differential
epriestley b2b739c709 Reduce code duplication in Herald fields
Summary:
Ref T8726. I want to modularize values and reduce how hard-coded / copypasta'd they are.

  - Rename `get...StandardCondition()` to `get...StandardType()`, since we can drive both conditions and values from it.
  - Rename `STANDARD_LIST` to `STANDARD_PHID_LIST` for consistency: all "lists" are lists of PHIDs.
  - For all standard types which don't require typehaeads, lift their logic into the base class.
  - I'll lift typeaheads soon, but need to generalize them first.

Test Plan: Edited various Herald rules, saw value UI generate correctly.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13612
2015-07-16 14:11:44 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Generate mail command documentation from active commands 2015-04-01 11:51:47 -07:00
conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
config Separate "Revision" and "Diff" fields in Differential 2015-06-16 08:53:40 -07:00
constants [Redesign] Add color to diff Table of Contents 2015-07-01 11:33:31 -07:00
controller Merge branch 'master' into redesign-2015 2015-06-23 10:26:47 -07:00
customfield Fix a bad method call which slipped by 2015-06-23 17:11:59 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Carefully avoid the harbormaster/differential race 2015-06-25 10:05:37 -07:00
event Remove implode_selected_handle_links() 2015-03-31 05:48:20 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
herald Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
landing Extend from Phobject 2015-06-15 18:02:27 +10:00
lipsum phtize all the things 2015-05-22 21:16:39 +10:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
management Remove break from hunk migration 2015-06-15 08:32:08 +10:00
parser Return $this from setter methods 2015-07-06 22:53:43 +10:00
phid Separate handle "status" and "availability" 2015-05-14 11:14:44 -07:00
query Merge branch 'master' into redesign-2015 2015-06-22 12:26:41 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Extend from Phobject 2015-06-15 18:02:27 +10:00
search phtize all the things 2015-05-22 21:16:39 +10:00
storage Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
view [Redesign] Add color to diff Table of Contents 2015-07-01 11:33:31 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00