1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
phorge-phorge/src/applications/diffusion
epriestley bdda7eed07 Improve display behavior for write locks held by omnipotent users
Summary:
Ref T13614. When an omnipotent user calls "synchronizeWorkingCopyBeforeWrite()", we record a WorkingCopyVersion record with a null "userPHID". The UI then renders this as "Unknown Object (????)".

Improve this behavior:

  - When no PHID is available, just render nothing in the UI (this doesn't seem meaningfully different from no version existing at all).
  - Allow callers to provide an acting user PHID, similar to Editor.

There's currently no way to perform this kind of write legitimately in the upstream, but T13614 is providing one.

Test Plan:
  - Wrote a script that calls "synchronizeWorkingCopyBeforeWrite()" as the omnipotent user.
  - Ran script, saw "Unknown Object (????)" in the UI.
  - Applied UI fix, saw empty UI.
  - Applied "acting as" fix, modified script to act as the Diffusion application, ran script, saw "Diffusion" attribution in UI.

{F8814806}

Maniphest Tasks: T13614

Differential Revision: https://secure.phabricator.com/D21669
2021-06-01 08:29:53 -07:00
..
application Remove the "Graph" view as a dedicated repository view 2020-08-12 08:59:16 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Correct Diffusion browse behavior when visiting a path URI with no trailing slash 2021-01-28 08:52:58 -08:00
config Clarify the behavior of "audit.can-author-close-audit" 2021-03-12 09:20:16 -08:00
controller Correct minor "jump to symbol" behavior in Differential 2021-03-17 15:32:07 -07:00
data Make "CommitData" wrap and persist a "CommitRef" record 2020-09-15 17:36:40 -07:00
document Add a view option to disable blame in Diffusion and fix some view transition bugs 2018-04-30 15:32:23 -07:00
doorkeeper Modernize and clean up "PhabricatorAuditStatusConstants" 2021-03-10 09:21:55 -08:00
edge Allow revisions to revert commits and one another, and commits to revert revisions 2018-02-02 08:25:58 -08:00
editfield Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
editor Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery" 2020-05-07 16:11:02 -07:00
engine Further correct and disambigutate ref selectors passed to Git on the CLI 2021-01-20 12:07:14 -08:00
engineextension Correct minor "jump to symbol" behavior in Differential 2021-03-17 15:32:07 -07:00
exception Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Fix a missing getSSHUser() callsite 2018-01-31 15:34:12 -08:00
harbormaster Pass commit authorship information to Buildkite 2018-08-27 12:52:11 -07:00
herald Modernize and clean up "PhabricatorAuditStatusConstants" 2021-03-10 09:21:55 -08:00
identity Add a "--dry-run" flag to "bin/repository rebuild-identities" 2019-11-19 12:38:20 -08:00
management Improve display behavior for write locks held by omnipotent users 2021-06-01 08:29:53 -07:00
panel Add icons to Settings 2019-01-23 13:41:41 -08:00
protocol Improve display behavior for write locks held by omnipotent users 2021-06-01 08:29:53 -07:00
query Skip "git for-each-ref" when identifying deleted commits 2021-03-28 11:04:29 -07:00
ref Allow repository service lookups to return an ordered list of service refs 2019-09-03 10:05:40 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion 2019-05-21 13:12:28 -07:00
request Remove "final" from "private" methods in Phabricator 2021-02-03 14:13:29 -08:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
searchfield Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
ssh Generalize repository proxy retry logic to writes 2019-09-03 12:34:10 -07:00
symbol Provide character position information to symbol queries 2018-01-26 13:01:57 -08:00
typeahead Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
view Fix an issue where known Subversion commits are incorrectly shown as "Discovering..." 2020-09-17 13:55:47 -07:00
worker When updating revisions in responset to commits, use the omnipotent viewer to pull diffs 2021-03-01 11:11:34 -08:00
xaction Modernize and clean up "PhabricatorAuditStatusConstants" 2021-03-10 09:21:55 -08:00
DiffusionCommitAuditStatus.php Enrich "diffusion.commit.search" with identity, status, and message information 2018-09-12 12:45:44 -07:00
DiffusionLintSaveRunner.php Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00