1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/applications/home
Chad Little fc893658b8 Update menu item names for Applications -> Favorites
Summary: Adds a `MenuName` method to applications that `ProfileMenuItem` uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest.

Test Plan: Review each of the name changes as a default new install and a modified install.

Reviewers: epriestley, amckinley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18524
2017-09-05 19:05:03 -07:00
..
application Restore old Home mobile menu behavior, hide crumbs 2017-02-01 10:29:13 -08:00
constants Use a label for default home menu 2017-02-01 07:20:13 -08:00
controller Restore old Home mobile menu behavior, hide crumbs 2017-02-01 10:29:13 -08:00
engine Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
menuitem Fix a mismatched method definition in PhabricatorHomeProfileMenuItem 2017-02-02 07:02:21 -08:00
view Fix italics issue with nux state on homepage 2017-02-25 15:30:17 -08:00