revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley e8083ad63a Increase the storage size for commit summaries 
Summary:
Fixes T11453. Currently, commit message summaries are limited to 80 bytes. This may only be 20-40 characters for CJK languages or langauges with Cyrillic script.

Increase storage size to 255, then truncate to the shorter of 255 bytes or 80 glyphs. This preserves the same behavior for latin languages, but is less tight for Russian, etc.

Some minor additional changes:

  - Provide a way to ask "how much data fits in this column?" so we don't have to duplicate column lengths across summary checks or UI errors like "title too long".
  - Remove the `text80` datatype, since no other columns use it and we have no use cases (or likely use cases) for it.

Test Plan:
  - Made a commit with a Cyrillic title, saw reasonable summarization in UI:

{F1757522}

  - Added and ran unit tests.
  - Grepped for removed `SUMMARY_MAX_LENGTH` constant.
  - Grepped for removed `text80` data type.

Reviewers: avivey, chad

Reviewed By: avivey

Subscribers: avivey

Maniphest Tasks: T11453

Differential Revision: https://secure.phabricator.com/D16385
2016-08-10 11:12:45 -07:00
..
almanac Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
aphlict Cache user notification and message counts 2016-06-05 08:52:43 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
auth Use numeric input control for TOTP factor entry 2016-07-26 04:47:02 -07:00
badges Better destruction of PhameBlog, BadgesBadge 2016-06-27 18:24:23 -07:00
base Open "Help" menu links in a new window 2016-07-04 10:59:40 -07:00
cache Add --purge-user to bin/cache purge 2016-06-04 14:45:15 -07:00
calendar Add basic Herald support to Calendar 2016-08-06 14:37:33 -07:00
celerity Update Phabricator logo 2016-08-07 11:35:21 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
config Increase the storage size for commit summaries 2016-08-10 11:12:45 -07:00
conpherence Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
console After toggling DarkConsole, force a user settings cache fill 2016-06-05 10:04:23 -07:00
countdown Fix new Countdown link 2016-06-07 20:13:08 -07:00
daemon Fix a fatal when viewing a daemon task with an invalid ID 2016-07-08 07:08:45 -07:00
dashboard Implement a "pro" EditEngine for dashboard panels 2016-07-03 15:07:36 -07:00
differential Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
diffusion Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Convert all remaining old tabs to new PHUITabGroupViews 2016-06-30 18:50:09 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Fix several issues with email-related global preferences 2016-06-14 12:35:31 -07:00
files Allow file comments to be edited 2016-07-18 16:17:43 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
harbormaster Use long array syntax for compatibility instead of short array syntax 2016-08-01 10:45:19 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Link Herald rules to rule detail pages in Herald transcripts 2016-08-10 08:53:03 -07:00
home Clean up some tablet issues with new nav layouts 2016-08-04 20:49:16 +00:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Use consistent tag order in Maniphest list views and workboard cards 2016-08-03 16:46:40 -07:00
meta Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
metamta Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
nuance Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
oauthserver Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
owners Show more repository information in Owners path editing dropdown 2016-07-08 07:08:33 -07:00
packages In Packages, give publishers a list of packages and packages a list of versions 2016-07-27 12:27:34 -07:00
passphrase Prevent locked credentials from being made accessible via conduit 2016-05-18 14:54:44 -07:00
paste Slightly simplify some Paste modular transactions 2016-07-13 15:41:19 -07:00
people Make Calendar day view a little more consistent 2016-07-15 14:24:29 -07:00
phame Raise human-readable error messages for overlong Phame blog titles and subtitles 2016-07-21 09:48:06 -07:00
phid Convert Calendar to Modular Transactions 2016-07-13 07:46:33 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phortune Add print styles for Phortune carts 2016-06-08 07:52:18 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phurl Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
policy Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
ponder Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
project Use consistent tag order in Maniphest list views and workboard cards 2016-08-03 16:46:40 -07:00
releeph Update Releeph to new UI 2016-04-05 13:16:10 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Increase the storage size for commit summaries 2016-08-10 11:12:45 -07:00
search Explain reasoning behind kitty gifts 2016-08-06 06:26:15 -07:00
settings Fix ApplicationSearch URIs for Settings 2016-07-05 16:55:39 -07:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Two-for-one deal on typos 2016-05-18 09:53:39 -07:00
tokens More tokens 2016-07-03 18:32:40 -07:00
transactions Hide time controls when editing all-day Calendar events 2016-07-27 05:01:19 -07:00
typeahead Push typehead browse result selector button down one <div> 2016-06-21 15:28:12 -07:00
uiexample Remove PHUIDocumentView 2016-08-08 09:39:48 -07:00
xhprof Update XHProf for newPage 2016-04-04 08:40:49 -07:00