1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications
Hafsteinn Baldvinsson fffc1e51d0 Inset view controller for inset elements of forms.
Summary:
T937 suggests 'inset' could have its own view controller.

It has the following methods:
 - setTitle         for title
 - setRightbutton   if you have to place something (preferably a button)
                    on the right side of the form
 - setDescription   if you want to describe what it does
 - setContent       for the main content
 - addDivAttributes REALLY not sure about this one but it had to be included
                    because of a single controller (see owners/controller/edit/PhabricatorOwnersEditController.php:238)
 - appendChild      works as usual if your form is complex but you still want to remove
                    ->appendChild('<div class..') ->appendChild('</div>');

It might be an overkill so maybe some could be dropped:
 - addDivAttributes() and just rewrite how PhabricatorOwnersEditController.php works
 - setContent() and use appendChild for the main content?

Test Plan:
 - Looked at the controllers in phabricator
 - Changed the controller
 - Opened the page in another tab
 - If something didnd't look the same I fixed it.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1926
2012-03-15 17:10:38 -07:00
..
audit Add inline comments to Diffusion/Audit 2012-03-14 12:56:01 -07:00
auth Add "final" to more classes 2012-03-13 11:18:11 -07:00
base Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
calendar Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
chatlog Add a basic chatlog 2012-02-17 10:21:38 -08:00
conduit Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
countdown Add "final" to more classes 2012-03-13 11:18:11 -07:00
daemon Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
differential Unfinal "DifferentialReplyHandler" 2012-03-15 14:16:32 -07:00
diffusion Display time of revision in blame 2012-03-14 21:31:16 -07:00
directory Add "User Projects" Filter to Maniphest 2012-03-14 18:01:45 -07:00
draft/storage Add "final" to more classes 2012-03-13 11:18:11 -07:00
drydock Add "final" to more classes 2012-03-13 11:18:11 -07:00
feed Add "final" to more classes 2012-03-13 11:18:11 -07:00
files Improve UI hints and error messages for supported file types 2012-03-14 12:41:33 -07:00
help/controller Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
herald Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
maniphest Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
markup Highlight monospace first 2012-03-15 10:58:01 -07:00
metamta Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
notifications/controller Make Aphlict client somewhat more approachable 2012-03-06 20:14:03 -08:00
oauthserver Fix OAuth Client Authorization bugs 2012-03-05 13:27:20 -08:00
owners Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
paste Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
people Added Search Box Preferences 2012-03-14 20:47:41 -07:00
phid Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
phriction Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
project Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
repository Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
search Add new jumpnav actions for audits and feed 2012-03-15 16:38:07 -07:00
slowvote Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
status/base Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
typeahead/controller Don't show "archived" projects in typeaheads 2012-03-12 21:07:40 -07:00
uiexample Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
xhpastview Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
xhprof Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00