revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/celerity/map.php

2469 lines
88 KiB
PHP
Raw Normal View History

Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
<?php
/**
* This file is automatically generated. Use 'bin/celerity map' to rebuild it.
Minor change to the Celerity map formatting Summary: Add a new line for clarity. Test Plan: Inspected `./resources/celerity/map.php`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9931
2014-07-16 03:29:06 +02:00
*
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
* @generated
*/
return array(
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'names' => array(
Hide footer on mobile Conpherence Summary: This has been causing scrolling issues for me for a while, turns out the footer behind the Conpherence layout can bubble up and cause scrolling issues if you don't hit the scrollarea in the right place with your finger. Hiding it via CSS or removing the footer in the configuration resolves the issue on my phone on secure. Test Plan: Test with and without footer on secure, hide footer in CSS since it's not visible anyways. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16732
2016-10-20 00:15:06 +02:00
'conpherence.pkg.css' => 'cea72e09',
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'conpherence.pkg.js' => '6249a1cf',
Clean up mobile css on config page Summary: I seemed to have missed this, lots of funky desktop padding on mobile. Test Plan: Review Config / Maniphest / etc on a mobile browser. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16731
2016-10-20 00:01:41 +02:00
'core.pkg.css' => '46d588e4',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'core.pkg.js' => '035325a7',
Quicksand - fix project board page and quicksand Summary: Fixes T7913. Collapse the separate board dropdown into the board projects behavior; we always need that anyway and now we can install the listener more granularly. Test Plan: - visted project board - invoked create task, cancelled dialog - visited project feed - visited project board - invoked create task, cancelled dialog (FAILED pre patch...!) Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7913 Differential Revision: https://secure.phabricator.com/D12599
2015-04-28 23:51:49 +02:00
'darkconsole.pkg.js' => 'e7393ebb',
Fix some Quicksand bugs Summary: Packages AppSearch, fixes body color, moves Differential filetree into differential package. Test Plan: Enable quicksand. Navigate home -> differential -> diff. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16641
2016-09-30 23:55:04 +02:00
'differential.pkg.css' => 'e1d704ce',
When using the "Close as Duplicate" relationship action, limit the UI to 1 task Summary: Ref T4788. When closing a task as a duplicate of another task, you can only select one task, since it doesn't really make sense to merge one task into several other tasks (this operation is //possible//, but probably not what anyone ever wants to do, I think?). Make the UI understand this: after you select a task, disable all of the "select" buttons in the UI to make this clear. Test Plan: - Used "Close as Duplicate", only allowed to select 1 task. - Used other editors like "Merge Duplicates In", allowed to select lots of tasks. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16203
2016-06-30 20:37:38 +02:00
'differential.pkg.js' => '634399e9',
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'diffusion.pkg.css' => '91c5d3a6',
Improve "thread" rendering of unusually-shaped graphs Summary: Ref T4788. This fixes all the bugs I was immediately able to catch: - "Directory-Like" graph shapes could draw too many vertical lines. - "Reverse-Directory-Like" graph shapes could draw too few vertical lines. - Terminated, branched graph shapes drew the very last line to the wrong place. This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything. Test Plan: - Added failing tests and made them pass. {F1708158} {F1708159} {F1708160} {F1708161} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 18:22:00 +02:00
'diffusion.pkg.js' => '84c8f8fd',
Support ".ico" in Celerity and simplify rewite rule configuration Summary: See D16734. - Add ".ico" files to the Celerity map. - Add a formal route for "/favicon.ico". - Remove instructions to configure `/rsrc/` and `/favicon.ico` rewrite rules. Long ago, we served resources directly via `/rsrc/` in at least some cases. As we added more features, this stopped working more and more often (for example, Apache can never serve CSS this way, because it doesn't know how to post-process `{$variables}`). In modern code (until this change), only `/favicon.ico` is still expected to be served this way. Instead, serve it with an explicit route via controller (this allows different Sites to have different favicons, for example). Remove the instructions suggesting the old rewrite rules be configured. It's OK if they're still in place -- they won't break anything, so we don't need to rush to get users to delete them. We should keep "webroot/favicon.ico" in place for now, since it needs to be there for users with the old rewrite rule. Test Plan: - Ran celerity map. - Loaded `/favicon.ico`, got resource via route. - Used `celerity_generate_resource_uri()` to get paths to other icons, loaded them, got icons. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16737
2016-10-20 20:14:33 +02:00
'favicon.ico' => '30672e08',
[Redesign] Put all ApplicationSearch results in an ObjectBox Summary: Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now. Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information. TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
'maniphest.pkg.css' => '4845691a',
Replace all Maniphest commenting code with EditEngine commenting code Summary: Ref T9132. Like D14659, I'll hold this until after the cut. This swaps commenting in Maniphest over to EditEngine / stackable actions. New code doesn't have parity yet, although none of the things we're missing should technically be //strictly mandatory//. There's a list inline. I'll restore these in the next diffs. Briefly -- comments, subscribers and projects work. Status, owners and priority do not yet. Test Plan: - Made comments and added subscribers and projects. - Read through the old code to look for missing features and tried to document them all. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14663
2015-12-04 15:37:36 +01:00
'maniphest.pkg.js' => '949a7498',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/aphront/dark-console.css' => 'f54bf286',
Rebuild Conpherence Summary: Minor rebuild / redesign of Conpherence. Most of this is new UX and tossing out things like widgets, device fallbacks. I expect some of the UI to get more polished after next pass, but most everything here is in place. - Removed "Widgets", now just a single Participants pane - Added "Topic" - New header - Settings, Edit are action icons - Removed a lot of JS - Simplified CSS as much as I could Test Plan: Desktop, Tablet, Mobile. Adding and removing people. Setting new topics, new rooms. {F1828662} {F1828669} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16550
2016-09-15 03:34:11 +02:00
'rsrc/css/aphront/dialog-view.css' => '593d3f67',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
Provide an AphrontController implementation of willSendResponse() Summary: This is required by Aphront now but not given a default implementation in the base class. Test Plan: CORGI sites now work. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14079
2015-09-08 02:18:35 +02:00
'rsrc/css/aphront/list-filter-view.css' => '5d6f0526',
Convert Durable Column to popup chat in footer Summary: This feels pretty reasonable with little effort, and I think I'd use it more than the full column. Test Plan: Chat a lot on various pages.... still some quicksand quirks around various pages. {F1853487} Reviewers: epriestley Reviewed By: epriestley Subscribers: scp, Korvin Differential Revision: https://secure.phabricator.com/D16627
2016-09-29 07:27:19 +02:00
'rsrc/css/aphront/multi-column.css' => '84cc6640',
Lay `cluster.databases` configuration groundwork for database clustering Summary: Ref T4571. This adds a new option which allows you to upgrade your one-host configuration to a multi-host configuration by configuring it. Doing this currently does nothing. I wrote a lot of words about what it is //supposed// to do in the future, though. Test Plan: - Tried to configure the option in all the possible bad ways, got errors. - Read documentation. Reviewers: chad Reviewed By: chad Subscribers: eadler Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15663
2016-04-09 14:41:08 +02:00
'rsrc/css/aphront/notification.css' => '3f6c89c9',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'rsrc/css/aphront/panel-view.css' => '8427b78d',
Fix scrollbar in filetree sidenav Summary: Fixes T11457, I guess. It feels wierd when you drag it a bit, and Im not positive if it's the calc css or javascript. Test Plan: Enable filetree, shorten browser, see scrolling appear if files too long. Reviewers: avivey, epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11457 Differential Revision: https://secure.phabricator.com/D16393
2016-08-12 02:12:53 +02:00
'rsrc/css/aphront/phabricator-nav-view.css' => 'b29426e9',
Truncate and scroll task graph tables instead of fitting task titles to the display Summary: Fixes T11676. Instead of trying to fit task titles to the display, truncate them and let the table scroll. Test Plan: Table now scrolls when cramped: {F1843396} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11676 Differential Revision: https://secure.phabricator.com/D16583
2016-09-21 23:41:52 +02:00
'rsrc/css/aphront/table-view.css' => '3225137a',
Tweak grey tag color Summary: This is a bit too grey, and doesn't match our theme well (see sequence navs) Test Plan: Remarkup reference article, sequence navs Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14408
2015-11-04 22:51:51 +01:00
'rsrc/css/aphront/tokenizer.css' => '056da01b',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
Render browse results with global result style Summary: Ref T11034. This seems a little more promising. Two problems at the moment: - This doesn't actually provide any useful information at all right now. - Many object types have no profile images. Test Plan: {F1695254} {F1695255} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11034 Differential Revision: https://secure.phabricator.com/D16155
2016-06-20 22:52:18 +02:00
'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/aphront/typeahead.css' => 'd4f16145',
Allow Almanac service types to define default properties Summary: Ref T5833. This allows Almanac ServiceTypes to define default properties for a service, which show up in the UI and are more easily editable. Overall, this makes it much easier to make structured/usable/consistent service records: you can check a checkbox that says "prevent new allocations" instead of needing to know the meaning of a key. Test Plan: {F251593} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5833 Differential Revision: https://secure.phabricator.com/D10996
2014-12-17 20:10:50 +01:00
'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
Touch up auth external account ui Summary: Fixes T8886 Test Plan: Check auth settings at different breakpoints. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8886 Differential Revision: https://secure.phabricator.com/D13650
2015-07-18 17:51:25 +02:00
'rsrc/css/application/auth/auth.css' => '0877ed6e',
Always show a menu on durable column Summary: If you don't have any rooms, we currently show no menu and users have no logical means of closing the column. This lets "Hide Column" at least still appear. Fixes T9195 Test Plan: Fresh install, hit {key \}, see menu. Close Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9195 Differential Revision: https://secure.phabricator.com/D16516
2016-09-07 23:23:07 +02:00
'rsrc/css/application/base/main-menu-view.css' => 'f03e17be',
Add an icon to aphlict connection status Summary: A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc). Test Plan: Test in Notifications menu, Conpherence full, Durable Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16647
2016-10-02 05:37:28 +02:00
'rsrc/css/application/base/notification-menu.css' => '1e055865',
Better icon alignment home nav Summary: These icons weren't actually centering. Widen the width and actually center the text. Test Plan: Review centering very carefully. Test home desktop / mobile Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13648
2015-07-20 22:48:35 +02:00
'rsrc/css/application/base/phabricator-application-launch-view.css' => '95351601',
Remove phui-theme sidebar colors Summary: Removes the special CSS to change the sidebar when the header is called. Also switched to using a more standard background color. I'd also like to make collapsed the default, but can't find best way to do that. Test Plan: Vist profile, projects, collapse and open nav, try a workboard color. Still all good. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16673
2016-10-05 22:19:07 +02:00
'rsrc/css/application/base/phui-theme.css' => '798c69b8',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'rsrc/css/application/base/standard-page-view.css' => '79176f5a',
[Redesign] Larger Font PostProcessor Summary: Ref T8099, Ref T8614. Reasonable attempt at a larger font size PostProcessor, will need additional UI cleanup (places where we fix height) but overall very decent. Test Plan: Use lots of the UI elements with new font sizes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8614 Differential Revision: https://secure.phabricator.com/D13457
2015-06-26 18:33:03 +02:00
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
Show how to call Conduit API methods from clients Summary: Fixes T3628. Ref T5955. Test Plan: On the method page, you see a generic example: {F396471} After making a call, you see a specific example with your parameters: {F396472} {F396474} {F396475} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3628, T5955 Differential Revision: https://secure.phabricator.com/D12770
2015-05-08 21:19:52 +02:00
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
Shuffle various parts of the config edit UI around Summary: Fixes T9339. - Don't show edit control for locked config at all. - Don't show a "Cancel" button either. - Change "Value" label to "Database Value" for non-custom config. - Highlight effective value. - Move examples under current state. - Tweak some formatting. Test Plan: {F777878} Reviewers: chad, avivey Reviewed By: chad, avivey Subscribers: avivey Maniphest Tasks: T9339 Differential Revision: https://secure.phabricator.com/D14054
2015-09-03 21:15:30 +02:00
'rsrc/css/application/config/config-options.css' => '0ede4c9b',
Clean up mobile css on config page Summary: I seemed to have missed this, lots of funky desktop padding on mobile. Test Plan: Review Config / Maniphest / etc on a mobile browser. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16731
2016-10-20 00:01:41 +02:00
'rsrc/css/application/config/config-page.css' => 'b80124ae',
Add a friendlier "in flight" error page Summary: Ref T11589. When we hit a fatal setup issue (essentially always a connection failure) //after// we've already survived them on at least one request, we can be pretty sure a server went down and that the problem is not a setup/configuration issue. In this case, show a friendlier error page instead of the fairly detailed technical one. Test Plan: - Broke MySQL config. - Restarted Apache. - Got the "admin/setup" error page: {F1803268} - Fixed the MySQL config. - Loaded any page, to put us "in flight". - Broke MySQL config. - Loaded any page. - Got the friendly "in flight" error page: {F1803271} If you want to design this better, easiest way to get to it is: - Set `mysql.port` to `9999` in `conf/local/local.json`. - Reload any page while already running (don't restart). Reviewers: chad Reviewed By: chad Maniphest Tasks: T11589 Differential Revision: https://secure.phabricator.com/D16503
2016-09-06 22:48:22 +02:00
'rsrc/css/application/config/config-template.css' => '8f18fa41',
Wrap long text in setup issues Summary: Really long text strings break this ui when first setting up Phabricator. Test Plan: MySQL sql_mode setup issue. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16455
2016-08-26 06:34:24 +02:00
'rsrc/css/application/config/setup-issue.css' => 'f794cfc3',
[Redesign] Remove gradient headers Summary: Ref T8099, this removes the gradient headers and their edge cases in Pinboard View, Setup Issues, Exceptions, and Document Heiriarchy. Test Plan: Tested each of these, grep for "gradient" and verify all states are gone. {F410708} {F410709} {F410710} {F410714} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12944
2015-05-20 04:38:34 +02:00
'rsrc/css/application/config/unhandled-exception.css' => '4c96257a',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'rsrc/css/application/conpherence/durable-column.css' => 'd82e130c',
Fix super long topics in Conpherence header Summary: Add some ellipsis if the topic is absurdly long. Test Plan: desktop, mobile, tablet. MMMMMMMmmmMMMMMMmMMMmMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16718
2016-10-18 20:22:54 +02:00
'rsrc/css/application/conpherence/header-pane.css' => '1c81cda6',
Hide extra rooms when you have too many in Conpherence Summary: This probably stopped working when we switch to a standard nav view. Re-scope CSS. Also make scrolling to last room a little easier. Test Plan: Make 20 rooms, see the old ones vanish. Click See More, scroll to bottom, click last room Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16656
2016-10-03 20:12:21 +02:00
'rsrc/css/application/conpherence/menu.css' => '4f51db5a',
Hide footer on mobile Conpherence Summary: This has been causing scrolling issues for me for a while, turns out the footer behind the Conpherence layout can bubble up and cause scrolling issues if you don't hit the scrollarea in the right place with your finger. Hiding it via CSS or removing the footer in the configuration resolves the issue on my phone on secure. Test Plan: Test with and without footer on secure, hide footer in CSS since it's not visible anyways. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16732
2016-10-20 00:15:06 +02:00
'rsrc/css/application/conpherence/message-pane.css' => '394ae8fa',
Clean up css race condition in Conpherence notification menu Summary: Depending on when packages loaded, this CSS sometimes gets overwritten. Make it more specific and always present. Test Plan: Reload a lot Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16657
2016-10-03 21:20:00 +02:00
'rsrc/css/application/conpherence/notification.css' => '965db05b',
Allow tablet breakpoint in Conpherence to have persistent participant pane Summary: tablet viewpoints here are wide enough to support the participant column, go ahead and give it dedicated space. Test Plan: review tablet, desktop, and mobile breakpoints in conpherence with column toggled on and off Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16724
2016-10-19 06:13:53 +02:00
'rsrc/css/application/conpherence/participant-pane.css' => 'ac1baaa8',
New UI for fulltext message search Summary: Basically all here, but still probably needs some polish (links to jump? full dates?). Looks much better, still duplicates messages though sometimes. Needs to debug that more. Test Plan: Revisit search UI inside Conpherence, outside Conpherence, and normal room searches in Conpherence. {F1870748} {F1870749} {F1870750} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16708
2016-10-15 15:58:46 +02:00
'rsrc/css/application/conpherence/transaction.css' => '85129c68',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
Increase specificity in blue property boxes Summary: Feels a little hairy, but should be fine overall. Ups the css specificity enough that it's always displayed the same. The main problem is headers and boxes get put everywhere, and sometimes override each other. Fixes T10757 Test Plan: review a countdown in a phame post and phriction document. Check diviner, phriction for regressions. Reviewers: epriestley, #phacility Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10757 Differential Revision: https://secure.phabricator.com/D15664
2016-04-09 19:07:02 +02:00
'rsrc/css/application/countdown/timer.css' => '16c52f5c',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'rsrc/css/application/daemon/bulk-job.css' => 'df9c1d4a',
Modernize Dashboard UI and code Summary: Pulls everything over to two column UI and new edit pages. Removed history view and consolidated some pages. Test Plan: New Panel, Edit Panel. New Dashboard, Edit Dashboard, View Standalone pages. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15588
2016-04-03 01:02:13 +02:00
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
[Redesign] Move basefont to Lato, remove Source Sans Pro Summary: Working towards a more unified look and feel. This brings in Lato as a complete base font over Helvetica Neue, as well as removing Source Sans Pro from DocumentView and Conpherence. Design-wise Lato provides the nice readability at larger font sizes that Source Sans Pro did, with the ability to scale down to tables and UI widgets with ease. This gives us one font instead of two, and now Object descriptions and Timeline posts all can benefit from a consistent, readable font. Test Plan: Test main UI, smaller elements like tables, menus, DocumentViews, Previews, Conpherence. {F498135} {F498136} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13276
2015-06-13 21:32:45 +02:00
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
Revamp inline commenting UI Summary: Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns: **To the author:** - The author of the diff should be able to easily identify what comments are done and not done. - We keep undone comments yellow - Clicking done turns comment block into 'unsubmitted state' **To the reviewer:** - Easier understanding of unsubmitted states - All conversations to be yellow/important **Todo** - Not all color CSS states correct - Unpulished checkbox support Test Plan: Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states. From the Diff Author's perspective: {F352094} For a Diff commenter's perspective: {F352095} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T1460, T7660, T7503 Differential Revision: https://secure.phabricator.com/D12171
2015-03-28 00:00:09 +01:00
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
Fix mobile menu for files in Differential Changesets Summary: Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu. Test Plan: View on mobile, desktop, browser. Click an action, spawn new page. {F1717953} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T7754, T11305 Differential Revision: https://secure.phabricator.com/D16265
2016-07-09 22:53:57 +02:00
'rsrc/css/application/differential/changeset-view.css' => '9ef7d354',
Convert Differential to new layout Summary: First pass at converting Differential, I likely have some buggy-poos but thought I'd toss this up now in case very bad bugs present. To do: - Need to put status back on Hovercards - "Diff Detail" probably needs a better design Test Plan: Looking at lots of diffs, admittedly I dont have harbormaster, etc, running locally. Checked Diffusion for Table of Content changes on small and large commits. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15463
2016-03-12 22:02:32 +01:00
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
Partially improve threading UI for adjacent inline comments Summary: Ref T10563. This isn't a complete fix, but should make viewing complex inline threads a little more manageable. This just tries to put stuff in thread order instead of in pure chronological order. We can likely improve the display treatment -- this is a pretty minimal approach, but should improve clarity. Test Plan: T10563 has a "before" shot. Here's the "after": {F1169018} This makes it a bit easier to follow the conversations. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10563 Differential Revision: https://secure.phabricator.com/D15459
2016-03-11 01:33:44 +01:00
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
Highlight cell when jumping to an inline comment Summary: Fixes T8061. Test Plan: {F392321} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8061 Differential Revision: https://secure.phabricator.com/D12705
2015-05-04 21:21:21 +02:00
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
Fibrous vegeables.
2014-03-12 21:53:04 +01:00
'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'rsrc/css/application/diffusion/diffusion-icons.css' => 'd678600a',
Couple of Diffusion tweaks Summary: - Fix spacing on InfoView inside collasped boxes - Fix spacing on stacked PropertyLists in TwoColumn - Fix spacing on Readmes on Tablets - Fix unset variable on importing commits Test Plan: Review each of the above cases. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15496
2016-03-18 20:01:15 +01:00
'rsrc/css/application/diffusion/diffusion-readme.css' => '297373eb',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'rsrc/css/application/diffusion/diffusion-source.css' => '68b30fd3',
[Redesign] Update Feed Summary: Ref T8099, minor spacing improvements and more icons for feed. Test Plan: Test feed in Feed, in a Dashboard, Profile, and Project {F443366} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13045
2015-05-28 20:47:06 +02:00
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'rsrc/css/application/flag/flag.css' => '5337623f',
Clean up spacing on empty logs in Harbormaster Summary: Better spacing in new layout. Test Plan: Tested changes against `secure` Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15524
2016-03-25 23:41:05 +01:00
'rsrc/css/application/harbormaster/harbormaster.css' => 'f491c9f4',
Modularize Herald "flag" action, plus update transcripts Summary: Ref T8726. This modularizes "Mark with flag", plus rebuilds transcripts in a more modern/flexible way. The big transcript stuff is: - Transcripts are now translatable. - Transcripts can now show multiple outputs from a single action. For example, an action like "add A, B, C to subscribers" can now say "added A; B is invalid; C was already subscribed". Test Plan: {F637784} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: joshuaspence, eadler, epriestley Maniphest Tasks: T8726 Differential Revision: https://secure.phabricator.com/D13649
2015-07-18 14:54:26 +02:00
'rsrc/css/application/herald/herald-test.css' => 'a52e323e',
Clean up Herald CSS Summary: I didn't test these very well and they looked silly when multiple rules applied. Test Plan: Test various cases more, with single and multiple triggers. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15419
2016-03-06 22:04:19 +01:00
'rsrc/css/application/herald/herald.css' => 'dc31f6e9',
[Redesign] Put all ApplicationSearch results in an ObjectBox Summary: Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now. Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information. TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
'rsrc/css/application/maniphest/batch-editor.css' => 'b0f0b6d5',
Fix backdrop color Summary: All our builtin images use #c4cde0 for the backdrop. This makes generation match the builtins. Test Plan: Build a new bug icon in Maniphest {F1077934} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15126
2016-01-28 05:56:36 +01:00
'rsrc/css/application/maniphest/report.css' => '9b9580b7',
[Redesign] Larger Font PostProcessor Summary: Ref T8099, Ref T8614. Reasonable attempt at a larger font size PostProcessor, will need additional UI cleanup (places where we fix height) but overall very decent. Test Plan: Use lots of the UI elements with new font sizes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8614 Differential Revision: https://secure.phabricator.com/D13457
2015-06-26 18:33:03 +02:00
'rsrc/css/application/maniphest/task-edit.css' => 'fda62a9b',
[Redesign] Put all ApplicationSearch results in an ObjectBox Summary: Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now. Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information. TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
'rsrc/css/application/maniphest/task-summary.css' => '11cc5344',
[Redesign] Update Object Selector UI Summary: Ref T8099, Better colors and spacing on the Object Selector. Test Plan: Hover and test new spacing. Reviewers: epriestley, btrahan Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13524
2015-07-02 23:39:43 +02:00
'rsrc/css/application/objectselector/object-selector.css' => '85ee8ce6',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b',
Solidify PHUITwoColumnView as a page layout Summary: Rolls out a new "Object Page" design with PHUITwoColumnView. This is reasonably polished, but wanted to post it up for you now for feedback before chasing down minor bugs. This implements TwoColumn in the following applications: - Ponder - Paste - Slowvote - Countdown - Projects - Profile - Passphrase This helped track down display issues and inconsistencies and make sure the layout was flexible for different pages. Test Plan: Test each of the applications on mobile, tablet, and desktop breakpoints. {F1135705} {F1135706} {F1135707} {F1135708} {F1135709} {F1135710} {F1135711} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15366
2016-02-26 23:34:51 +01:00
'rsrc/css/application/paste/paste.css' => '1898e534',
Fix backdrop color Summary: All our builtin images use #c4cde0 for the backdrop. This makes generation match the builtins. Test Plan: Build a new bug icon in Maniphest {F1077934} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15126
2016-01-28 05:56:36 +01:00
'rsrc/css/application/people/people-profile.css' => '2473d929',
Use CommentEditEngine in PhamePost Summary: Ref T9360. Moves PhamePost to CommentEditEngine. [x] HTTP Parameters dropdown on New Post goes to 404 [x] Implement EditEngine Comments Test Plan: Make Post, Make Comment, Laugh. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9360 Differential Revision: https://secure.phabricator.com/D16222
2016-07-06 21:24:36 +02:00
'rsrc/css/application/phame/phame.css' => '8efb0729',
Allow Pholio mocks to be created and edited without drag-and-drop Summary: Ref T6523. Allows you to click stuff instead of using drag-and-drop. Test Plan: On iOS simulator, created and updated a mock. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6523 Differential Revision: https://secure.phabricator.com/D16088
2016-06-09 17:34:00 +02:00
'rsrc/css/application/pholio/pholio-edit.css' => '07676f51',
Add spacing under Pholio Inline Comments Summary: Adds a bit of space Test Plan: View 2 or more inline comments on same transaction. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9712
2014-06-25 00:23:57 +02:00
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/application/pholio/pholio.css' => 'ca89d380',
Make it easier to add payment methods for subscription autopay Summary: Fixes T7424. Ref T6308. Currently, there's no option to just add a card directly from the autopay UI. Add a button so this works. Also, chip away at T6308 a bit. This isn't perfect but looks a little less out of place. Test Plan: {F327637} - Added a payment method, then set it as autopay. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6308, T7424 Differential Revision: https://secure.phabricator.com/D11935
2015-03-02 22:01:08 +01:00
'rsrc/css/application/phortune/phortune-credit-card-form.css' => '8391eb02',
Add a basic invoice view for printing to Phortune Summary: Makes a more complete PDF looking invoice form for printing in Phortune. Test Plan: Make an invoice, click print view, print. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16762
2016-10-30 02:45:10 +02:00
'rsrc/css/application/phortune/phortune-invoice.css' => '476055e2',
Add print styles for Phortune carts Summary: Fixes T10899, adds styles specifically for printing Phortune carts. Test Plan: Print a Phortune cart Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10899 Differential Revision: https://secure.phabricator.com/D16079
2016-06-08 05:55:18 +02:00
'rsrc/css/application/phortune/phortune.css' => '5b99dae0',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad',
Fix Phriction document linking in mail bodies Summary: Fixes T10840. When rendering mail, this rule wasn't falling through in quite the right way. Also adjust where the rules are for this so the special styles show up in Maniphest, etc. Test Plan: Made this comment: {F1238266} Which produced this HTML: {F1238267} ...and sent this mail: {F1238283} Reviewers: hach-que, chad Reviewed By: chad Maniphest Tasks: T10840 Differential Revision: https://secure.phabricator.com/D15767
2016-04-20 15:00:10 +02:00
'rsrc/css/application/phriction/phriction-document-css.css' => '4282e4ad',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
Notifications - add a "Clear All Notifications" link to dropdown Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links? Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2576 Differential Revision: https://secure.phabricator.com/D8894
2014-04-29 19:43:38 +02:00
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/policy/policy.css' => '957ea14c',
Minor Ponder spacing updates Summary: Fix an issue where you've already answered, moved the summary section. Test Plan: Review an answer with a wiki that i've already answered Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15395
2016-03-04 00:18:41 +01:00
'rsrc/css/application/ponder/ponder-view.css' => 'fbd45f96',
New People Hovercards Summary: Mimics the Project Hovercards, more custom UI. Test Plan: Hover over person with and without badges, hover over project. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15253
2016-02-11 23:55:44 +01:00
'rsrc/css/application/project/project-card-view.css' => '9418c97d',
Fix properties box layout for profiles/projects on mobile Summary: The spacing here is incorrect and no longer needed. Test Plan: Test phone layout of project, profile. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16511
2016-09-07 18:52:32 +02:00
'rsrc/css/application/project/project-view.css' => '55d99221',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733',
Remove ReleephProjectController Summary: Ref T3657. General changes here: - Removes `ReleephProjectController`, which is the source of T3657. - Mostly moves requests from "RQ" as a monogram to "Y" (looks like a merge, mnemonic for "yank"?, we don't have too many characters left). This should be essentially only cosmetic. This reduces ambiguity with "rQ" and "R123", which are current and future repository monograms. This will continue in the next few diffs. - Makes requests implement policies correctly. Test Plan: Created, edited, browsed requests. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3657 Differential Revision: https://secure.phabricator.com/D8766
2014-04-14 21:06:56 +02:00
'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd',
'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae',
Fix some minor UI issues with mobile application search Summary: Background is now always white, spacing in header is more consistent Test Plan: test mobile, table, desktop application search apps. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16691
2016-10-12 00:37:46 +02:00
'rsrc/css/application/search/application-search-view.css' => '8452c849',
Revert "Allow search results to be snippeted, roughly" Summary: This reverts commit 15837388428d6dd3c37cf4b1d302e78657fce24e. See T8646 for discussion. This version of the feature feels terrible on real data. Test Plan: Strict revert. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14097
2015-09-11 05:57:26 +02:00
'rsrc/css/application/search/search-results.css' => '7dea472c',
Solidify PHUITwoColumnView as a page layout Summary: Rolls out a new "Object Page" design with PHUITwoColumnView. This is reasonably polished, but wanted to post it up for you now for feedback before chasing down minor bugs. This implements TwoColumn in the following applications: - Ponder - Paste - Slowvote - Countdown - Projects - Profile - Passphrase This helped track down display issues and inconsistencies and make sure the layout was flexible for different pages. Test Plan: Test each of the applications on mobile, tablet, and desktop breakpoints. {F1135705} {F1135706} {F1135707} {F1135708} {F1135709} {F1135710} {F1135711} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15366
2016-02-26 23:34:51 +01:00
'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230',
Make tokens more accessible to assitive technologies Summary: Ref T4843. - The token award buttons are just icons. - The tokens themselves are just icons. - Also spread the tokens out a tiny bit, they feel a little tight to me right now. Test Plan: Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4843 Differential Revision: https://secure.phabricator.com/D8982
2014-05-05 19:54:34 +02:00
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
Clean up FontAwesome / Timeline CSS Summary: Normalize FA CSS, expand timeline icons to 14px, fix mobile browsers, give attribution in uiexamples Test Plan: tested iOS simulator, chrome, ie Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8845
2014-04-23 03:29:14 +02:00
'rsrc/css/application/uiexample/example.css' => '528b19de',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'rsrc/css/core/core.css' => 'd0801452',
Add a {key ..} Remarkup rule for discussing keystrokes Summary: Ruleset for styles in D16506. Test Plan: {F1803883} Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16510
2016-09-07 17:19:14 +02:00
'rsrc/css/core/remarkup.css' => 'cd912f2c',
Wrap really long text properly in diffs Summary: Fixes T11236, breaks long words and inlines the spans. Test Plan: Use a diff with super long text like SSH keys, set Font to 24/48 Impact {F1705910} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11236 Differential Revision: https://secure.phabricator.com/D16198
2016-06-30 05:27:11 +02:00
'rsrc/css/core/syntax.css' => '769d3498',
Basic Conpherence Search in Thread Summary: Adds a search bar toggle and results for searching inside a Conpherence Room. The UI of the results itself are not styled yet, and will follow up with another diff. Test Plan: Go to Conpherence, search for "asdf", get lots of results. Search for nothing, get no change, search for something fictitious, get no threads found (will follow up with search result UI). Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16697
2016-10-13 20:09:54 +02:00
'rsrc/css/core/z-index.css' => 'd1270942',
Redesign Diviner Summary: This implements `PHUIDocumentViewPro` which should move to be the base for all documents (Phame, Phriction, Legalpad, Diviner). Overall this feels really good to me, but I'd like to roll it out into Diviner specifically first to work through the issues and then move into other apps and drop `PHUIDocumentView` once everything is converted. Some features are: - White Background, no border on page - Table of Contents is move to hidden menu (more space for documentation) - Property List sits under the document Some design decisions above are in anticipation of Phriction v3 and Unbeta Phame, specifically commenting and maybe some cool new Remarkup text layout options for Phame. Test Plan: Went through tons of pages on Diviner on Desktop, Tablet, Mobile. Bounce back to Phriction to make sure DocumentView CSS changes actually look better there. {F930518} {F930519} {F930520} {F930521} Reviewers: epriestley Reviewed By: epriestley Subscribers: tycho.tatitscheff, joshuaspence, Korvin Differential Revision: https://secure.phabricator.com/D14374
2015-11-01 17:56:46 +01:00
'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/css/font/font-aleo.css' => '8bdb2835',
Update to FontAwesome 4.6.0 Summary: Updates to the latest icon packages Test Plan: View UIExamples, find new Icons Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15684
2016-04-11 20:29:12 +02:00
'rsrc/css/font/font-awesome.css' => '2b7ebbcc',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/css/font/font-lato.css' => 'c7ccd872',
Redesign Config Application Summary: Ref T11132, significantly cleans up the Config app, new layout, icons, spacing, etc. Some minor todos around re-designing "issues", mobile support, and maybe another pass at actual Group pages. Test Plan: Visit and test every page in the config app, set new items, resolve setup issues, etc. Reviewers: epriestley Reviewed By: epriestley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam, Korvin Maniphest Tasks: T11132 Differential Revision: https://secure.phabricator.com/D16468
2016-08-30 00:36:13 +02:00
'rsrc/css/font/phui-font-icon-base.css' => '870a7360',
[Redesign] Update Filetree CSS Summary: Tweaks colors, updates icons Test Plan: Tested a filetree view, clicked and hovered. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9335
2014-05-30 01:04:50 +02:00
'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
Normalize Paste, Remarkup code embed colors Summary: These currently use different yellows, and more importantly when pygmentized, is hard to read. This lightens up code embeds and pastes. Test Plan: Review Diviner docs, Pastes, and normal code embeds. {F820471} Reviewers: epriestley Reviewed By: epriestley Subscribers: tycho.tatitscheff, Korvin Differential Revision: https://secure.phabricator.com/D14123
2015-09-17 17:23:22 +02:00
'rsrc/css/layout/phabricator-source-code-view.css' => 'cbeef983',
Provide better headers and crumbs for Calendar result views Summary: Ref T11326. This isn't perfect, but should be a little easier to use and less weird/confusing. Generally, provide a "Query > Month > Day" crumb on day views, and a "Wed, July 3" header. Generally, provide a "Query > Month" crumb on month views, and a "July 2019" header. Also try to fix a bit of padding/spacing on the day view. Test Plan: {F1739128} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16338
2016-07-27 18:07:29 +02:00
'rsrc/css/phui/calendar/phui-calendar-day.css' => '572b1893',
'rsrc/css/phui/calendar/phui-calendar-list.css' => 'fcc9fb41',
Give Calendar days from adjacent months a background color hint Summary: Ref T11326. When viewing "February", add a class to dates in January and March to let them be styled a little differently as a UI hint. For now, I've given them a grey background. (Calendar.app changes the date number color instead.) Test Plan: {F1738990} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16336
2016-07-27 16:23:07 +02:00
'rsrc/css/phui/calendar/phui-calendar-month.css' => '8e10e92c',
Redesign Application Search Summary: This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut. Test Plan: Config, Maniphest, Differential, Diffusion, Home. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16346
2016-08-01 21:06:35 +02:00
'rsrc/css/phui/calendar/phui-calendar.css' => '477acfaa',
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
'rsrc/css/phui/phui-action-list.css' => 'c5eba19d',
Usability updates to ActionPanel Summary: Wraps entire element in the anchor tag, gives a hover state, makes icons bounce. Test Plan: Hover and click. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14124
2015-09-17 17:22:23 +02:00
'rsrc/css/phui/phui-action-panel.css' => '91c7b835',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'rsrc/css/phui/phui-badge.css' => '3baef8db',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'rsrc/css/phui/phui-basic-nav-view.css' => '7093573b',
Add more NUX states Summary: Adds basic NUX to Dashboards, Herald, Repositories, Maniphest. Note Herald and Dashboard Panels don't fine the nux for some reason, assume they will when modernized? Test Plan: Read text, click buttons. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14844
2015-12-21 20:15:44 +01:00
'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
Increase specificity in blue property boxes Summary: Feels a little hairy, but should be fine overall. Ups the css specificity enough that it's always displayed the same. The main problem is headers and boxes get put everywhere, and sometimes override each other. Fixes T10757 Test Plan: review a countdown in a phame post and phriction document. Check diviner, phriction for regressions. Reviewers: epriestley, #phacility Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10757 Differential Revision: https://secure.phabricator.com/D15664
2016-04-09 19:07:02 +02:00
'rsrc/css/phui/phui-box.css' => '5c8387cf',
Clean up menu folding in action list Summary: Just removing the animation for now, can't find anything decent, I think that the issue is the animation is applying to all items in the list, and not just as a list as a single block. That is, I'd like to slide down all three at one. Any animation that slides them down when attached to each item makes them overlap at the first frame and it's a little distracting. Not a big deal to leave this out for now. Whatever we come up with should likely be applied to phuix-dropdown as well. Test Plan: Clicky Clicky. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16159
2016-06-21 21:54:35 +02:00
'rsrc/css/phui/phui-button.css' => '4a5fbe3d',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
Rough in of NUX Guide steps Summary: Ref T11132. Will work on CSS tomorrow, but wanted to rough in the UI Steps to get guidance. Not sure what you have in mind for the "app" part, if you want to explain it and I build or you build. Test Plan: Visit each page and click on links. Very rough and unfinished. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11132 Differential Revision: https://secure.phabricator.com/D16419
2016-08-20 22:11:02 +02:00
'rsrc/css/phui/phui-cms.css' => 'be43c8a8',
Printable pages for PHUIDocumentViewPro Summary: Fixes T10131. Adds new CSS to better present document pages for printing. Added a print link to Phriction. Test Plan: Tested Phriction, Phame, and Legalpad. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10131 Differential Revision: https://secure.phabricator.com/D16524
2016-09-09 03:46:19 +02:00
'rsrc/css/phui/phui-crumbs-view.css' => '195ac419',
Add a few more high contrast CSS rules Summary: In new PHUITwoColumnLayout, some new colors were used that aren't in the High Contrast PostProcessor. Adding them and proper fallbacks. Test Plan: High Contrast on/off on a timeline page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16515
2016-09-07 20:02:54 +02:00
'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4',
Printable pages for PHUIDocumentViewPro Summary: Fixes T10131. Adds new CSS to better present document pages for printing. Added a print link to Phriction. Test Plan: Tested Phriction, Phame, and Legalpad. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10131 Differential Revision: https://secure.phabricator.com/D16524
2016-09-09 03:46:19 +02:00
'rsrc/css/phui/phui-document-pro.css' => 'ca1fed81',
Add a Read More link to PHUIDocumentSummaryView Summary: Currently it's difficult to notice posts may be much longer than the summary (in most cases, actually), Adds a consistent "Read More" link to the full post. Also made sure "violet" was more consistantly used. Test Plan: Review summaries in Phame {F1031799} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14827
2015-12-19 21:28:18 +01:00
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
Remove PHUIDocumentView Summary: Converts final call site to PHUIDocumentViewPro. Test Plan: grep for PHUIDocumentView, view new Welcome Page Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16379
2016-08-08 05:04:57 +02:00
'rsrc/css/phui/phui-document.css' => 'c32e8dec',
Remove box-shadow from feed story actors Summary: We've been removing these, remove for consistency. Test Plan: profile image with transparency Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16687
2016-10-11 19:02:22 +02:00
'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9',
Update Phriction for PHUIDocumentViewPro Summary: Moves Phriction to use PHUIDocumentViewPro Test Plan: Read lots of documents, tablet, mobile, and desktop. Check ToC, non ToC, Edit a Maniphest Task, New Phriction Document, edit Phriction Document. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9826 Differential Revision: https://secure.phabricator.com/D14399
2015-11-22 22:10:41 +01:00
'rsrc/css/phui/phui-fontkit.css' => '9cda225e',
Make Conpherence Pontificate Send-on-Enter Summary: Fixes T11623. Enables send-on-enter and shift-enter for linebreaks, per durable column. Also cleaned up UI for Joining Room or Logging In. Test Plan: See room I can join, click Join Room. Leave Room, Log out, visit room with login prompt. Login, Join Room again. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11623 Differential Revision: https://secure.phabricator.com/D16595
2016-09-28 04:26:02 +02:00
'rsrc/css/phui/phui-form-view.css' => '9e22b190',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
Redesign Application Search Summary: This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut. Test Plan: Config, Maniphest, Differential, Diffusion, Home. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16346
2016-08-01 21:06:35 +02:00
'rsrc/css/phui/phui-header-view.css' => '06385974',
Add ProjectCardView, use on Hovercards Summary: Builds a new ProjectCardView, starts basic Project Hovercard redesign (needs milestone, subproject support). Ref T10055 Test Plan: View all the colors. {F1092622} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10055 Differential Revision: https://secure.phabricator.com/D15186
2016-02-05 05:11:36 +01:00
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
Basic Conpherence Search in Thread Summary: Adds a search bar toggle and results for searching inside a Conpherence Room. The UI of the results itself are not styled yet, and will follow up with another diff. Test Plan: Go to Conpherence, search for "asdf", get lots of results. Search for nothing, get no change, search for something fictitious, get no threads found (will follow up with search result UI). Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16697
2016-10-13 20:09:54 +02:00
'rsrc/css/phui/phui-icon.css' => '417f80fb',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'rsrc/css/phui/phui-info-view.css' => '28efab79',
Added initial class for displaying invisible chars Summary: Fixes T11586. First pass at a class for displaying invisible characters. Still need to: - Write a couple unit tests - Add some styling to the .invisible-special spans - Actually start using the class when displaying form errors to users Currently this makes the string `"\nab\x00c\x01d\te\nf"` look like: {F1812711} Test Plan: Unit tests all pass and run in <1ms: {F1812998} Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley, yelirekim Maniphest Tasks: T11586 Differential Revision: https://secure.phabricator.com/D16541
2016-09-12 14:53:54 +02:00
'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0',
Straighten out reorder permissions on form configurations Summary: Fixes T10012. The permissions here are little weird: you need edit permission on the //configurations//, not the //engines//. I was checking edit permission on the engines only. I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789. Test Plan: - Tried to reorder forms as a less-privileged user, got proper policy errors. - Reordered forms normally as a regular user. Reviewers: chad Reviewed By: chad Subscribers: Luke081515.2 Maniphest Tasks: T10012 Differential Revision: https://secure.phabricator.com/D14824
2015-12-19 15:29:48 +01:00
'rsrc/css/phui/phui-list.css' => '9da2aa00',
Convert Differential to new layout Summary: First pass at converting Differential, I likely have some buggy-poos but thought I'd toss this up now in case very bad bugs present. To do: - Need to put status back on Hovercards - "Diff Detail" probably needs a better design Test Plan: Looking at lots of diffs, admittedly I dont have harbormaster, etc, running locally. Checked Diffusion for Table of Content changes on small and large commits. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15463
2016-03-12 22:02:32 +01:00
'rsrc/css/phui/phui-object-box.css' => '6b487c57',
Add some icons/color to Config Settings UI Summary: This adds status icons, locked, hidden, editable, customized, to the list of options in config. Makes it easier to read and assertain state. Test Plan: View a hidden, customized, editable, and locked. {F1796320} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16475
2016-08-30 21:53:09 +02:00
'rsrc/css/phui/phui-object-item-list-view.css' => '87278fa0',
[Redesign] PHUIPagerView Summary: Ref T8099, Moves AphrontPagerView to PHUIPagerView, converts to standard PHUIButtons and adds some additional features for icon placement on buttons. Test Plan: Tested Advanced Search and Searching files in Diffusion. Works as expected. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8342, T8099 Differential Revision: https://secure.phabricator.com/D13092
2015-06-02 23:34:04 +02:00
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
[Redesign] Center Pinboard Items Summary: Ref T8099, This centers, but floats, all pinboards items based on screen width. Test Plan: Test desktop, mobile break points. Items scale nicely. {F459680} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13085
2015-05-31 23:28:16 +02:00
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
Fix collapse background color on profile-menu Summary: This color needs to be fixed since we want the collapse icon over the menu. Test Plan: Shrink window so area has to scroll, see collapse above the rest of the menu. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16674
2016-10-05 23:36:12 +02:00
'rsrc/css/phui/phui-profile-menu.css' => '4768721a',
Break white-space on tags in any property list Summary: Fixes T11209. We want to always break tags when displaying them in a list, but not in general (remarkup). Test Plan: Fake a tag on a differental revision with a really long name. See wrapping. Reviewers: avivey, epriestley Reviewed By: avivey, epriestley Subscribers: avivey, Korvin Maniphest Tasks: T11209 Differential Revision: https://secure.phabricator.com/D16175
2016-06-24 21:10:20 +02:00
'rsrc/css/phui/phui-property-list-view.css' => '6d8e58ac',
Use new DocumentView for Legalpad previews Summary: Moves to showing Legalpad previews using PHUIDocumentViewPro Test Plan: Create a new document, edit an existing document Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14550
2015-11-23 18:17:36 +01:00
'rsrc/css/phui/phui-remarkup-preview.css' => '1a8f2591',
Minor CSS touches to workboard quest experience Summary: minor spacing updates, but i need to likely take a more details pass, specifically points look janky with project tags since they are not in the same `li`. Test Plan: Zoom into tags, see they all are same height and align. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15255
2016-02-12 02:04:14 +01:00
'rsrc/css/phui/phui-segment-bar-view.css' => '46342871',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/css/phui/phui-spacing.css' => '042804d6',
New icons, colors for per reviewer status Summary: Fixes T10906, Fixes T10820. Adds new icons, grey-er colors for previous states. Also, I think fixed a few bugs? Test Plan: Fake each state, verify icon is as intended. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10820, T10906 Differential Revision: https://secure.phabricator.com/D15830
2016-05-01 21:48:56 +02:00
'rsrc/css/phui/phui-status.css' => 'd5263e49',
Update Maniphest for PHUITwoColumnView Summary: Reworks Maniphest into a two column view. Moves priority and color to header, assignee to sidebar. quest points to header, and author to gutter. may be some confusion since priority only displays on open tickets. Test Plan: with and without description, custom fields, points, tablet, mobile and desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15396
2016-03-05 00:44:24 +01:00
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
add renderValue() in transactions Summary: fix T11290. Test Plan: Paste language type, view in web and in emails (It uses quotes in HTML emails, which I think is something else). Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: chad, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T11290 Differential Revision: https://secure.phabricator.com/D16252
2016-07-09 01:01:42 +02:00
'rsrc/css/phui/phui-timeline-view.css' => 'bc523970',
Clean up mobile css on config page Summary: I seemed to have missed this, lots of funky desktop padding on mobile. Test Plan: Review Config / Maniphest / etc on a mobile browser. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16731
2016-10-20 00:01:41 +02:00
'rsrc/css/phui/phui-two-column-view.css' => 'bbe32c23',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
'rsrc/css/phui/workboards/phui-workboard.css' => 'e09eb53a',
Clean up "points" display on workboards Summary: Couple of edge cases here I never cleaned up. This inlines points and projects better, with spacing and use of grey to better differentate from project tag colors. Test Plan: Review edge cases on workboard with multiple short and long project names. {F1653998} {F1653999} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15956
2016-05-20 22:03:26 +02:00
'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5',
Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds Summary: Cleans up the backgrounds a little on Projects/Profiles and adds a number of colour choices for Workboards. Test Plan: Manually add each color for testing. Test new project / profile layouts with and without properties. {F1109325} {F1109326} {F1109327} {F1109328} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15269
2016-02-13 20:55:14 +01:00
'rsrc/css/phui/workboards/phui-workpanel.css' => '92197373',
Add Slack authentication adapter Summary: For phabricator. Adds a Slack auth adapater and icon. Test Plan: Create a new Slack Application for login, generate id and secret. Activate login and registration for Slack. Create a new account with Slack credentials. Log out. Log in with Slack credentials. Set my avatar with Slack. Slack. Slack. {F1802649} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16496
2016-09-06 17:50:37 +02:00
'rsrc/css/sprite-login.css' => '6dbbbd97',
More tokens Summary: Ref T11244. 8 more tokens. Probably need better math on the selector? Test Plan: Award Dat Boi. Reviewers: epriestley Reviewed By: epriestley Subscribers: putnam, Korvin Maniphest Tasks: T11244 Differential Revision: https://secure.phabricator.com/D16228
2016-07-04 03:32:31 +02:00
'rsrc/css/sprite-tokens.css' => '9cdfd599',
Generate syntax highlighting CSS from a reusable map Summary: Ref T9790. This prepares the syntax color rules to be reused in mail. This goes about halfway toward T5701 by sort-of supporting different styles but not really. Test Plan: - Ran `bin/celerity syntax` to regenerate syntax map. - Viewed some highlighted code, didn't see any differences. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9790 Differential Revision: https://secure.phabricator.com/D15846
2016-05-05 03:24:59 +02:00
'rsrc/css/syntax/syntax-default.css' => '9923583c',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'rsrc/externals/d3/d3.min.js' => 'a11a5ff2',
Replace Roboto Slab with Aleo for PHUIDocumentView Summary: These fonts are functionally very similar, but in diagnosing a problem with mobile Safari/Chrome, it turned out that our use of "bold" with the "normal" font build created a "semibold" look when on desktop and a "normal" look on mobile. The "semibold" feel is more important, so finding a lighter "bold" font was the impetus for this font switch. As it turns out **Aleo** is built by the same author as **Lato** (our other font) and is intended as it's companion. So stylistically, this is the more correct font. Test Plan: Test Phriction, Legalpad, Diviner, Desktop and Mobile {F938013} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14391
2015-11-03 04:56:45 +01:00
'rsrc/externals/font/aleo/aleo-bold.eot' => 'd3d3bed7',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/aleo/aleo-bold.svg' => '45899c8e',
Replace Roboto Slab with Aleo for PHUIDocumentView Summary: These fonts are functionally very similar, but in diagnosing a problem with mobile Safari/Chrome, it turned out that our use of "bold" with the "normal" font build created a "semibold" look when on desktop and a "normal" look on mobile. The "semibold" feel is more important, so finding a lighter "bold" font was the impetus for this font switch. As it turns out **Aleo** is built by the same author as **Lato** (our other font) and is intended as it's companion. So stylistically, this is the more correct font. Test Plan: Test Phriction, Legalpad, Diviner, Desktop and Mobile {F938013} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14391
2015-11-03 04:56:45 +01:00
'rsrc/externals/font/aleo/aleo-bold.ttf' => '4b08bef0',
'rsrc/externals/font/aleo/aleo-bold.woff' => '93b513a1',
'rsrc/externals/font/aleo/aleo-bold.woff2' => '75fbf322',
'rsrc/externals/font/aleo/aleo-regular.eot' => 'a4e29e2f',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/aleo/aleo-regular.svg' => '42a86f7a',
Replace Roboto Slab with Aleo for PHUIDocumentView Summary: These fonts are functionally very similar, but in diagnosing a problem with mobile Safari/Chrome, it turned out that our use of "bold" with the "normal" font build created a "semibold" look when on desktop and a "normal" look on mobile. The "semibold" feel is more important, so finding a lighter "bold" font was the impetus for this font switch. As it turns out **Aleo** is built by the same author as **Lato** (our other font) and is intended as it's companion. So stylistically, this is the more correct font. Test Plan: Test Phriction, Legalpad, Diviner, Desktop and Mobile {F938013} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14391
2015-11-03 04:56:45 +01:00
'rsrc/externals/font/aleo/aleo-regular.ttf' => '751e7479',
'rsrc/externals/font/aleo/aleo-regular.woff' => 'c3744be9',
'rsrc/externals/font/aleo/aleo-regular.woff2' => '851aa0ee',
Update to FontAwesome 4.6.0 Summary: Updates to the latest icon packages Test Plan: View UIExamples, find new Icons Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15684
2016-04-11 20:29:12 +02:00
'rsrc/externals/font/fontawesome/fontawesome-webfont.eot' => '59b3076c',
'rsrc/externals/font/fontawesome/fontawesome-webfont.ttf' => '45ad7e57',
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff' => 'f861e2a8',
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff2' => '0ee0f078',
Smaller Lato font footprint Summary: About 1/3 the size. The "Full" Lato set is over 3000 Glyphs, this was a handbuilt set of Latin, Latin-A, and Latin-B. Specific Unicode set: ```U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF, U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000``` This unicode set is what Google Fonts uses as "Latin,Latin-Ext" Test Plan: Built test pages in Phriction for Latin-A, Latin-B. Checked Chrome, Firefox, Mac and PC. If issues get reported, can default back to larger font pack. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8755 Differential Revision: https://secure.phabricator.com/D13558
2015-07-06 16:17:11 +02:00
'rsrc/externals/font/lato/lato-bold.eot' => '99fbcf8c',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/lato/lato-bold.svg' => '2aa83045',
Smaller Lato font footprint Summary: About 1/3 the size. The "Full" Lato set is over 3000 Glyphs, this was a handbuilt set of Latin, Latin-A, and Latin-B. Specific Unicode set: ```U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF, U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000``` This unicode set is what Google Fonts uses as "Latin,Latin-Ext" Test Plan: Built test pages in Phriction for Latin-A, Latin-B. Checked Chrome, Firefox, Mac and PC. If issues get reported, can default back to larger font pack. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8755 Differential Revision: https://secure.phabricator.com/D13558
2015-07-06 16:17:11 +02:00
'rsrc/externals/font/lato/lato-bold.ttf' => '0a7141f7',
'rsrc/externals/font/lato/lato-bold.woff' => 'f5db2061',
'rsrc/externals/font/lato/lato-bold.woff2' => '37a94ecd',
'rsrc/externals/font/lato/lato-bolditalic.eot' => 'b93389d0',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/lato/lato-bolditalic.svg' => '5442e1ef',
Smaller Lato font footprint Summary: About 1/3 the size. The "Full" Lato set is over 3000 Glyphs, this was a handbuilt set of Latin, Latin-A, and Latin-B. Specific Unicode set: ```U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF, U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000``` This unicode set is what Google Fonts uses as "Latin,Latin-Ext" Test Plan: Built test pages in Phriction for Latin-A, Latin-B. Checked Chrome, Firefox, Mac and PC. If issues get reported, can default back to larger font pack. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8755 Differential Revision: https://secure.phabricator.com/D13558
2015-07-06 16:17:11 +02:00
'rsrc/externals/font/lato/lato-bolditalic.ttf' => 'dad31252',
'rsrc/externals/font/lato/lato-bolditalic.woff' => 'e53bcf47',
'rsrc/externals/font/lato/lato-bolditalic.woff2' => 'd035007f',
'rsrc/externals/font/lato/lato-italic.eot' => '6a903f5d',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/lato/lato-italic.svg' => '0dc7cf2f',
Smaller Lato font footprint Summary: About 1/3 the size. The "Full" Lato set is over 3000 Glyphs, this was a handbuilt set of Latin, Latin-A, and Latin-B. Specific Unicode set: ```U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF, U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000``` This unicode set is what Google Fonts uses as "Latin,Latin-Ext" Test Plan: Built test pages in Phriction for Latin-A, Latin-B. Checked Chrome, Firefox, Mac and PC. If issues get reported, can default back to larger font pack. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8755 Differential Revision: https://secure.phabricator.com/D13558
2015-07-06 16:17:11 +02:00
'rsrc/externals/font/lato/lato-italic.ttf' => '629f64f0',
'rsrc/externals/font/lato/lato-italic.woff' => '678dc4bb',
'rsrc/externals/font/lato/lato-italic.woff2' => '7c8dd650',
'rsrc/externals/font/lato/lato-regular.eot' => '848dfb1e',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'rsrc/externals/font/lato/lato-regular.svg' => 'cbd5fd6b',
Smaller Lato font footprint Summary: About 1/3 the size. The "Full" Lato set is over 3000 Glyphs, this was a handbuilt set of Latin, Latin-A, and Latin-B. Specific Unicode set: ```U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF, U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000``` This unicode set is what Google Fonts uses as "Latin,Latin-Ext" Test Plan: Built test pages in Phriction for Latin-A, Latin-B. Checked Chrome, Firefox, Mac and PC. If issues get reported, can default back to larger font pack. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8755 Differential Revision: https://secure.phabricator.com/D13558
2015-07-06 16:17:11 +02:00
'rsrc/externals/font/lato/lato-regular.ttf' => 'e270165b',
'rsrc/externals/font/lato/lato-regular.woff' => '13d39fe2',
'rsrc/externals/font/lato/lato-regular.woff2' => '57a9f742',
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'rsrc/externals/javelin/core/Event.js' => '2ee659ce',
'rsrc/externals/javelin/core/Stratcom.js' => '6ad39b6f',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/core/__tests__/event-stop-and-kill.js' => '717554e4',
'rsrc/externals/javelin/core/__tests__/install.js' => 'c432ee85',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313',
'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d',
Scroll the chat column to the bottom when images load Summary: Fixes T7558. This might not be 100% perfect but should solve most of the issue. I briefly looked at things like `MutationObserver` (some fancy next-gen browser junk) but couldn't immediately get it working. Other methods for handling this kind of thing involve polling, complicated polyfills, etc. We could give `MutationObserver` a more serious effort if this is too leaky. Test Plan: - In a thread with some images, reloaded the page and saw the scrollbar stay at the bottom. - Tested with and without USB devices attached. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7558 Differential Revision: https://secure.phabricator.com/D12191
2015-03-28 16:35:12 +01:00
'rsrc/externals/javelin/core/init.js' => '3010e992',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/core/init_node.js' => 'c234aded',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/core/install.js' => '05270951',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/core/util.js' => '93cc50d6',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/docs/Base.js' => '74676256',
'rsrc/externals/javelin/docs/onload.js' => 'e819c479',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
'rsrc/externals/javelin/ext/fx/FX.js' => '54b612ba',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/reactor/core/DynVal.js' => 'f6555212',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/reactor/core/Reactor.js' => '2b8de964',
'rsrc/externals/javelin/ext/reactor/core/ReactorNode.js' => '1ad0a787',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/reactor/core/ReactorNodeCalmer.js' => '76f4ebed',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/reactor/dom/RDOM.js' => 'c90a04fc',
'rsrc/externals/javelin/ext/view/HTMLView.js' => 'fe287620',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/view/View.js' => '0f764c35',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/view/ViewInterpreter.js' => 'f829edb3',
'rsrc/externals/javelin/ext/view/ViewPlaceholder.js' => '47830651',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/ext/view/ViewRenderer.js' => '6c2b09a2',
'rsrc/externals/javelin/ext/view/ViewVisitor.js' => 'efe49472',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/view/__tests__/HTMLView.js' => 'f92d7bcb',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/ext/view/__tests__/View.js' => '6450b38b',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => '7a94d6a5',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '6ea96ac9',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'rsrc/externals/javelin/lib/Cookie.js' => '62dfea03',
Fix an issue with "packages(...)" in typeaheads Summary: Fixes T9302. This datasource wasn't resolving package PHIDs correctly for the actual query. Also fixes an issue with the "Affected packages that need audit" Herald rule. Test Plan: Ran a "Needs Audit" query with only packages, and only `packages(user)`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9302 Differential Revision: https://secure.phabricator.com/D14029
2015-09-02 00:35:25 +02:00
'rsrc/externals/javelin/lib/DOM.js' => '805b806a',
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'rsrc/externals/javelin/lib/History.js' => 'd4505101',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
Probably improve behavior around duplicate notifications Summary: We're sometimes getting duplicate notifications right now. I think this is because multiple windows are racing and becoming leaders. Clean this up a little: - Fix the `timeoout` typo. - Only try to usurp once. - Use different usurp and expire delays, so we don't fire them at the exact same time. Not sure if this'll work or not but it should theoretically be a little cleaner. Test Plan: - Quit Safari, reopened Safari, still saw a fast reconnect to the notification server (this is the goal of usurping). - Did normal notification stuff like opening a chat in two windows, got notifications. - Hard to reproduce the race for sure, but this at least fixes the outright `timeoout` bug. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15806
2016-04-27 01:27:31 +02:00
'rsrc/externals/javelin/lib/Leader.js' => 'fea0eb47',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/Mask.js' => '8a41885b',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'rsrc/externals/javelin/lib/Quicksand.js' => '6b8ef10b',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/Request.js' => '94b750d2',
'rsrc/externals/javelin/lib/Resource.js' => '44959b73',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/externals/javelin/lib/Routable.js' => 'b3e7d692',
'rsrc/externals/javelin/lib/Router.js' => '29274e2b',
Refine durable column class toggling Summary: don't bother with margin class if column isn't visible. Ref T8151. Test Plan: using chrome with trackpad - loaded home with toggled off column - noted no margin class erroneously applied - toggled column off and on - correct - loaded home with toggled on column - correct - toggled column off and on - correct Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8151 Differential Revision: https://secure.phabricator.com/D12795
2015-05-11 22:50:44 +02:00
'rsrc/externals/javelin/lib/Scrollbar.js' => '087e919c',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'rsrc/externals/javelin/lib/Sound.js' => '949c0fe5',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'rsrc/externals/javelin/lib/URI.js' => 'c989ade3',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/externals/javelin/lib/Vector.js' => '2caa8fb8',
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'rsrc/externals/javelin/lib/WebSocket.js' => 'e292eaf4',
Allow dialogs to opt in to being resizable Summary: Ref T11034. Ref T4788. This allows you to resize the typeahead browse dialog if you want. I plan to let you resize the object selector dialog in the future. Test Plan: {F1695433} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788, T11034 Differential Revision: https://secure.phabricator.com/D16156
2016-06-21 02:29:56 +02:00
'rsrc/externals/javelin/lib/Workflow.js' => '1e911d0f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/externals/javelin/lib/__tests__/Cookie.js' => '5ed109e8',
'rsrc/externals/javelin/lib/__tests__/DOM.js' => 'c984504b',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/__tests__/JSON.js' => '837a7d68',
Remove an unused variable Summary: This variable is unused. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11440
2015-01-20 11:25:17 +01:00
'rsrc/externals/javelin/lib/__tests__/URI.js' => '1e45fda9',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/externals/javelin/lib/__tests__/behavior.js' => '1ea62783',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/behavior.js' => '61cbc29a',
Give custom controls passable disabled states Summary: Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing. Test Plan: {F1029090} - Tried to use controls, got reasonable behavior. - Used normal controls to make sure I didn't break anything. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9871, T10004 Differential Revision: https://secure.phabricator.com/D14814
2015-12-17 22:27:36 +01:00
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '8d3bc1b2',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => '70baed2f',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'e6e25838',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '503e17fd',
Hide the autocompleter intelligently when you ignore it and keep typing Summary: Ref T10163. When we think the user has finished typing a word (because they typed a space, period, or other similar characters) and nothing else they might type could possibly change the outcome (usually because the words they have typed already match nothing), just deactivate the autocomplete. As a special case, if the word they have typed already select exactly one result, //and// they have already typed exactly that result, assume they just typed it from memory and deactivate. Test Plan: - Typed `@dog qwer zxcv` and saw autocomplete deactivate on the space before `z` (on my local install, `@dog` is ambiguous but `@dog qwer` matches nothing). - Typed `@epriestley ` and saw autocomplete deactivate on space. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10163 Differential Revision: https://secure.phabricator.com/D15039
2016-01-16 23:33:03 +01:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '013ffff9',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => 'b25d5444',
Time control typeaheads. Summary: Ref T8031, Time control typeaheads Test Plan: Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Maniphest Tasks: T8031 Differential Revision: https://secure.phabricator.com/D12953
2015-05-20 18:51:26 +02:00
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '6c0e62fa',
Rework new favicon Summary: This makes all favicons a background circle w/color and white gear, to be less confusing to an actual gear icon. Test Plan: review many different versions in sandbox. {F1811707,size=full} Reviewers: epriestley, avivey Reviewed By: avivey Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16539
2016-09-12 01:09:56 +02:00
'rsrc/favicons/apple-touch-icon-114x114.png' => '12a24178',
'rsrc/favicons/apple-touch-icon-120x120.png' => '0d1543c7',
'rsrc/favicons/apple-touch-icon-144x144.png' => '8043b5a5',
'rsrc/favicons/apple-touch-icon-152x152.png' => '65905ecd',
'rsrc/favicons/apple-touch-icon-57x57.png' => '2bfc7b0a',
'rsrc/favicons/apple-touch-icon-60x60.png' => '8ff52925',
'rsrc/favicons/apple-touch-icon-72x72.png' => 'a2bb65d6',
'rsrc/favicons/apple-touch-icon-76x76.png' => '2d061a11',
'rsrc/favicons/favicon-128.png' => '72f7e812',
'rsrc/favicons/favicon-16x16.png' => 'fc6275ba',
'rsrc/favicons/favicon-196x196.png' => '95db275e',
'rsrc/favicons/favicon-32x32.png' => '5bd18b6c',
'rsrc/favicons/favicon-96x96.png' => '7242c8e9',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'rsrc/favicons/favicon-mention.ico' => '1fdd0fa4',
'rsrc/favicons/favicon-message.ico' => '115bc010',
Support ".ico" in Celerity and simplify rewite rule configuration Summary: See D16734. - Add ".ico" files to the Celerity map. - Add a formal route for "/favicon.ico". - Remove instructions to configure `/rsrc/` and `/favicon.ico` rewrite rules. Long ago, we served resources directly via `/rsrc/` in at least some cases. As we added more features, this stopped working more and more often (for example, Apache can never serve CSS this way, because it doesn't know how to post-process `{$variables}`). In modern code (until this change), only `/favicon.ico` is still expected to be served this way. Instead, serve it with an explicit route via controller (this allows different Sites to have different favicons, for example). Remove the instructions suggesting the old rewrite rules be configured. It's OK if they're still in place -- they won't break anything, so we don't need to rush to get users to delete them. We should keep "webroot/favicon.ico" in place for now, since it needs to be there for users with the old rewrite rule. Test Plan: - Ran celerity map. - Loaded `/favicon.ico`, got resource via route. - Used `celerity_generate_resource_uri()` to get paths to other icons, loaded them, got icons. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16737
2016-10-20 20:14:33 +02:00
'rsrc/favicons/favicon.ico' => 'cdb11121',
Lots of favicons Summary: Swaps to new logo, new color for default favicon. Adds red, yellow, dark for other uses. perhaps. Test Plan: reload, see new favicon Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16530
2016-09-09 18:35:54 +02:00
'rsrc/favicons/mask-icon.svg' => 'e132a80f',
Rework new favicon Summary: This makes all favicons a background circle w/color and white gear, to be less confusing to an actual gear icon. Test Plan: review many different versions in sandbox. {F1811707,size=full} Reviewers: epriestley, avivey Reviewed By: avivey Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16539
2016-09-12 01:09:56 +02:00
'rsrc/favicons/mstile-144x144.png' => '310c2ee5',
'rsrc/favicons/mstile-150x150.png' => '74bf5133',
'rsrc/favicons/mstile-310x150.png' => '4a49d3ee',
'rsrc/favicons/mstile-310x310.png' => 'a52ab264',
'rsrc/favicons/mstile-70x70.png' => '5edce7b8',
Use pixel as background of timeline Summary: Makes the line in timeline a background "image" instead. Test Plan: Tested Desktop, Mobile, and Tablet breakpoints with lots of content. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8221
2014-02-14 00:15:58 +01:00
'rsrc/image/BFCFDA.png' => 'd5ec91f4',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/actions/edit.png' => '2fc41442',
Actual 2x avatar, new profile picture options Summary: Provides a real 2x avatar and offers new built in images for profile pictures. Test Plan: reload profile, see sharper image, pick eevee, see eevee Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14668
2015-12-04 21:30:38 +01:00
'rsrc/image/avatar.png' => 'e132bb6a',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/checker_dark.png' => 'd8e65881',
'rsrc/image/checker_light.png' => 'a0155918',
Switch Pholio over to lighter layout. Summary: Gets rid of all the dark css. Test Plan: Do it live. {F166665} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9545
2014-06-15 16:44:12 +02:00
'rsrc/image/checker_lighter.png' => 'd5da91b6',
Polish up timeline for PHIUTwoColumnView Summary: This inverts colors and icons a bit, so they're not as harsh. So instead of a dark green item with white icon, its now light green with a dark green icon. I've also changed all text and comment boxes to be "grey" visually to separate out the UI from converation/actions. Give it a spin and let me know how this feels. I still need to update the comment UI. Test Plan: UIExamples, lots of various tasks and diffs. {F1163837} {F1163839} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15442
2016-03-09 02:50:01 +01:00
'rsrc/image/d5d8e1.png' => '0c2a1497',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/darkload.gif' => '1ffd3ec6',
'rsrc/image/divot.png' => '94dded62',
PHUIImageMask Summary: Adds a PHUI class for display images on a center point, with or without a mask. Test Plan: I am bad a math, so like, check that for me please. I tested using Photoshop. Class may need tweaked depending how we store the inline-comment coords. {F167829} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9614
2014-06-18 23:09:37 +02:00
'rsrc/image/examples/hero.png' => '979a86ae',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/grippy_texture.png' => 'aca81e2f',
'rsrc/image/icon/fatcow/arrow_branch.png' => '2537c01c',
'rsrc/image/icon/fatcow/arrow_merge.png' => '21b660e0',
'rsrc/image/icon/fatcow/bullet_black.png' => 'ff190031',
'rsrc/image/icon/fatcow/bullet_orange.png' => 'e273e5bb',
'rsrc/image/icon/fatcow/bullet_red.png' => 'c0b75434',
'rsrc/image/icon/fatcow/calendar_edit.png' => '24632275',
'rsrc/image/icon/fatcow/document_black.png' => '45fe1c60',
'rsrc/image/icon/fatcow/flag_blue.png' => 'a01abb1d',
'rsrc/image/icon/fatcow/flag_finish.png' => '67825cee',
'rsrc/image/icon/fatcow/flag_ghost.png' => '20ca8783',
'rsrc/image/icon/fatcow/flag_green.png' => '7e0eaa7a',
'rsrc/image/icon/fatcow/flag_orange.png' => '9e73df66',
'rsrc/image/icon/fatcow/flag_pink.png' => '7e92f3b2',
'rsrc/image/icon/fatcow/flag_purple.png' => 'cc517522',
'rsrc/image/icon/fatcow/flag_red.png' => '04ec726f',
'rsrc/image/icon/fatcow/flag_yellow.png' => '73946fd4',
'rsrc/image/icon/fatcow/key_question.png' => '52a0c26a',
'rsrc/image/icon/fatcow/link.png' => '7afd4d5e',
'rsrc/image/icon/fatcow/page_white_edit.png' => '39a2eed8',
'rsrc/image/icon/fatcow/page_white_put.png' => '08c95a0c',
'rsrc/image/icon/fatcow/source/conduit.png' => '4ea01d2f',
'rsrc/image/icon/fatcow/source/email.png' => '9bab3239',
'rsrc/image/icon/fatcow/source/fax.png' => '04195e68',
'rsrc/image/icon/fatcow/source/mobile.png' => 'f1321264',
'rsrc/image/icon/fatcow/source/tablet.png' => '49396799',
'rsrc/image/icon/fatcow/source/web.png' => '136ccb5d',
'rsrc/image/icon/lightbox/close-2.png' => 'cc40e7c8',
'rsrc/image/icon/lightbox/close-hover-2.png' => 'fb5d6d9e',
'rsrc/image/icon/lightbox/left-arrow-2.png' => '8426133b',
'rsrc/image/icon/lightbox/left-arrow-hover-2.png' => '701e5ee3',
'rsrc/image/icon/lightbox/right-arrow-2.png' => '6d5519a0',
'rsrc/image/icon/lightbox/right-arrow-hover-2.png' => '3a04aa21',
'rsrc/image/icon/subscribe.png' => 'd03ed5a5',
'rsrc/image/icon/tango/attachment.png' => 'ecc8022e',
'rsrc/image/icon/tango/edit.png' => '929a1363',
'rsrc/image/icon/tango/go-down.png' => '96d95e43',
'rsrc/image/icon/tango/log.png' => 'b08cc63a',
'rsrc/image/icon/tango/upload.png' => '7bbb7984',
'rsrc/image/icon/unsubscribe.png' => '25725013',
Use more common styles for setup issue CSS Summary: Updates setup CSS to use more common colors, spacing. Test Plan: review a fatal, a common error, and uiexample Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8006
2014-01-18 17:31:47 +01:00
'rsrc/image/lightblue-header.png' => '5c168b6d',
Remove slight wash on transparent background on logo Summary: Very slight gradient behind the eye I didn't catch (extra layer). Test Plan: Remove all layers except logo, re-export. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16381
2016-08-08 22:21:18 +02:00
'rsrc/image/logo/light-eye.png' => '1a576ddd',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/main_texture.png' => '29a2c5ad',
'rsrc/image/menu_texture.png' => '5a17580d',
'rsrc/image/people/harding.png' => '45aa614e',
'rsrc/image/people/jefferson.png' => 'afca0e53',
'rsrc/image/people/lincoln.png' => '9369126d',
'rsrc/image/people/mckinley.png' => 'fb8f16ce',
'rsrc/image/people/taft.png' => 'd7bc402c',
Actual 2x avatar, new profile picture options Summary: Provides a real 2x avatar and offers new built in images for profile pictures. Test Plan: reload profile, see sharper image, pick eevee, see eevee Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14668
2015-12-04 21:30:38 +01:00
'rsrc/image/people/user0.png' => '03dacaea',
'rsrc/image/people/user1.png' => '4a4e7702',
'rsrc/image/people/user2.png' => '47a0ee40',
'rsrc/image/people/user3.png' => '835ff627',
'rsrc/image/people/user4.png' => 'b0e830f1',
'rsrc/image/people/user5.png' => '9c95b369',
'rsrc/image/people/user6.png' => 'ba3fbfb0',
'rsrc/image/people/user7.png' => 'da613924',
'rsrc/image/people/user8.png' => 'f1035edf',
'rsrc/image/people/user9.png' => '66730be3',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/people/washington.png' => '40dd301c',
'rsrc/image/phrequent_active.png' => 'a466a8ed',
'rsrc/image/phrequent_inactive.png' => 'bfc15a69',
Allow dialogs to opt in to being resizable Summary: Ref T11034. Ref T4788. This allows you to resize the typeahead browse dialog if you want. I plan to let you resize the object selector dialog in the future. Test Plan: {F1695433} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788, T11034 Differential Revision: https://secure.phabricator.com/D16156
2016-06-21 02:29:56 +02:00
'rsrc/image/resize.png' => 'fd476de4',
Add Slack authentication adapter Summary: For phabricator. Adds a Slack auth adapater and icon. Test Plan: Create a new Slack Application for login, generate id and secret. Activate login and registration for Slack. Create a new account with Slack credentials. Log out. Log in with Slack credentials. Set my avatar with Slack. Slack. Slack. {F1802649} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16496
2016-09-06 17:50:37 +02:00
'rsrc/image/sprite-login-X2.png' => '4abee916',
'rsrc/image/sprite-login.png' => '2b9663fd',
More tokens Summary: Ref T11244. 8 more tokens. Probably need better math on the selector? Test Plan: Award Dat Boi. Reviewers: epriestley Reviewed By: epriestley Subscribers: putnam, Korvin Maniphest Tasks: T11244 Differential Revision: https://secure.phabricator.com/D16228
2016-07-04 03:32:31 +02:00
'rsrc/image/sprite-tokens-X2.png' => '804a5232',
'rsrc/image/sprite-tokens.png' => 'b41d03da',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/image/texture/card-gradient.png' => '815f26e8',
'rsrc/image/texture/dark-menu-hover.png' => '5fa7ece8',
'rsrc/image/texture/dark-menu.png' => '7e22296e',
'rsrc/image/texture/grip.png' => '719404f3',
'rsrc/image/texture/panel-header-gradient.png' => 'e3b8dcfe',
'rsrc/image/texture/phlnx-bg.png' => '8d819209',
'rsrc/image/texture/pholio-background.gif' => 'ba29239c',
'rsrc/image/texture/table_header.png' => '5c433037',
'rsrc/image/texture/table_header_hover.png' => '038ec3b9',
'rsrc/image/texture/table_header_tall.png' => 'd56b434f',
Conpherence - make sure real time updates still work if you switch threads Summary: Fixes T8118. Turns out this also was broken in the main view if e.g. you went to just /conpherence/. The fix is to make sure the threadmanager js class explicitly manages subscriptions as the loaded thread changes. Test Plan: - from /conpherence/ was able to receive messages in real time. - from /conpherence/ changed threads and still received messages in real time - from durable column switched threads and received messages in real time Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8118 Differential Revision: https://secure.phabricator.com/D12758
2015-05-07 21:47:49 +02:00
'rsrc/js/application/aphlict/Aphlict.js' => '5359e785',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => '2a171a9d',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => 'fb20ac8d',
Add an icon to aphlict connection status Summary: A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc). Test Plan: Test in Notifications menu, Conpherence full, Durable Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16647
2016-10-02 05:37:28 +02:00
'rsrc/js/application/aphlict/behavior-aphlict-status.js' => '5e2634b9',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'rsrc/js/application/aphlict/behavior-desktop-notifications-control.js' => 'edd1ba66',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
Make Calendar day view a little more consistent Summary: Ref T11326. This just cleans things up a little and removes some of the obvious layout/CSS issues. Test Plan: - Viewed day view before/after. Also viewed profile panel. Before: {F1725547} After: {F1725548} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16308
2016-07-15 23:02:24 +02:00
'rsrc/js/application/calendar/behavior-day-view.js' => '4b3c4443',
Make the "All Day Event" control use a checkbox instead of a dropdown Summary: This feels a little cleaner: - Clean up transaction log a bit. - Use a checkbox instead of a two-option dropdown. This is a little messy because the browser doesn't send anything if the user submits a form with an un-clicked checkbox. We now send a dummy value ("Hey, there's definitely a checkbox in this form!") so the server can figure out what to do. Test Plan: - Edited all-dayness of an event. - Viewed transaction log. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16776
2016-10-31 19:38:35 +01:00
'rsrc/js/application/calendar/behavior-event-all-day.js' => 'b41537c9',
Give the Calendar month view a nice hover effect Summary: Ref T11326. Currently, we link Calendar days using hidden DOM nodes. This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers. Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise. Test Plan: {F1738941} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16334
2016-07-27 15:44:42 +02:00
'rsrc/js/application/calendar/behavior-month-view.js' => 'fe33e256',
Fix custom field selector control in cases where the user doesn't edit anything Summary: The JS and PHP representations of state can differ; just have the JS write the state out immediately on page load. Test Plan: Saved `diffusion.fields` without making changes, reloaded, saw no effective change. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12998
2015-05-25 14:34:23 +02:00
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '358c717b',
'rsrc/js/application/conpherence/behavior-conpherence-search.js' => '9bbf3762',
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'aa3bd034',
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'rsrc/js/application/conpherence/behavior-menu.js' => '7524fcfa',
Rebuild Conpherence Participants Pane Summary: Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user. Test Plan: Add to room, remove from room. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16560
2016-09-15 22:21:21 +02:00
'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8',
Make Conpherence Pontificate Send-on-Enter Summary: Fixes T11623. Enables send-on-enter and shift-enter for linebreaks, per durable column. Also cleaned up UI for Joining Room or Logging In. Test Plan: See room I can join, click Join Room. Leave Room, Log out, visit room with login prompt. Login, Join Room again. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11623 Differential Revision: https://secure.phabricator.com/D16595
2016-09-28 04:26:02 +02:00
'rsrc/js/application/conpherence/behavior-pontificate.js' => 'f2e58483',
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'rsrc/js/application/conpherence/behavior-toggle-widget.js' => '3dbf94d5',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'rsrc/js/application/countdown/timer.js' => 'e4cc26b3',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'rsrc/js/application/daemon/behavior-bulk-job-reload.js' => 'edf8a145',
Dashboards - add remove functionality Summary: To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084. Test Plan: removed some panels to much success Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078, T5084 Differential Revision: https://secure.phabricator.com/D9156
2014-05-19 23:04:26 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => '469c0d9e',
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '019f36c4',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'rsrc/js/application/differential/ChangesetViewManager.js' => 'a2828756',
Clean up browse/history links in Diffusion Summary: Fixes T9126. In particular: - Add "Browse" links to all history views. - Use icons to show "Browse" and "History" links, instead of text. - Use FontAwesome. - Generally standardize handling of these elements. This might need a little design attention, but I think it's an improvement overall. Test Plan: - Viewed repository history. - Viewed branch history. - Viewed file history. - Viewed table of contents on a commit. - Viewed merged changes on a merge commit. - Viewed a directory containing an external. - Viewed a deleted file. {F788419} {F788420} {F788421} {F788422} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9126 Differential Revision: https://secure.phabricator.com/D14096
2015-09-11 04:28:49 +02:00
'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '64a5550f',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
Maniphest + Differential - don't show transaction preview until user interacts with the form. Summary: Fixes T4846. These are one off (for now) since they have various crazy actions with them. I think this will get unified and more cleaned up when we refine the UI for taking multiple actions at once, etc. Test Plan: noted no "commented on x" in either maniphest or differential. starting making a comment and noted prevew showed. started adding a subscriber (added to tokenizer) and preview showed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4846 Differential Revision: https://secure.phabricator.com/D12936
2015-05-20 22:54:22 +02:00
'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '9a6b9324',
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '4fbbc3e9',
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'rsrc/js/application/differential/behavior-populate.js' => '8694b1df',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/differential/behavior-toggle-files.js' => 'ca3f91eb',
'rsrc/js/application/differential/behavior-user-select.js' => 'a8d8459d',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => 'b42eddc7',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'd835b03a',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/application/diffusion/behavior-commit-branches.js' => 'bdaf4d04',
Improve "thread" rendering of unusually-shaped graphs Summary: Ref T4788. This fixes all the bugs I was immediately able to catch: - "Directory-Like" graph shapes could draw too many vertical lines. - "Reverse-Directory-Like" graph shapes could draw too few vertical lines. - Terminated, branched graph shapes drew the very last line to the wrong place. This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything. Test Plan: - Added failing tests and made them pass. {F1708158} {F1708159} {F1708160} {F1708161} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 18:22:00 +02:00
'rsrc/js/application/diffusion/behavior-commit-graph.js' => '49ae8328',
Add coverage tooltips in Diffusion file browse mode Summary: Fixes T10816. The way these work is a little unusual since these chunks of file-rendering code are unusuall performance-sensitive, so the Differential version doesn't adapt directly to Diffusion. Both can possibly be unified at some point in the future, although they do slightly different things. Test Plan: {F1220170} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10816 Differential Revision: https://secure.phabricator.com/D15719
2016-04-15 14:37:58 +02:00
'rsrc/js/application/diffusion/behavior-diffusion-browse-file.js' => '054a0f0b',
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'rsrc/js/application/diffusion/behavior-jump-to.js' => '73d09eef',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/diffusion/behavior-load-blame.js' => '42126667',
Git did not 3-way merge this quite correctly.
2014-05-13 23:09:00 +02:00
'rsrc/js/application/diffusion/behavior-locate-file.js' => '6d3e1947',
Make Diffusion "Last Modified" rendering less fragile Summary: Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax. The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ. In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one). In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes. Test Plan: Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of. Applied this patch, got a clean render. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9524 Differential Revision: https://secure.phabricator.com/D14243
2015-10-07 16:32:27 +02:00
'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => 'f01586dc',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
Show a more reasonable status element for pull requests Summary: Ref T182. Replace the total mess we had before with a sort-of-reasonable element. This automatically updates using "javascript". Test Plan: {F901983} {F901984} Used "Land Revision", saw the land status go from "Waiting" -> "Working" -> "Landed" without having to mash reload over and over again. Reviewers: chad Reviewed By: chad Maniphest Tasks: T182 Differential Revision: https://secure.phabricator.com/D14314
2015-10-21 20:28:26 +02:00
'rsrc/js/application/drydock/drydock-live-operation-status.js' => '901935ef',
Remove defunt project image choices Summary: These are old project image choices, remove and only go with FontAwesome related images. Test Plan: Project -> Edit Picture -> Save Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15051
2016-01-19 17:43:31 +01:00
'rsrc/js/application/files/behavior-icon-composer.js' => '8499b6ab',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
Fix an initialization issue in Herald rules in Chrome Summary: Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values. Currently, the logic just sets everything to `null` or `'default'`. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.) Instead of relying on the browser to pick the right value, set the correct value explicitly. Test Plan: - Created a new rule in Chrome, Safari. - Added fields and conditions in Chrome, Safari. - Edited existing rules in Chrome, Safari. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10646 Differential Revision: https://secure.phabricator.com/D15507
2016-03-22 17:08:26 +01:00
'rsrc/js/application/herald/HeraldRuleEditor.js' => 'd6a7e717',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
Support Spaces in Maniphest batch editor Summary: Ref T8498. This editor is an artifact of the Old World at this point, but it still works fine. Test Plan: Moved tasks between spaces using the batch editor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8498 Differential Revision: https://secure.phabricator.com/D13249
2015-06-11 19:24:39 +02:00
'rsrc/js/application/maniphest/behavior-batch-editor.js' => '782ab6e7',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'rsrc/js/application/maniphest/behavior-line-chart.js' => 'e4232876',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
[Redesign] Fix Maniphest subpriority editing Summary: Ref T8099, Fixes T8338. This allows re-ordering of Maniphest Tasks in the redesign. Somehow seems more fragile, but I couldn't break anything with it. Test Plan: Try ordering into first position after header, last position, changing priority outright, everything I can drag. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8338 Differential Revision: https://secure.phabricator.com/D13487
2015-06-30 18:37:12 +02:00
'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '71237763',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/owners/OwnersPathEditor.js' => 'aa1733d0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/owners/owners-path-editor.js' => '7a68dda3',
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'rsrc/js/application/passphrase/passphrase-credential-control.js' => '3cb0b2fc',
Allow Pholio mocks to be created and edited without drag-and-drop Summary: Ref T6523. Allows you to click stuff instead of using drag-and-drop. Test Plan: On iOS simulator, created and updated a mock. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6523 Differential Revision: https://secure.phabricator.com/D16088
2016-06-09 17:34:00 +02:00
'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => 'bee502c8',
Quicksand and Pholio - make mock edit work Summary: Fixes T8036. In addition to making the mock edit work, this tightens quicksand code such that the correct page id is returned even if start() has not been called yet. It also tightens mock view where some functions should respect statics.enabled a bit more. Test Plan: clicked edit mock, mock crumb, edit mock, mock crum, edit mock, made edits and they worked! clicked edit mock, mock crumb, edit mock, mock crumb, edit mock, profile icon, hit browser back to edit mock, made edits and they worked! also observed mock view page not occasionally wigging out from image_onload race not having statics.enabled respect during the above Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8036 Differential Revision: https://secure.phabricator.com/D12739
2015-05-07 19:42:07 +02:00
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => 'fbe497e7',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
Slightly better spacing, colors on ProjectCards Summary: Fixes transparent background images, removes "checkered". Better spacing for tags. Test Plan: Upload a transparent logo, hover over project. {F1093753} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15188
2016-02-05 19:30:20 +01:00
'rsrc/js/application/policy/behavior-policy-control.js' => 'd0c516d5',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
Survive receipt of too much workboard column position information Summary: Fixes T11468. I was able to find //a// reproduction case for the issue, at least, described in my comments there. When the server sends back position information for columns we aren't displaying, for whatever reason, just ignore that information. Future work in T4900 to do more synchronization may revisit this. Test Plan: See T11468#190177 for steps. Did that stuff with this patch, got a clean edit. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11468 Differential Revision: https://secure.phabricator.com/D16397
2016-08-14 17:58:17 +02:00
'rsrc/js/application/projects/WorkboardBoard.js' => 'fe7cb52a',
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'rsrc/js/application/projects/WorkboardCard.js' => 'c587b80f',
When summing points on a workboard, display sum with same precision as most-precise value Summary: Fixes T11703. This mostly avoids rounding errors. If point values include "0.001", we also get three digits of precision: 1.000. Maybe useful if your point field is called "bitcoins" or something. Test Plan: Before: {F1851404} After: {F1851405} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11703 Differential Revision: https://secure.phabricator.com/D16601
2016-09-27 18:29:43 +02:00
'rsrc/js/application/projects/WorkboardColumn.js' => '21df4ff5',
Fix an issue with creating tasks directly into milestone columns Summary: These columns were conflating `projectPHID` (the defualt project to add to the task) with `boardPHID` (the board the column appears on). Separate them to fix the beahvior. Test Plan: Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15242
2016-02-11 18:51:32 +01:00
'rsrc/js/application/projects/WorkboardController.js' => '55baf5ed',
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'rsrc/js/application/projects/behavior-project-boards.js' => '14a1faae',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'rsrc/js/application/releeph/releeph-request-state-change.js' => 'a0b57eb8',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
Symbol Search: Allow ctrl-click with no hover Summary: Fix T8710. I had hopes of doing something cleaver with `highlighted` (Like trying to understand `foo.bar` when clicking `bar`, but I obviously didn't do it. Test Plan: ctrl-click. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: joshuaspence, epriestley, gena2x, Korvin Maniphest Tasks: T8710 Differential Revision: https://secure.phabricator.com/D13550
2015-08-27 13:17:33 +02:00
'rsrc/js/application/repository/repository-crossreference.js' => 'e5339c43',
Allow profile menu items to be reordered Summary: Ref T10054. Allows users to drag menu items to reorder them. Test Plan: Reordered a project menu. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10054 Differential Revision: https://secure.phabricator.com/D15011
2016-01-13 18:40:27 +01:00
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
Clean up some log spam caused by races in VersionedDraft Summary: Two minor issues that I caught in the log while fixing Phame permissions: - We had a JS bug which would cause us to immediately generate two comment previews at the exact same time -- one for loading the page, and one for "switching to desktop". Instead, only generate the "switch to desktop" preview if we really switched to desktop from a different device layout. - These two requests could end up reading/writing the VersionedDraft table at exactly the same time fairly often (e.g., after a comment submission, the page would load, send two preview requests at exactly the same time, and they'd race fairly reliably for me locally). If we do race, recover from the race. Test Plan: Submitted some Phame comments. - No more error log errors about VersionedDraft keys. - Saw only one preview request when loading the page instead of two. Here's the specific stack trace I caught: ``` [Mon Sep 05 12:15:33.639930 2016] [:error] [pid 50608] [client 127.0.0.1:55278] [2016-09-05 14:15:33] EXCEPTION: (AphrontDuplicateKeyQueryException) #1062: Duplicate entry 'PHID-POST-fknnpzjnsdgc3rqobhst-PHID-USER-pr5rjpuilpfserepsd2k-13' for key 'key_object' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:314] [Mon Sep 05 12:15:33.640801 2016] [:error] [pid 50608] [client 127.0.0.1:55278] arcanist(head=master, ref.master=9e82ef979e81), corgi(head=master, ref.master=5b9171222bc9), instances(head=stable, ref.master=485bc8128198, ref.stable=2983bc917601), ledger(head=master, ref.master=4da4a24b8779), libcore(), phabricator(head=phame2, ref.master=4b6da9735ba7, ref.phame2=4b6da9735ba7), phutil(head=stable, ref.master=97f05269fdb1, ref.stable=c14343ee620e), services(head=stable, ref.master=1fcb5cdb7582, ref.stable=2d8088a5b4b3) [Mon Sep 05 12:15:33.640815 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #0 <#2> AphrontBaseMySQLDatabaseConnection::throwCommonException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:348] [Mon Sep 05 12:15:33.640830 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #1 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryCodeException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:289] [Mon Sep 05 12:15:33.640833 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #2 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryException(mysqli) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:185] [Mon Sep 05 12:15:33.640836 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #3 <#2> AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:8] [Mon Sep 05 12:15:33.640839 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #4 <#2> queryfx(AphrontMySQLiDatabaseConnection, string, string, string, array, string) [Mon Sep 05 12:15:33.640841 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #5 <#2> call_user_func_array(string, array) called at [<phutil>/src/aphront/storage/connection/AphrontDatabaseConnection.php:42] [Mon Sep 05 12:15:33.640844 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #6 <#2> AphrontDatabaseConnection::query(string, string, string, array, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1261] [Mon Sep 05 12:15:33.640846 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #7 <#2> LiskDAO::insertRecordIntoDatabase(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1106] [Mon Sep 05 12:15:33.640849 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #8 <#2> LiskDAO::insert() called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1075] [Mon Sep 05 12:15:33.640851 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #9 <#2> LiskDAO::save() called at [<phabricator>/src/applications/draft/storage/PhabricatorVersionedDraft.php:65] [Mon Sep 05 12:15:33.640854 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #10 <#2> PhabricatorVersionedDraft::loadOrCreateDraft(string, string, integer) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1669] [Mon Sep 05 12:15:33.640857 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #11 <#2> PhabricatorEditEngine::buildCommentResponse(PhamePost) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:894] [Mon Sep 05 12:15:33.640859 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #12 <#2> PhabricatorEditEngine::buildResponse() called at [<phabricator>/src/applications/phame/controller/post/PhamePostEditController.php:60] [Mon Sep 05 12:15:33.640862 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #13 <#2> PhamePostEditController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:237] [Mon Sep 05 12:15:33.640865 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #14 phlog(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/handler/PhabricatorAjaxRequestExceptionHandler.php:27] [Mon Sep 05 12:15:33.640868 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #15 PhabricatorAjaxRequestExceptionHandler::handleRequestException(AphrontRequest, AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:644] [Mon Sep 05 12:15:33.640870 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #16 AphrontApplicationConfiguration::handleException(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:242] [Mon Sep 05 12:15:33.640873 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #17 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:149] [Mon Sep 05 12:15:33.640879 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #18 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:17] ``` Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16494
2016-09-05 21:24:58 +02:00
'rsrc/js/application/transactions/behavior-comment-actions.js' => '0300eae6',
Allow EditEngine create and edit forms to be reordered Summary: Ref T9132. Ref T9908. Puts reordering UI in place: - For create forms, this just lets you pick a UI display order other than alphabetical. Seems nice to have. - For edit forms, this lets you create a hierarchy of advanced-to-basic forms and give them different visibility policies, if you want. Test Plan: {F1017842} - Verified that "Edit Thing" now takes me to the highest-ranked edit form. - Verified that create menu and quick create menu reflect application order. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132, T9908 Differential Revision: https://secure.phabricator.com/D14704
2015-12-08 15:14:47 +01:00
'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243',
Allow form configurations to retitle and reorder forms and add preambles Summary: Ref T9132. This just makes edited forms do //something//, albeit not anything very useful yet. You can now edit a form and: - Retitle it; - add a preamble (instructions on top of the form); and - reorder the form's fields. Test Plan: {F974632} {F974633} {F974634} {F974635} {F974636} Reviewers: chad Reviewed By: chad Subscribers: hach-que Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14503
2015-11-17 18:33:06 +01:00
'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96',
Make links to hidden comments work (Fixes T11117)
2016-07-08 15:08:51 +02:00
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '94c65b72',
Don't put a spacer line on the bottom of previews Summary: Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top. Test Plan: {F409078} Also looked at a couple other applications that use this and they looked correct. Reviewers: btrahan, lpriestley, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8182 Differential Revision: https://secure.phabricator.com/D12905
2015-05-18 21:18:10 +02:00
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => 'b23b49e6',
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/uiexample/ReactorButtonExample.js' => 'd19198c8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/uiexample/ReactorCheckboxExample.js' => '519705ea',
'rsrc/js/application/uiexample/ReactorFocusExample.js' => '40a6a403',
'rsrc/js/application/uiexample/ReactorInputExample.js' => '886fd850',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/application/uiexample/ReactorMouseoverExample.js' => '47c794d8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/application/uiexample/ReactorRadioExample.js' => '988040b4',
'rsrc/js/application/uiexample/ReactorSelectExample.js' => 'a155550f',
'rsrc/js/application/uiexample/ReactorSendClassExample.js' => '1def2711',
'rsrc/js/application/uiexample/ReactorSendPropertiesExample.js' => 'b1f0ccee',
'rsrc/js/application/uiexample/busy-example.js' => '60479091',
'rsrc/js/application/uiexample/gesture-example.js' => '558829c2',
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'rsrc/js/core/Busy.js' => '59a7976a',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'rsrc/js/core/DragAndDropFileUpload.js' => '58dea2fa',
Replace height buffer behavior while dragging on workboards with infinite column height Summary: Ref T4900. The root problem is that dragging stuff near the bottom of the board can cause jittery, jumpy behaviors. Internal scrolling has changed the nature of this problem. Previously, the height of the board itself would jump around, but it's now fixed so the height of columns jumps around instead. We could take the same approach and add a chunk to the bottom of each column when a drag starts, but this is really distracting visually since it's obvious to the user. Instead, treat columns as infinitely tall (so dragging beneath them still counts as dragging to the bottom position). Test Plan: - View a board with a column taller than the screen (has a scrollbar). - Drag a card to near the bottom position. - Move the mouse down a little bit at a time, continuing toward the bottom of the page. - Before patch: at some point, UI flips out and starts rapidly adding, scrolling, and removing the ghost. - After patch: sensible behavior, ghost is in bottom position for all cursor locations. Also works for dragging to the top. (This leaves us with a little less dead space for cancelling drags, but you've still got the left menu, anything offscreen, and the escape key, which seems fine.) Reviewers: chad Reviewed By: chad Maniphest Tasks: T4900 Differential Revision: https://secure.phabricator.com/D15227
2016-02-09 14:40:56 +01:00
'rsrc/js/core/DraggableList.js' => '5a13c79f',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'rsrc/js/core/Favicon.js' => '1fe2510c',
Support drag-and-drop to set cover images on workboard cards Summary: This was slightly more complex than I believed, but not too terrible. Test Plan: {F1096126} - Also used some normal file uploaders to make sure I didn't break that. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15202
2016-02-06 23:05:15 +01:00
'rsrc/js/core/FileUpload.js' => '680ea2c8',
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'rsrc/js/core/Hovercard.js' => '1bd28176',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
Fix "\" keyboard shortcut on German keyboard layouts Summary: Ref T10252. This is similar to D16259, but makes KeyboardShortcutManager more relaxed about `altKey` when typing obscure characters. Test Plan: Pressed Option + Shift + 7 on a German keyboard layout, saw Conphernece sidebar toggle. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16260
2016-07-08 17:30:30 +02:00
'rsrc/js/core/KeyboardShortcutManager.js' => '4a021c10',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'rsrc/js/core/Notification.js' => 'ccf1cbf8',
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'rsrc/js/core/Prefab.js' => 'cfd23f37',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'rsrc/js/core/TextAreaUtils.js' => '320810c8',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'rsrc/js/core/Title.js' => '485aaa6c',
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'rsrc/js/core/ToolTip.js' => '6323f942',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-active-nav.js' => 'e379b58e',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-audio-source.js' => '59b251eb',
'rsrc/js/core/behavior-autofocus.js' => '7319e029',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'rsrc/js/core/behavior-badge-view.js' => '8ff5e24c',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
'rsrc/js/core/behavior-choose-control.js' => '327a00d1',
Quicksand - fix project board page and quicksand Summary: Fixes T7913. Collapse the separate board dropdown into the board projects behavior; we always need that anyway and now we can install the listener more granularly. Test Plan: - visted project board - invoked create task, cancelled dialog - visited project feed - visited project board - invoked create task, cancelled dialog (FAILED pre patch...!) Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7913 Differential Revision: https://secure.phabricator.com/D12599
2015-04-28 23:51:49 +02:00
'rsrc/js/core/behavior-dark-console.js' => 'f411b6ae',
When the JS "Intl" API is available, use it to guess the timezone Summary: Ref T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in. Firefox also exposes "Intl" but this doesn't seem to be a reliable method to read the timezone. Test Plan: In Chrome, swapped my system date/time between zones, clicked the "reconcile" popup, got the dropdown prefilled accurately. In Safari (no `Intl` API) got the normal flow with no default selected. Reviewers: chad Reviewed By: chad Maniphest Tasks: T3025 Differential Revision: https://secure.phabricator.com/D15962
2016-05-22 15:50:12 +02:00
'rsrc/js/core/behavior-detect-timezone.js' => '4c193c96',
Move Tablet breakpoint from 768 -> 920 Summary: Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12" MacBook. Ref T10926 Test Plan: Durable Column, Workboards, Dashboards, Tasks. Reviewers: epriestley Reviewed By: epriestley Subscribers: avivey, Korvin Maniphest Tasks: T10926 Differential Revision: https://secure.phabricator.com/D15960
2016-05-21 21:08:47 +02:00
'rsrc/js/core/behavior-device.js' => 'bb1dd507',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '484a6e22',
Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063
2014-12-30 11:51:31 +01:00
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. Summary: Fixes T9295 Test Plan: Create event, open datepicker for start date, choose 1/31/2016, open datepicker again, click right button to scroll month. New suggested date should be 2/29/2016 Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9295 Differential Revision: https://secure.phabricator.com/D15727
2016-04-15 22:52:00 +02:00
'rsrc/js/core/behavior-fancy-datepicker.js' => '568931f3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-file-tree.js' => '88236f00',
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'rsrc/js/core/behavior-form.js' => '5c54cbf3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-gesture.js' => '3ab51e2c',
Allow users to drop .ics files on calendar views to import them Summary: Ref T10747. When a user drops a ".ics" file or a bunch of ".ics" files into a calendar view, import the events. (Possibly we should just do this if you drop ".ics" files into any application, but we can look at that later.) Test Plan: Dropped some .ics files into calendar views, got imports. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10747 Differential Revision: https://secure.phabricator.com/D16722
2016-10-18 23:24:17 +02:00
'rsrc/js/core/behavior-global-drag-and-drop.js' => '960f6a39',
Quicksand - make things work properly with high security mode Summary: Fixes T7064. We need to pass the quicksand magic request variable around and then instrument the javascript to handle quicksand page loads. Test Plan: Enabled two factor auth on my account and then - visited password page - filled out 2 factor auth request - saw high security bubble - clicked about still seeing high security bubble - refreshed page and still saw security bubble - dismissed bubble by following through workflow after clicking bubble Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7064 Differential Revision: https://secure.phabricator.com/D12536
2015-04-24 01:37:56 +02:00
'rsrc/js/core/behavior-high-security-warning.js' => 'a464fe03',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-history-install.js' => '7ee2b591',
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'rsrc/js/core/behavior-hovercard.js' => 'bcaccd64',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
Make "/" focus the search input again Summary: See D1902, T989, T11263, D15984, T4103 , D15976, https://secure.phabricator.com/w/changelog/2016.22/, T2527, T11231, T8286, T11264 for discussion! When we get another copy of T989, I will rename it to "Build a complicated keybinding settings page like a cool video game" and leave it open forever. Test Plan: Pressed "/" in Firefox, had my pristine browsing experience inexplicably hijacked by this horrible application. Reviewers: avivey, chad Reviewed By: avivey Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15984
2016-07-08 22:57:33 +02:00
'rsrc/js/core/behavior-keyboard-shortcuts.js' => '01fca1f0',
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'rsrc/js/core/behavior-lightbox-attachments.js' => 'f8ba29d7',
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'rsrc/js/core/behavior-line-linker.js' => '1499a8cb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-more.js' => 'a80d0378',
When using the "Close as Duplicate" relationship action, limit the UI to 1 task Summary: Ref T4788. When closing a task as a duplicate of another task, you can only select one task, since it doesn't really make sense to merge one task into several other tasks (this operation is //possible//, but probably not what anyone ever wants to do, I think?). Make the UI understand this: after you select a task, disable all of the "select" buttons in the UI to make this clear. Test Plan: - Used "Close as Duplicate", only allowed to select 1 task. - Used other editors like "Merge Duplicates In", allowed to select lots of tasks. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16203
2016-06-30 20:37:38 +02:00
'rsrc/js/core/behavior-object-selector.js' => 'e0ec7f2f',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'rsrc/js/core/behavior-oncopy.js' => '2926fff2',
Fix Differental Filetree browser hotkey Summary: Adds a class for explicitly hiding the sidenav. Test Plan: Set Config to Enable Filetree. View a diff, see tree. Press `f`, see it go away. Reload page, see persistence. Reviewers: avivey, epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16359
2016-08-01 22:54:39 +02:00
'rsrc/js/core/behavior-phabricator-nav.js' => '08675c6d',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => '116cf19b',
When Phabricator is in read-only mode, explain why Summary: Ref T4571. Allows users to click the "read-only mode" notification to get more information about why an install is in read-only mode. Installs can be in this mode for several reasons (explicit administrative action, no masters defined, no masters reachable), and it's useful to be able to tell the difference. Test Plan: {F1212930} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15671
2016-04-10 13:26:53 +02:00
'rsrc/js/core/behavior-read-only-warning.js' => 'ba158207',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'rsrc/js/core/behavior-refresh-csrf.js' => 'ab2f381b',
Support field previews in EditEngine Summary: Ref T10004. This primarily supports moving Phame to EditEngine. Test Plan: {F1045166} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14887
2015-12-26 22:00:01 +01:00
'rsrc/js/core/behavior-remarkup-preview.js' => '4b700e9e',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-reorder-applications.js' => '76b9fc3e',
'rsrc/js/core/behavior-reveal-content.js' => '60821bc7',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
Improve type and icon information in typeahead Summary: Ref T10289. This probably doesn't cover everything but should do a little bit better. Although we should mabye just exlude milestones from this menu completely? Test Plan: {F1093937} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10289 Differential Revision: https://secure.phabricator.com/D15191
2016-02-05 21:39:00 +01:00
'rsrc/js/core/behavior-search-typeahead.js' => '06c32383',
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'rsrc/js/core/behavior-select-content.js' => 'bf5374ef',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
Add client-side check for protocol mismatch Summary: Fixes T10402. I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable. Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about. Test Plan: Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T10402 Differential Revision: https://secure.phabricator.com/D16064
2016-06-07 00:01:18 +02:00
'rsrc/js/core/behavior-setup-check-https.js' => '491416b3',
Time controls should format end date value correctly (not 5:0 PM) Summary: Fixes T9296 Test Plan: Create an event, change start time to `3PM`, end value should update to `4:00 PM`, not `4:0 PM` Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9296 Differential Revision: https://secure.phabricator.com/D15725
2016-04-15 21:06:53 +02:00
'rsrc/js/core/behavior-time-typeahead.js' => '522431f7',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'rsrc/js/core/behavior-toggle-class.js' => '92b9ec77',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/behavior-tokenizer.js' => 'b3a4b884',
Don't mutate DOM by showing a tooltip on touch events Summary: This fix further addresses T10229. The problem and solution are the same: - If the DOM is mutated during a touch, it never registers as a 'click' so the tapped button does not activate. - This was partially addressed in D15136, which covered taps on code lines in a Differential view. - Tapping on some buttons, like "Reply" or "Hide Comment" still caused the problem by showing a tooltip. - There are probably similar buttons elsewhere, other than in Differential, exhibiting the same 'needs multiple taps to work' behaviour. - The testing in the iOS simulator performed for D15136 did not reveal that the problem with "Hide comment" and such remained because the small device size used for testing triggered the `!= 'desktop'` path for tooltips. To fix it: - Don't show tooltips for touch events. You can't 'hover' with a finger (with today's tech) so that UI paradigm doesn't apply. - Show the tooltips for regular mouse events, even if they are on the same device. Some devices have both touch and a mouse. - No longer try to rely on a distinction between 'desktop' and 'mobile' devices. Mobile devices like the iPad Pro are essentially desktop like, and as mentioned above, a single device could be both touch and mouse enabled. It's not about the nature of the device, it's about the nature of the interaction. Test Plan: - Tapped "Hide Comment", "Reply" on an iPad Pro running iOS 9.2 and got single touch responses with no tooltips. - Tried the same on an iPhone 6 running iOS 9.2. - Hovered over the same on a regular desktop in Safari and saw tooltips. Clicked and saw regular reactions. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15310
2016-02-19 14:06:14 +01:00
'rsrc/js/core/behavior-tooltip.js' => '42fcb747',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'rsrc/js/core/behavior-watch-anchor.js' => '9f36c42d',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'rsrc/js/core/behavior-workflow.js' => '0a3f3021',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'rsrc/js/core/phtize.js' => 'd254d646',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'rsrc/js/phui/behavior-phui-dropdown-menu.js' => '1aa4c968',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'rsrc/js/phui/behavior-phui-file-upload.js' => 'b003d4fb',
Improve profile menu animation Summary: The text sliding around feels a bit jank to me. Instead, here's an attempt at a three-part effect: - Fade out the content of the menu (first quarter of the animation). - Shrink the menu (half the animation). - Fade the menu content back in (final quarter). This isn't perfect, but feels less weird to me since the text doesn't dance? Test Plan: clickey clickey Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15098
2016-01-23 23:24:09 +01:00
'rsrc/js/phui/behavior-phui-profile-menu.js' => '12884df9',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'rsrc/js/phui/behavior-phui-submenu.js' => 'a6f7a73b',
Remove old ObjectBox tab cruft Summary: Ref T10628. Cleans up remaining weird, unused tab behaviors in ObjectBoxView to simplify ObjectBox. Test Plan: Toggled tabs in Files. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10628 Differential Revision: https://secure.phabricator.com/D16208
2016-07-01 01:55:28 +02:00
'rsrc/js/phui/behavior-phui-tab-group.js' => '0a0b10e9',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262',
Trigger autocomplete when "@" is typed on German keyboards Summary: Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character. We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts. Test Plan: - Switched keyboard layout to German. - Typed Alt + L to generate an "@". - Typed some username text. - Got autocompleter. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16259
2016-07-08 17:17:51 +02:00
'rsrc/js/phuix/PHUIXAutocomplete.js' => '6d86ce8b',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'rsrc/js/phuix/PHUIXDropdownMenu.js' => '82e270da',
Implement a rough optgroup-based "Move on Workboard" stacked action Summary: Ref T6027. Try this out and see how it feels? Clear issues: - This definitely shouldn't be at the top. - You should probably be able to select it multiple times? - Some of the "which columns show up" rules might need adjustment? - Diamond marker maybe not great? Not sure I love this but it doesn't feel //terrible//... Test Plan: {F1207891} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6027 Differential Revision: https://secure.phabricator.com/D15638
2016-04-06 14:59:09 +02:00
'rsrc/js/phuix/PHUIXFormControl.js' => 'e15869a8',
Basic stacked action support for EditEngine Summary: Ref T9132. This still has a lot of rough edges but the basics seem to work OK. Test Plan: {F1012627} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14653
2015-12-02 23:38:11 +01:00
'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'symbols' => array(
Allow Almanac service types to define default properties Summary: Ref T5833. This allows Almanac ServiceTypes to define default properties for a service, which show up in the UI and are more easily editable. Overall, this makes it much easier to make structured/usable/consistent service records: you can check a checkbox that says "prevent new allocations" instead of needing to know the meaning of a key. Test Plan: {F251593} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5833 Differential Revision: https://secure.phabricator.com/D10996
2014-12-17 20:10:50 +01:00
'almanac-css' => 'dbb9b3af',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'aphront-bars' => '231ac33c',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'aphront-dark-console-css' => 'f54bf286',
Rebuild Conpherence Summary: Minor rebuild / redesign of Conpherence. Most of this is new UX and tossing out things like widgets, device fallbacks. I expect some of the UI to get more polished after next pass, but most everything here is in place. - Removed "Widgets", now just a single Participants pane - Added "Topic" - New header - Settings, Edit are action icons - Removed a lot of JS - Simplified CSS as much as I could Test Plan: Desktop, Tablet, Mobile. Adding and removing people. Setting new topics, new rooms. {F1828662} {F1828669} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16550
2016-09-15 03:34:11 +02:00
'aphront-dialog-view-css' => '593d3f67',
Provide an AphrontController implementation of willSendResponse() Summary: This is required by Aphront now but not given a default implementation in the base class. Test Plan: CORGI sites now work. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14079
2015-09-08 02:18:35 +02:00
'aphront-list-filter-view-css' => '5d6f0526',
Convert Durable Column to popup chat in footer Summary: This feels pretty reasonable with little effort, and I think I'd use it more than the full column. Test Plan: Chat a lot on various pages.... still some quicksand quirks around various pages. {F1853487} Reviewers: epriestley Reviewed By: epriestley Subscribers: scp, Korvin Differential Revision: https://secure.phabricator.com/D16627
2016-09-29 07:27:19 +02:00
'aphront-multi-column-view-css' => '84cc6640',
Remove AphrontPanelView Summary: Removes AphrontPanelView, and most of it's CSS - it seems some old previews still call it. Test Plan: grep for AphrontPanelView, no callsites left. Verify CSS left is minimal needed. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7427 Differential Revision: https://secure.phabricator.com/D12004
2015-03-07 01:44:18 +01:00
'aphront-panel-view-css' => '8427b78d',
Truncate and scroll task graph tables instead of fitting task titles to the display Summary: Fixes T11676. Instead of trying to fit task titles to the display, truncate them and let the table scroll. Test Plan: Table now scrolls when cramped: {F1843396} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11676 Differential Revision: https://secure.phabricator.com/D16583
2016-09-21 23:41:52 +02:00
'aphront-table-view-css' => '3225137a',
Tweak grey tag color Summary: This is a bit too grey, and doesn't match our theme well (see sequence navs) Test Plan: Remarkup reference article, sequence navs Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14408
2015-11-04 22:51:51 +01:00
'aphront-tokenizer-control-css' => '056da01b',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'aphront-tooltip-css' => '1a07aea8',
'aphront-typeahead-control-css' => 'd4f16145',
Fix some minor UI issues with mobile application search Summary: Background is now always white, spacing in header is more consistent Test Plan: test mobile, table, desktop application search apps. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16691
2016-10-12 00:37:46 +02:00
'application-search-view-css' => '8452c849',
Touch up auth external account ui Summary: Fixes T8886 Test Plan: Check auth settings at different breakpoints. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8886 Differential Revision: https://secure.phabricator.com/D13650
2015-07-18 17:51:25 +02:00
'auth-css' => '0877ed6e',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'bulk-job-css' => 'df9c1d4a',
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'changeset-view-manager' => 'a2828756',
Show how to call Conduit API methods from clients Summary: Fixes T3628. Ref T5955. Test Plan: On the method page, you see a generic example: {F396471} After making a call, you see a specific example with your parameters: {F396472} {F396474} {F396475} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3628, T5955 Differential Revision: https://secure.phabricator.com/D12770
2015-05-08 21:19:52 +02:00
'conduit-api-css' => '7bc725c4',
Shuffle various parts of the config edit UI around Summary: Fixes T9339. - Don't show edit control for locked config at all. - Don't show a "Cancel" button either. - Change "Value" label to "Database Value" for non-custom config. - Highlight effective value. - Move examples under current state. - Tweak some formatting. Test Plan: {F777878} Reviewers: chad, avivey Reviewed By: chad, avivey Subscribers: avivey Maniphest Tasks: T9339 Differential Revision: https://secure.phabricator.com/D14054
2015-09-03 21:15:30 +02:00
'config-options-css' => '0ede4c9b',
Clean up mobile css on config page Summary: I seemed to have missed this, lots of funky desktop padding on mobile. Test Plan: Review Config / Maniphest / etc on a mobile browser. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16731
2016-10-20 00:01:41 +02:00
'config-page-css' => 'b80124ae',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'conpherence-durable-column-view' => 'd82e130c',
Fix super long topics in Conpherence header Summary: Add some ellipsis if the topic is absurdly long. Test Plan: desktop, mobile, tablet. MMMMMMMmmmMMMMMMmMMMmMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16718
2016-10-18 20:22:54 +02:00
'conpherence-header-pane-css' => '1c81cda6',
Hide extra rooms when you have too many in Conpherence Summary: This probably stopped working when we switch to a standard nav view. Re-scope CSS. Also make scrolling to last room a little easier. Test Plan: Make 20 rooms, see the old ones vanish. Click See More, scroll to bottom, click last room Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16656
2016-10-03 20:12:21 +02:00
'conpherence-menu-css' => '4f51db5a',
Hide footer on mobile Conpherence Summary: This has been causing scrolling issues for me for a while, turns out the footer behind the Conpherence layout can bubble up and cause scrolling issues if you don't hit the scrollarea in the right place with your finger. Hiding it via CSS or removing the footer in the configuration resolves the issue on my phone on secure. Test Plan: Test with and without footer on secure, hide footer in CSS since it's not visible anyways. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16732
2016-10-20 00:15:06 +02:00
'conpherence-message-pane-css' => '394ae8fa',
Clean up css race condition in Conpherence notification menu Summary: Depending on when packages loaded, this CSS sometimes gets overwritten. Make it more specific and always present. Test Plan: Reload a lot Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16657
2016-10-03 21:20:00 +02:00
'conpherence-notification-css' => '965db05b',
Allow tablet breakpoint in Conpherence to have persistent participant pane Summary: tablet viewpoints here are wide enough to support the participant column, go ahead and give it dedicated space. Test Plan: review tablet, desktop, and mobile breakpoints in conpherence with column toggled on and off Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16724
2016-10-19 06:13:53 +02:00
'conpherence-participant-pane-css' => 'ac1baaa8',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'conpherence-thread-manager' => '358c717b',
New UI for fulltext message search Summary: Basically all here, but still probably needs some polish (links to jump? full dates?). Looks much better, still duplicates messages though sometimes. Needs to debug that more. Test Plan: Revisit search UI inside Conpherence, outside Conpherence, and normal room searches in Conpherence. {F1870748} {F1870749} {F1870750} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16708
2016-10-15 15:58:46 +02:00
'conpherence-transaction-css' => '85129c68',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'd3' => 'a11a5ff2',
Fix mobile menu for files in Differential Changesets Summary: Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu. Test Plan: View on mobile, desktop, browser. Click an action, spawn new page. {F1717953} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T7754, T11305 Differential Revision: https://secure.phabricator.com/D16265
2016-07-09 22:53:57 +02:00
'differential-changeset-view-css' => '9ef7d354',
Convert Differential to new layout Summary: First pass at converting Differential, I likely have some buggy-poos but thought I'd toss this up now in case very bad bugs present. To do: - Need to put status back on Hovercards - "Diff Detail" probably needs a better design Test Plan: Looking at lots of diffs, admittedly I dont have harbormaster, etc, running locally. Checked Diffusion for Table of Content changes on small and large commits. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15463
2016-03-12 22:02:32 +01:00
'differential-core-view-css' => '5b7b8ff4',
Clean up browse/history links in Diffusion Summary: Fixes T9126. In particular: - Add "Browse" links to all history views. - Use icons to show "Browse" and "History" links, instead of text. - Use FontAwesome. - Generally standardize handling of these elements. This might need a little design attention, but I think it's an improvement overall. Test Plan: - Viewed repository history. - Viewed branch history. - Viewed file history. - Viewed table of contents on a commit. - Viewed merged changes on a merge commit. - Viewed a directory containing an external. - Viewed a deleted file. {F788419} {F788420} {F788421} {F788422} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9126 Differential Revision: https://secure.phabricator.com/D14096
2015-09-11 04:28:49 +02:00
'differential-inline-comment-editor' => '64a5550f',
Revamp inline commenting UI Summary: Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns: **To the author:** - The author of the diff should be able to easily identify what comments are done and not done. - We keep undone comments yellow - Clicking done turns comment block into 'unsubmitted state' **To the reviewer:** - Easier understanding of unsubmitted states - All conversations to be yellow/important **Todo** - Not all color CSS states correct - Unpulished checkbox support Test Plan: Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states. From the Diff Author's perspective: {F352094} For a Diff commenter's perspective: {F352095} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T1460, T7660, T7503 Differential Revision: https://secure.phabricator.com/D12171
2015-03-28 00:00:09 +01:00
'differential-revision-add-comment-css' => 'c47f8c40',
Highlight cell when jumping to an inline comment Summary: Fixes T8061. Test Plan: {F392321} Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8061 Differential Revision: https://secure.phabricator.com/D12705
2015-05-04 21:21:21 +02:00
'differential-revision-comment-css' => '14b8565a',
Fibrous vegeables.
2014-03-12 21:53:04 +01:00
'differential-revision-history-css' => '0e8eb855',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'differential-revision-list-css' => 'f3c47d33',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'differential-table-of-contents-css' => 'ae4b7a55',
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'diffusion-icons-css' => 'd678600a',
Couple of Diffusion tweaks Summary: - Fix spacing on InfoView inside collasped boxes - Fix spacing on stacked PropertyLists in TwoColumn - Fix spacing on Readmes on Tablets - Fix unset variable on importing commits Test Plan: Review each of the above cases. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15496
2016-03-18 20:01:15 +01:00
'diffusion-readme-css' => '297373eb',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'diffusion-source-css' => '68b30fd3',
Redesign Diviner Summary: This implements `PHUIDocumentViewPro` which should move to be the base for all documents (Phame, Phriction, Legalpad, Diviner). Overall this feels really good to me, but I'd like to roll it out into Diviner specifically first to work through the issues and then move into other apps and drop `PHUIDocumentView` once everything is converted. Some features are: - White Background, no border on page - Table of Contents is move to hidden menu (more space for documentation) - Property List sits under the document Some design decisions above are in anticipation of Phriction v3 and Unbeta Phame, specifically commenting and maybe some cool new Remarkup text layout options for Phame. Test Plan: Went through tons of pages on Diviner on Desktop, Tablet, Mobile. Bounce back to Phriction to make sure DocumentView CSS changes actually look better there. {F930518} {F930519} {F930520} {F930521} Reviewers: epriestley Reviewed By: epriestley Subscribers: tycho.tatitscheff, joshuaspence, Korvin Differential Revision: https://secure.phabricator.com/D14374
2015-11-01 17:56:46 +01:00
'diviner-shared-css' => 'aa3656aa',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'font-aleo' => '8bdb2835',
Update to FontAwesome 4.6.0 Summary: Updates to the latest icon packages Test Plan: View UIExamples, find new Icons Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15684
2016-04-11 20:29:12 +02:00
'font-fontawesome' => '2b7ebbcc',
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'font-lato' => 'c7ccd872',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'global-drag-and-drop-css' => '5c1b47c2',
Clean up spacing on empty logs in Harbormaster Summary: Better spacing in new layout. Test Plan: Tested changes against `secure` Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15524
2016-03-25 23:41:05 +01:00
'harbormaster-css' => 'f491c9f4',
Clean up Herald CSS Summary: I didn't test these very well and they looked silly when multiple rules applied. Test Plan: Test various cases more, with single and multiple triggers. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15419
2016-03-06 22:04:19 +01:00
'herald-css' => 'dc31f6e9',
Fix an initialization issue in Herald rules in Chrome Summary: Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values. Currently, the logic just sets everything to `null` or `'default'`. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.) Instead of relying on the browser to pick the right value, set the correct value explicitly. Test Plan: - Created a new rule in Chrome, Safari. - Added fields and conditions in Chrome, Safari. - Edited existing rules in Chrome, Safari. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10646 Differential Revision: https://secure.phabricator.com/D15507
2016-03-22 17:08:26 +01:00
'herald-rule-editor' => 'd6a7e717',
Modularize Herald "flag" action, plus update transcripts Summary: Ref T8726. This modularizes "Mark with flag", plus rebuilds transcripts in a more modern/flexible way. The big transcript stuff is: - Transcripts are now translatable. - Transcripts can now show multiple outputs from a single action. For example, an action like "add A, B, C to subscribers" can now say "added A; B is invalid; C was already subscribed". Test Plan: {F637784} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: joshuaspence, eadler, epriestley Maniphest Tasks: T8726 Differential Revision: https://secure.phabricator.com/D13649
2015-07-18 14:54:26 +02:00
'herald-test-css' => 'a52e323e',
[Redesign] Move basefont to Lato, remove Source Sans Pro Summary: Working towards a more unified look and feel. This brings in Lato as a complete base font over Helvetica Neue, as well as removing Source Sans Pro from DocumentView and Conpherence. Design-wise Lato provides the nice readability at larger font sizes that Source Sans Pro did, with the ability to scale down to tables and UI widgets with ease. This gives us one font instead of two, and now Object descriptions and Timeline posts all can benefit from a consistent, readable font. Test Plan: Test main UI, smaller elements like tables, menus, DocumentViews, Previews, Conpherence. {F498135} {F498136} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13276
2015-06-13 21:32:45 +02:00
'inline-comment-summary-css' => '51efda3a',
Conpherence - make sure real time updates still work if you switch threads Summary: Fixes T8118. Turns out this also was broken in the main view if e.g. you went to just /conpherence/. The fix is to make sure the threadmanager js class explicitly manages subscriptions as the loaded thread changes. Test Plan: - from /conpherence/ was able to receive messages in real time. - from /conpherence/ changed threads and still received messages in real time - from durable column switched threads and received messages in real time Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8118 Differential Revision: https://secure.phabricator.com/D12758
2015-05-07 21:47:49 +02:00
'javelin-aphlict' => '5359e785',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-behavior' => '61cbc29a',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'javelin-behavior-aphlict-dropdown' => '2a171a9d',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'javelin-behavior-aphlict-listen' => 'fb20ac8d',
Add an icon to aphlict connection status Summary: A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc). Test Plan: Test in Notifications menu, Conpherence full, Durable Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16647
2016-10-02 05:37:28 +02:00
'javelin-behavior-aphlict-status' => '5e2634b9',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-aphront-basic-tokenizer' => 'b3a4b884',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-behavior-aphront-drag-and-drop-textarea' => '484a6e22',
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'javelin-behavior-aphront-form-disable-on-submit' => '5c54cbf3',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-aphront-more' => 'a80d0378',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-audio-source' => '59b251eb',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-audit-preview' => 'd835b03a',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'javelin-behavior-badge-view' => '8ff5e24c',
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'javelin-behavior-bulk-job-reload' => 'edf8a145',
Give the Calendar month view a nice hover effect Summary: Ref T11326. Currently, we link Calendar days using hidden DOM nodes. This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers. Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise. Test Plan: {F1738941} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16334
2016-07-27 15:44:42 +02:00
'javelin-behavior-calendar-month-view' => 'fe33e256',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
'javelin-behavior-choose-control' => '327a00d1',
Clean up some log spam caused by races in VersionedDraft Summary: Two minor issues that I caught in the log while fixing Phame permissions: - We had a JS bug which would cause us to immediately generate two comment previews at the exact same time -- one for loading the page, and one for "switching to desktop". Instead, only generate the "switch to desktop" preview if we really switched to desktop from a different device layout. - These two requests could end up reading/writing the VersionedDraft table at exactly the same time fairly often (e.g., after a comment submission, the page would load, send two preview requests at exactly the same time, and they'd race fairly reliably for me locally). If we do race, recover from the race. Test Plan: Submitted some Phame comments. - No more error log errors about VersionedDraft keys. - Saw only one preview request when loading the page instead of two. Here's the specific stack trace I caught: ``` [Mon Sep 05 12:15:33.639930 2016] [:error] [pid 50608] [client 127.0.0.1:55278] [2016-09-05 14:15:33] EXCEPTION: (AphrontDuplicateKeyQueryException) #1062: Duplicate entry 'PHID-POST-fknnpzjnsdgc3rqobhst-PHID-USER-pr5rjpuilpfserepsd2k-13' for key 'key_object' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:314] [Mon Sep 05 12:15:33.640801 2016] [:error] [pid 50608] [client 127.0.0.1:55278] arcanist(head=master, ref.master=9e82ef979e81), corgi(head=master, ref.master=5b9171222bc9), instances(head=stable, ref.master=485bc8128198, ref.stable=2983bc917601), ledger(head=master, ref.master=4da4a24b8779), libcore(), phabricator(head=phame2, ref.master=4b6da9735ba7, ref.phame2=4b6da9735ba7), phutil(head=stable, ref.master=97f05269fdb1, ref.stable=c14343ee620e), services(head=stable, ref.master=1fcb5cdb7582, ref.stable=2d8088a5b4b3) [Mon Sep 05 12:15:33.640815 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #0 <#2> AphrontBaseMySQLDatabaseConnection::throwCommonException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:348] [Mon Sep 05 12:15:33.640830 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #1 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryCodeException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:289] [Mon Sep 05 12:15:33.640833 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #2 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryException(mysqli) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:185] [Mon Sep 05 12:15:33.640836 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #3 <#2> AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:8] [Mon Sep 05 12:15:33.640839 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #4 <#2> queryfx(AphrontMySQLiDatabaseConnection, string, string, string, array, string) [Mon Sep 05 12:15:33.640841 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #5 <#2> call_user_func_array(string, array) called at [<phutil>/src/aphront/storage/connection/AphrontDatabaseConnection.php:42] [Mon Sep 05 12:15:33.640844 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #6 <#2> AphrontDatabaseConnection::query(string, string, string, array, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1261] [Mon Sep 05 12:15:33.640846 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #7 <#2> LiskDAO::insertRecordIntoDatabase(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1106] [Mon Sep 05 12:15:33.640849 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #8 <#2> LiskDAO::insert() called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1075] [Mon Sep 05 12:15:33.640851 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #9 <#2> LiskDAO::save() called at [<phabricator>/src/applications/draft/storage/PhabricatorVersionedDraft.php:65] [Mon Sep 05 12:15:33.640854 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #10 <#2> PhabricatorVersionedDraft::loadOrCreateDraft(string, string, integer) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1669] [Mon Sep 05 12:15:33.640857 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #11 <#2> PhabricatorEditEngine::buildCommentResponse(PhamePost) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:894] [Mon Sep 05 12:15:33.640859 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #12 <#2> PhabricatorEditEngine::buildResponse() called at [<phabricator>/src/applications/phame/controller/post/PhamePostEditController.php:60] [Mon Sep 05 12:15:33.640862 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #13 <#2> PhamePostEditController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:237] [Mon Sep 05 12:15:33.640865 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #14 phlog(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/handler/PhabricatorAjaxRequestExceptionHandler.php:27] [Mon Sep 05 12:15:33.640868 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #15 PhabricatorAjaxRequestExceptionHandler::handleRequestException(AphrontRequest, AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:644] [Mon Sep 05 12:15:33.640870 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #16 AphrontApplicationConfiguration::handleException(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:242] [Mon Sep 05 12:15:33.640873 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #17 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:149] [Mon Sep 05 12:15:33.640879 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #18 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:17] ``` Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16494
2016-09-05 21:24:58 +02:00
'javelin-behavior-comment-actions' => '0300eae6',
Fix custom field selector control in cases where the user doesn't edit anything Summary: The JS and PHP representations of state can differ; just have the JS write the state out immediately on page load. Test Plan: Saved `diffusion.fields` without making changes, reloaded, saw no effective change. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12998
2015-05-25 14:34:23 +02:00
'javelin-behavior-config-reorder-fields' => 'b6993408',
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'javelin-behavior-conpherence-menu' => '7524fcfa',
Rebuild Conpherence Participants Pane Summary: Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user. Test Plan: Add to room, remove from room. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16560
2016-09-15 22:21:21 +02:00
'javelin-behavior-conpherence-participant-pane' => '8604caa8',
Make Conpherence Pontificate Send-on-Enter Summary: Fixes T11623. Enables send-on-enter and shift-enter for linebreaks, per durable column. Also cleaned up UI for Joining Room or Logging In. Test Plan: See room I can join, click Join Room. Leave Room, Log out, visit room with login prompt. Login, Join Room again. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11623 Differential Revision: https://secure.phabricator.com/D16595
2016-09-28 04:26:02 +02:00
'javelin-behavior-conpherence-pontificate' => 'f2e58483',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'javelin-behavior-conpherence-search' => '9bbf3762',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-behavior-countdown-timer' => 'e4cc26b3',
Quicksand - fix project board page and quicksand Summary: Fixes T7913. Collapse the separate board dropdown into the board projects behavior; we always need that anyway and now we can install the listener more granularly. Test Plan: - visted project board - invoked create task, cancelled dialog - visited project feed - visited project board - invoked create task, cancelled dialog (FAILED pre patch...!) Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7913 Differential Revision: https://secure.phabricator.com/D12599
2015-04-28 23:51:49 +02:00
'javelin-behavior-dark-console' => 'f411b6ae',
Dashboards - add remove functionality Summary: To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084. Test Plan: removed some panels to much success Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078, T5084 Differential Revision: https://secure.phabricator.com/D9156
2014-05-19 23:04:26 +02:00
'javelin-behavior-dashboard-async-panel' => '469c0d9e',
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'javelin-behavior-dashboard-move-panels' => '019f36c4',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
'javelin-behavior-dashboard-query-panel-select' => '453c5375',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-dashboard-tab-panel' => 'd4eecc63',
Make Calendar day view a little more consistent Summary: Ref T11326. This just cleans things up a little and removes some of the obvious layout/CSS issues. Test Plan: - Viewed day view before/after. Also viewed profile panel. Before: {F1725547} After: {F1725548} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16308
2016-07-15 23:02:24 +02:00
'javelin-behavior-day-view' => '4b3c4443',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'javelin-behavior-desktop-notifications-control' => 'edd1ba66',
When the JS "Intl" API is available, use it to guess the timezone Summary: Ref T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in. Firefox also exposes "Intl" but this doesn't seem to be a reliable method to read the timezone. Test Plan: In Chrome, swapped my system date/time between zones, clicked the "reconcile" popup, got the dropdown prefilled accurately. In Safari (no `Intl` API) got the normal flow with no default selected. Reviewers: chad Reviewed By: chad Maniphest Tasks: T3025 Differential Revision: https://secure.phabricator.com/D15962
2016-05-22 15:50:12 +02:00
'javelin-behavior-detect-timezone' => '4c193c96',
Move Tablet breakpoint from 768 -> 920 Summary: Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12" MacBook. Ref T10926 Test Plan: Durable Column, Workboards, Dashboards, Tasks. Reviewers: epriestley Reviewed By: epriestley Subscribers: avivey, Korvin Maniphest Tasks: T10926 Differential Revision: https://secure.phabricator.com/D15960
2016-05-21 21:08:47 +02:00
'javelin-behavior-device' => 'bb1dd507',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
'javelin-behavior-differential-comment-jump' => '4fdb476d',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'javelin-behavior-differential-dropdown-menus' => '9a6b9324',
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'javelin-behavior-differential-edit-inline-comments' => '4fbbc3e9',
Maniphest + Differential - don't show transaction preview until user interacts with the form. Summary: Fixes T4846. These are one off (for now) since they have various crazy actions with them. I think this will get unified and more cleaned up when we refine the UI for taking multiple actions at once, etc. Test Plan: noted no "commented on x" in either maniphest or differential. starting making a comment and noted prevew showed. started adding a subscriber (added to tokenizer) and preview showed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4846 Differential Revision: https://secure.phabricator.com/D12936
2015-05-20 22:54:22 +02:00
'javelin-behavior-differential-feedback-preview' => 'b064af76',
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'javelin-behavior-differential-populate' => '8694b1df',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-differential-toggle-files' => 'ca3f91eb',
'javelin-behavior-differential-user-select' => 'a8d8459d',
Add coverage tooltips in Diffusion file browse mode Summary: Fixes T10816. The way these work is a little unusual since these chunks of file-rendering code are unusuall performance-sensitive, so the Differential version doesn't adapt directly to Diffusion. Both can possibly be unified at some point in the future, although they do slightly different things. Test Plan: {F1220170} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10816 Differential Revision: https://secure.phabricator.com/D15719
2016-04-15 14:37:58 +02:00
'javelin-behavior-diffusion-browse-file' => '054a0f0b',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-diffusion-commit-branches' => 'bdaf4d04',
Improve "thread" rendering of unusually-shaped graphs Summary: Ref T4788. This fixes all the bugs I was immediately able to catch: - "Directory-Like" graph shapes could draw too many vertical lines. - "Reverse-Directory-Like" graph shapes could draw too few vertical lines. - Terminated, branched graph shapes drew the very last line to the wrong place. This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything. Test Plan: - Added failing tests and made them pass. {F1708158} {F1708159} {F1708160} {F1708161} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 18:22:00 +02:00
'javelin-behavior-diffusion-commit-graph' => '49ae8328',
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'javelin-behavior-diffusion-jump-to' => '73d09eef',
Git did not 3-way merge this quite correctly.
2014-05-13 23:09:00 +02:00
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
Make Diffusion "Last Modified" rendering less fragile Summary: Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax. The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ. In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one). In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes. Test Plan: Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of. Applied this patch, got a clean render. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9524 Differential Revision: https://secure.phabricator.com/D14243
2015-10-07 16:32:27 +02:00
'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-doorkeeper-tag' => 'e5822781',
Show a more reasonable status element for pull requests Summary: Ref T182. Replace the total mess we had before with a sort-of-reasonable element. This automatically updates using "javascript". Test Plan: {F901983} {F901984} Used "Land Revision", saw the land status go from "Waiting" -> "Working" -> "Landed" without having to mash reload over and over again. Reviewers: chad Reviewed By: chad Maniphest Tasks: T182 Differential Revision: https://secure.phabricator.com/D14314
2015-10-21 20:28:26 +02:00
'javelin-behavior-drydock-live-operation-status' => '901935ef',
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'javelin-behavior-durable-column' => 'aa3bd034',
Allow EditEngine create and edit forms to be reordered Summary: Ref T9132. Ref T9908. Puts reordering UI in place: - For create forms, this just lets you pick a UI display order other than alphabetical. Seems nice to have. - For edit forms, this lets you create a hierarchy of advanced-to-basic forms and give them different visibility policies, if you want. Test Plan: {F1017842} - Verified that "Edit Thing" now takes me to the highest-ranked edit form. - Verified that create menu and quick create menu reflect application order. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132, T9908 Differential Revision: https://secure.phabricator.com/D14704
2015-12-08 15:14:47 +01:00
'javelin-behavior-editengine-reorder-configs' => 'd7a74243',
Allow form configurations to retitle and reorder forms and add preambles Summary: Ref T9132. This just makes edited forms do //something//, albeit not anything very useful yet. You can now edit a form and: - Retitle it; - add a preamble (instructions on top of the form); and - reorder the form's fields. Test Plan: {F974632} {F974633} {F974634} {F974635} {F974636} Reviewers: chad Reviewed By: chad Subscribers: hach-que Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14503
2015-11-17 18:33:06 +01:00
'javelin-behavior-editengine-reorder-fields' => 'b59e1e96',
Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063
2014-12-30 11:51:31 +01:00
'javelin-behavior-error-log' => '6882e80a',
Make the "All Day Event" control use a checkbox instead of a dropdown Summary: This feels a little cleaner: - Clean up transaction log a bit. - Use a checkbox instead of a two-option dropdown. This is a little messy because the browser doesn't send anything if the user submits a form with an un-clicked checkbox. We now send a dummy value ("Hey, there's definitely a checkbox in this form!") so the server can figure out what to do. Test Plan: - Edited all-dayness of an event. - Viewed transaction log. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16776
2016-10-31 19:38:35 +01:00
'javelin-behavior-event-all-day' => 'b41537c9',
When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. Summary: Fixes T9295 Test Plan: Create event, open datepicker for start date, choose 1/31/2016, open datepicker again, click right button to scroll month. New suggested date should be 2/29/2016 Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9295 Differential Revision: https://secure.phabricator.com/D15727
2016-04-15 22:52:00 +02:00
'javelin-behavior-fancy-datepicker' => '568931f3',
Allow users to drop .ics files on calendar views to import them Summary: Ref T10747. When a user drops a ".ics" file or a bunch of ".ics" files into a calendar view, import the events. (Possibly we should just do this if you drop ".ics" files into any application, but we can look at that later.) Test Plan: Dropped some .ics files into calendar views, got imports. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10747 Differential Revision: https://secure.phabricator.com/D16722
2016-10-18 23:24:17 +02:00
'javelin-behavior-global-drag-and-drop' => '960f6a39',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-herald-rule-editor' => '7ebaeed3',
Quicksand - make things work properly with high security mode Summary: Fixes T7064. We need to pass the quicksand magic request variable around and then instrument the javascript to handle quicksand page loads. Test Plan: Enabled two factor auth on my account and then - visited password page - filled out 2 factor auth request - saw high security bubble - clicked about still seeing high security bubble - refreshed page and still saw security bubble - dismissed bubble by following through workflow after clicking bubble Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7064 Differential Revision: https://secure.phabricator.com/D12536
2015-04-24 01:37:56 +02:00
'javelin-behavior-high-security-warning' => 'a464fe03',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-history-install' => '7ee2b591',
Remove defunt project image choices Summary: These are old project image choices, remove and only go with FontAwesome related images. Test Plan: Project -> Edit Picture -> Save Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15051
2016-01-19 17:43:31 +01:00
'javelin-behavior-icon-composer' => '8499b6ab',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-behavior-launch-icon-composer' => '48086888',
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'javelin-behavior-line-chart' => 'e4232876',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-load-blame' => '42126667',
Support Spaces in Maniphest batch editor Summary: Ref T8498. This editor is an artifact of the Old World at this point, but it still works fine. Test Plan: Moved tasks between spaces using the batch editor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8498 Differential Revision: https://secure.phabricator.com/D13249
2015-06-11 19:24:39 +02:00
'javelin-behavior-maniphest-batch-editor' => '782ab6e7',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
[Redesign] Fix Maniphest subpriority editing Summary: Ref T8099, Fixes T8338. This allows re-ordering of Maniphest Tasks in the redesign. Somehow seems more fragile, but I couldn't break anything with it. Test Plan: Try ordering into first position after header, last position, changing priority outright, everything I can drag. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8338 Differential Revision: https://secure.phabricator.com/D13487
2015-06-30 18:37:12 +02:00
'javelin-behavior-maniphest-subpriority-editor' => '71237763',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-owners-path-editor' => '7a68dda3',
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'javelin-behavior-passphrase-credential-control' => '3cb0b2fc',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-persona-login' => '9414ff18',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-active-nav' => 'e379b58e',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-phabricator-autofocus' => '7319e029',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-busy-example' => '60479091',
'javelin-behavior-phabricator-file-tree' => '88236f00',
'javelin-behavior-phabricator-gesture' => '3ab51e2c',
'javelin-behavior-phabricator-gesture-example' => '558829c2',
'javelin-behavior-phabricator-keyboard-pager' => 'a8da01f0',
Make "/" focus the search input again Summary: See D1902, T989, T11263, D15984, T4103 , D15976, https://secure.phabricator.com/w/changelog/2016.22/, T2527, T11231, T8286, T11264 for discussion! When we get another copy of T989, I will rename it to "Build a complicated keybinding settings page like a cool video game" and leave it open forever. Test Plan: Pressed "/" in Firefox, had my pristine browsing experience inexplicably hijacked by this horrible application. Reviewers: avivey, chad Reviewed By: avivey Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15984
2016-07-08 22:57:33 +02:00
'javelin-behavior-phabricator-keyboard-shortcuts' => '01fca1f0',
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'javelin-behavior-phabricator-line-linker' => '1499a8cb',
Fix Differental Filetree browser hotkey Summary: Adds a class for explicitly hiding the sidenav. Test Plan: Set Config to Enable Filetree. View a diff, see tree. Press `f`, see it go away. Reload page, see persistence. Reviewers: avivey, epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16359
2016-08-01 22:54:39 +02:00
'javelin-behavior-phabricator-nav' => '08675c6d',
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'javelin-behavior-phabricator-notification-example' => '8ce821c5',
When using the "Close as Duplicate" relationship action, limit the UI to 1 task Summary: Ref T4788. When closing a task as a duplicate of another task, you can only select one task, since it doesn't really make sense to merge one task into several other tasks (this operation is //possible//, but probably not what anyone ever wants to do, I think?). Make the UI understand this: after you select a task, disable all of the "select" buttons in the UI to make this clear. Test Plan: - Used "Close as Duplicate", only allowed to select 1 task. - Used other editors like "Merge Duplicates In", allowed to select lots of tasks. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16203
2016-06-30 20:37:38 +02:00
'javelin-behavior-phabricator-object-selector' => 'e0ec7f2f',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'javelin-behavior-phabricator-oncopy' => '2926fff2',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-behavior-phabricator-remarkup-assist' => '116cf19b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-phabricator-reveal-content' => '60821bc7',
Improve type and icon information in typeahead Summary: Ref T10289. This probably doesn't cover everything but should do a little bit better. Although we should mabye just exlude milestones from this menu completely? Test Plan: {F1093937} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10289 Differential Revision: https://secure.phabricator.com/D15191
2016-02-05 21:39:00 +01:00
'javelin-behavior-phabricator-search-typeahead' => '06c32383',
Make links to hidden comments work (Fixes T11117)
2016-07-08 15:08:51 +02:00
'javelin-behavior-phabricator-show-older-transactions' => '94c65b72',
Don't mutate DOM by showing a tooltip on touch events Summary: This fix further addresses T10229. The problem and solution are the same: - If the DOM is mutated during a touch, it never registers as a 'click' so the tapped button does not activate. - This was partially addressed in D15136, which covered taps on code lines in a Differential view. - Tapping on some buttons, like "Reply" or "Hide Comment" still caused the problem by showing a tooltip. - There are probably similar buttons elsewhere, other than in Differential, exhibiting the same 'needs multiple taps to work' behaviour. - The testing in the iOS simulator performed for D15136 did not reveal that the problem with "Hide comment" and such remained because the small device size used for testing triggered the `!= 'desktop'` path for tooltips. To fix it: - Don't show tooltips for touch events. You can't 'hover' with a finger (with today's tech) so that UI paradigm doesn't apply. - Show the tooltips for regular mouse events, even if they are on the same device. Some devices have both touch and a mouse. - No longer try to rely on a distinction between 'desktop' and 'mobile' devices. Mobile devices like the iPad Pro are essentially desktop like, and as mentioned above, a single device could be both touch and mouse enabled. It's not about the nature of the device, it's about the nature of the interaction. Test Plan: - Tapped "Hide Comment", "Reply" on an iPad Pro running iOS 9.2 and got single touch responses with no tooltips. - Tried the same on an iPhone 6 running iOS 9.2. - Hovered over the same on a regular desktop in Safari and saw tooltips. Clicked and saw regular reactions. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15310
2016-02-19 14:06:14 +01:00
'javelin-behavior-phabricator-tooltips' => '42fcb747',
Don't put a spacer line on the bottom of previews Summary: Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top. Test Plan: {F409078} Also looked at a couple other applications that use this and they looked correct. Reviewers: btrahan, lpriestley, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8182 Differential Revision: https://secure.phabricator.com/D12905
2015-05-18 21:18:10 +02:00
'javelin-behavior-phabricator-transaction-comment-form' => 'b23b49e6',
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'javelin-behavior-phabricator-transaction-list' => '13c739ea',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-behavior-phabricator-watch-anchor' => '9f36c42d',
Allow Pholio mocks to be created and edited without drag-and-drop Summary: Ref T6523. Allows you to click stuff instead of using drag-and-drop. Test Plan: On iOS simulator, created and updated a mock. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6523 Differential Revision: https://secure.phabricator.com/D16088
2016-06-09 17:34:00 +02:00
'javelin-behavior-pholio-mock-edit' => 'bee502c8',
Quicksand and Pholio - make mock edit work Summary: Fixes T8036. In addition to making the mock edit work, this tightens quicksand code such that the correct page id is returned even if start() has not been called yet. It also tightens mock view where some functions should respect statics.enabled a bit more. Test Plan: clicked edit mock, mock crumb, edit mock, mock crum, edit mock, made edits and they worked! clicked edit mock, mock crumb, edit mock, mock crumb, edit mock, profile icon, hit browser back to edit mock, made edits and they worked! also observed mock view page not occasionally wigging out from image_onload race not having statics.enabled respect during the above Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8036 Differential Revision: https://secure.phabricator.com/D12739
2015-05-07 19:42:07 +02:00
'javelin-behavior-pholio-mock-view' => 'fbe497e7',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'javelin-behavior-phui-dropdown-menu' => '1aa4c968',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-behavior-phui-file-upload' => 'b003d4fb',
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'javelin-behavior-phui-hovercards' => 'bcaccd64',
Improve profile menu animation Summary: The text sliding around feels a bit jank to me. Instead, here's an attempt at a three-part effect: - Fade out the content of the menu (first quarter of the animation). - Shrink the menu (half the animation). - Fade the menu content back in (final quarter). This isn't perfect, but feels less weird to me since the text doesn't dance? Test Plan: clickey clickey Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15098
2016-01-23 23:24:09 +01:00
'javelin-behavior-phui-profile-menu' => '12884df9',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'javelin-behavior-phui-submenu' => 'a6f7a73b',
Remove old ObjectBox tab cruft Summary: Ref T10628. Cleans up remaining weird, unused tab behaviors in ObjectBoxView to simplify ObjectBox. Test Plan: Toggled tabs in Files. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10628 Differential Revision: https://secure.phabricator.com/D16208
2016-07-01 01:55:28 +02:00
'javelin-behavior-phui-tab-group' => '0a0b10e9',
Slightly better spacing, colors on ProjectCards Summary: Fixes transparent background images, removes "checkered". Better spacing for tags. Test Plan: Upload a transparent logo, hover over project. {F1093753} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15188
2016-02-05 19:30:20 +01:00
'javelin-behavior-policy-control' => 'd0c516d5',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-behavior-policy-rule-editor' => '5e9f347c',
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'javelin-behavior-project-boards' => '14a1faae',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-behavior-project-create' => '065227cc',
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'javelin-behavior-quicksand-blacklist' => '7927a7d3',
When Phabricator is in read-only mode, explain why Summary: Ref T4571. Allows users to click the "read-only mode" notification to get more information about why an install is in read-only mode. Installs can be in this mode for several reasons (explicit administrative action, no masters defined, no masters reachable), and it's useful to be able to tell the difference. Test Plan: {F1212930} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15671
2016-04-10 13:26:53 +02:00
'javelin-behavior-read-only-warning' => 'ba158207',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'javelin-behavior-refresh-csrf' => 'ab2f381b',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'javelin-behavior-releeph-request-state-change' => 'a0b57eb8',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-behavior-releeph-request-typeahead' => 'de2e896f',
Support field previews in EditEngine Summary: Ref T10004. This primarily supports moving Phame to EditEngine. Test Plan: {F1045166} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14887
2015-12-26 22:00:01 +01:00
'javelin-behavior-remarkup-preview' => '4b700e9e',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-reorder-applications' => '76b9fc3e',
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'javelin-behavior-reorder-columns' => 'e1d25dfb',
Allow profile menu items to be reordered Summary: Ref T10054. Allows users to drag menu items to reorder them. Test Plan: Reordered a project menu. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10054 Differential Revision: https://secure.phabricator.com/D15011
2016-01-13 18:40:27 +01:00
'javelin-behavior-reorder-profile-menu-items' => 'e2e0a072',
Symbol Search: Allow ctrl-click with no hover Summary: Fix T8710. I had hopes of doing something cleaver with `highlighted` (Like trying to understand `foo.bar` when clicking `bar`, but I obviously didn't do it. Test Plan: ctrl-click. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: joshuaspence, epriestley, gena2x, Korvin Maniphest Tasks: T8710 Differential Revision: https://secure.phabricator.com/D13550
2015-08-27 13:17:33 +02:00
'javelin-behavior-repository-crossreference' => 'e5339c43',
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'javelin-behavior-scrollbar' => '834a1173',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-search-reorder-queries' => 'e9581f08',
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'javelin-behavior-select-content' => 'bf5374ef',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'javelin-behavior-select-on-click' => '4e3e79a6',
Add client-side check for protocol mismatch Summary: Fixes T10402. I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable. Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about. Test Plan: Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T10402 Differential Revision: https://secure.phabricator.com/D16064
2016-06-07 00:01:18 +02:00
'javelin-behavior-setup-check-https' => '491416b3',
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'javelin-behavior-slowvote-embed' => '887ad43f',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
'javelin-behavior-test-payment-form' => 'fc91ab6c',
Time controls should format end date value correctly (not 5:0 PM) Summary: Fixes T9296 Test Plan: Create an event, change start time to `3PM`, end value should update to `4:00 PM`, not `4:0 PM` Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9296 Differential Revision: https://secure.phabricator.com/D15725
2016-04-15 21:06:53 +02:00
'javelin-behavior-time-typeahead' => '522431f7',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'javelin-behavior-toggle-class' => '92b9ec77',
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'javelin-behavior-toggle-widget' => '3dbf94d5',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-behavior-typeahead-browse' => '635de1ec',
'javelin-behavior-typeahead-search' => '93d0c9e3',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-behavior-view-placeholder' => '47830651',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'javelin-behavior-workflow' => '0a3f3021',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-color' => '7e41274a',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'javelin-cookie' => '62dfea03',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'javelin-diffusion-locate-file-source' => 'b42eddc7',
Fix an issue with "packages(...)" in typeaheads Summary: Fixes T9302. This datasource wasn't resolving package PHIDs correctly for the actual query. Also fixes an issue with the "Affected packages that need audit" Herald rule. Test Plan: Ran a "Needs Audit" query with only packages, and only `packages(user)`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9302 Differential Revision: https://secure.phabricator.com/D14029
2015-09-02 00:35:25 +02:00
'javelin-dom' => '805b806a',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-dynval' => 'f6555212',
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'javelin-event' => '2ee659ce',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'javelin-fx' => '54b612ba',
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'javelin-history' => 'd4505101',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-install' => '05270951',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-json' => '69adf288',
Probably improve behavior around duplicate notifications Summary: We're sometimes getting duplicate notifications right now. I think this is because multiple windows are racing and becoming leaders. Clean this up a little: - Fix the `timeoout` typo. - Only try to usurp once. - Use different usurp and expire delays, so we don't fire them at the exact same time. Not sure if this'll work or not but it should theoretically be a little cleaner. Test Plan: - Quit Safari, reopened Safari, still saw a fast reconnect to the notification server (this is the goal of usurping). - Did normal notification stuff like opening a chat in two windows, got notifications. - Hard to reproduce the race for sure, but this at least fixes the outright `timeoout` bug. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15806
2016-04-27 01:27:31 +02:00
'javelin-leader' => 'fea0eb47',
Scroll the chat column to the bottom when images load Summary: Fixes T7558. This might not be 100% perfect but should solve most of the issue. I briefly looked at things like `MutationObserver` (some fancy next-gen browser junk) but couldn't immediately get it working. Other methods for handling this kind of thing involve polling, complicated polyfills, etc. We could give `MutationObserver` a more serious effort if this is too leaky. Test Plan: - In a thread with some images, reloaded the page and saw the scrollbar stay at the bottom. - Tested with and without USB devices attached. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7558 Differential Revision: https://secure.phabricator.com/D12191
2015-03-28 16:35:12 +01:00
'javelin-magical-init' => '3010e992',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-mask' => '8a41885b',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'javelin-quicksand' => '6b8ef10b',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactor' => '2b8de964',
'javelin-reactor-dom' => 'c90a04fc',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-reactor-node-calmer' => '76f4ebed',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactornode' => '1ad0a787',
'javelin-request' => '94b750d2',
'javelin-resource' => '44959b73',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'javelin-routable' => 'b3e7d692',
'javelin-router' => '29274e2b',
Refine durable column class toggling Summary: don't bother with margin class if column isn't visible. Ref T8151. Test Plan: using chrome with trackpad - loaded home with toggled off column - noted no margin class erroneously applied - toggled column off and on - correct - loaded home with toggled on column - correct - toggled column off and on - correct Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8151 Differential Revision: https://secure.phabricator.com/D12795
2015-05-11 22:50:44 +02:00
'javelin-scrollbar' => '087e919c',
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'javelin-sound' => '949c0fe5',
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'javelin-stratcom' => '6ad39b6f',
Give custom controls passable disabled states Summary: Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing. Test Plan: {F1029090} - Tried to use controls, got reasonable behavior. - Used normal controls to make sure I didn't break anything. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9871, T10004 Differential Revision: https://secure.phabricator.com/D14814
2015-12-17 22:27:36 +01:00
'javelin-tokenizer' => '8d3bc1b2',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-typeahead' => '70baed2f',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-typeahead-composite-source' => '503e17fd',
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'javelin-typeahead-normalizer' => 'e6e25838',
Hide the autocompleter intelligently when you ignore it and keep typing Summary: Ref T10163. When we think the user has finished typing a word (because they typed a space, period, or other similar characters) and nothing else they might type could possibly change the outcome (usually because the words they have typed already match nothing), just deactivate the autocomplete. As a special case, if the word they have typed already select exactly one result, //and// they have already typed exactly that result, assume they just typed it from memory and deactivate. Test Plan: - Typed `@dog qwer zxcv` and saw autocomplete deactivate on the space before `z` (on my local install, `@dog` is ambiguous but `@dog qwer` matches nothing). - Typed `@epriestley ` and saw autocomplete deactivate on space. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10163 Differential Revision: https://secure.phabricator.com/D15039
2016-01-16 23:33:03 +01:00
'javelin-typeahead-ondemand-source' => '013ffff9',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
'javelin-typeahead-preloaded-source' => '54f314a0',
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'javelin-typeahead-source' => 'b25d5444',
Time control typeaheads. Summary: Ref T8031, Time control typeaheads Test Plan: Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Maniphest Tasks: T8031 Differential Revision: https://secure.phabricator.com/D12953
2015-05-20 18:51:26 +02:00
'javelin-typeahead-static-source' => '6c0e62fa',
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'javelin-uri' => 'c989ade3',
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'javelin-util' => '93cc50d6',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-vector' => '2caa8fb8',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-view' => '0f764c35',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-view-html' => 'fe287620',
'javelin-view-interpreter' => 'f829edb3',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'javelin-view-renderer' => '6c2b09a2',
'javelin-view-visitor' => 'efe49472',
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'javelin-websocket' => 'e292eaf4',
Survive receipt of too much workboard column position information Summary: Fixes T11468. I was able to find //a// reproduction case for the issue, at least, described in my comments there. When the server sends back position information for columns we aren't displaying, for whatever reason, just ignore that information. Future work in T4900 to do more synchronization may revisit this. Test Plan: See T11468#190177 for steps. Did that stuff with this patch, got a clean edit. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11468 Differential Revision: https://secure.phabricator.com/D16397
2016-08-14 17:58:17 +02:00
'javelin-workboard-board' => 'fe7cb52a',
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'javelin-workboard-card' => 'c587b80f',
When summing points on a workboard, display sum with same precision as most-precise value Summary: Fixes T11703. This mostly avoids rounding errors. If point values include "0.001", we also get three digits of precision: 1.000. Maybe useful if your point field is called "bitcoins" or something. Test Plan: Before: {F1851404} After: {F1851405} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11703 Differential Revision: https://secure.phabricator.com/D16601
2016-09-27 18:29:43 +02:00
'javelin-workboard-column' => '21df4ff5',
Fix an issue with creating tasks directly into milestone columns Summary: These columns were conflating `projectPHID` (the defualt project to add to the task) with `boardPHID` (the board the column appears on). Separate them to fix the beahvior. Test Plan: Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15242
2016-02-11 18:51:32 +01:00
'javelin-workboard-controller' => '55baf5ed',
Allow dialogs to opt in to being resizable Summary: Ref T11034. Ref T4788. This allows you to resize the typeahead browse dialog if you want. I plan to let you resize the object selector dialog in the future. Test Plan: {F1695433} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788, T11034 Differential Revision: https://secure.phabricator.com/D16156
2016-06-21 02:29:56 +02:00
'javelin-workflow' => '1e911d0f',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
'lightbox-attachment-css' => '7acac05d',
[Redesign] Put all ApplicationSearch results in an ObjectBox Summary: Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now. Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information. TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
'maniphest-batch-editor' => 'b0f0b6d5',
Fix backdrop color Summary: All our builtin images use #c4cde0 for the backdrop. This makes generation match the builtins. Test Plan: Build a new bug icon in Maniphest {F1077934} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15126
2016-01-28 05:56:36 +01:00
'maniphest-report-css' => '9b9580b7',
[Redesign] Larger Font PostProcessor Summary: Ref T8099, Ref T8614. Reasonable attempt at a larger font size PostProcessor, will need additional UI cleanup (places where we fix height) but overall very decent. Test Plan: Use lots of the UI elements with new font sizes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8614 Differential Revision: https://secure.phabricator.com/D13457
2015-06-26 18:33:03 +02:00
'maniphest-task-edit-css' => 'fda62a9b',
[Redesign] Put all ApplicationSearch results in an ObjectBox Summary: Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now. Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information. TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox Test Plan: Went throught most/all ApplicationSearch panels I could find, even edge cases look better. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12989
2015-05-24 18:13:58 +02:00
'maniphest-task-summary-css' => '11cc5344',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'multirow-row-manager' => 'b5d57730',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'owners-path-editor' => 'aa1733d0',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'owners-path-editor-css' => '2f00933b',
Solidify PHUITwoColumnView as a page layout Summary: Rolls out a new "Object Page" design with PHUITwoColumnView. This is reasonably polished, but wanted to post it up for you now for feedback before chasing down minor bugs. This implements TwoColumn in the following applications: - Ponder - Paste - Slowvote - Countdown - Projects - Profile - Passphrase This helped track down display issues and inconsistencies and make sure the layout was flexible for different pages. Test Plan: Test each of the applications on mobile, tablet, and desktop breakpoints. {F1135705} {F1135706} {F1135707} {F1135708} {F1135709} {F1135710} {F1135711} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15366
2016-02-26 23:34:51 +01:00
'paste-css' => '1898e534',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'path-typeahead' => 'f7fc67ec',
Fix backdrop color Summary: All our builtin images use #c4cde0 for the backdrop. This makes generation match the builtins. Test Plan: Build a new bug icon in Maniphest {F1077934} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15126
2016-01-28 05:56:36 +01:00
'people-profile-css' => '2473d929',
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
'phabricator-action-list-view-css' => 'c5eba19d',
Better icon alignment home nav Summary: These icons weren't actually centering. Widen the width and actually center the text. Test Plan: Review centering very carefully. Test home desktop / mobile Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13648
2015-07-20 22:48:35 +02:00
'phabricator-application-launch-view-css' => '95351601',
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'phabricator-busy' => '59a7976a',
[Redesign] Larger Font PostProcessor Summary: Ref T8099, Ref T8614. Reasonable attempt at a larger font size PostProcessor, will need additional UI cleanup (places where we fix height) but overall very decent. Test Plan: Use lots of the UI elements with new font sizes. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8614 Differential Revision: https://secure.phabricator.com/D13457
2015-06-26 18:33:03 +02:00
'phabricator-chatlog-css' => 'd295b020',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-content-source-view-css' => '4b8b05d4',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'phabricator-core-css' => 'd0801452',
Increase specificity in blue property boxes Summary: Feels a little hairy, but should be fine overall. Ups the css specificity enough that it's always displayed the same. The main problem is headers and boxes get put everywhere, and sometimes override each other. Fixes T10757 Test Plan: review a countdown in a phame post and phriction document. Check diviner, phriction for regressions. Reviewers: epriestley, #phacility Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10757 Differential Revision: https://secure.phabricator.com/D15664
2016-04-09 19:07:02 +02:00
'phabricator-countdown-css' => '16c52f5c',
Modernize Dashboard UI and code Summary: Pulls everything over to two column UI and new edit pages. Removed history view and consolidated some pages. Test Plan: New Panel, Edit Panel. New Dashboard, Edit Dashboard, View Standalone pages. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15588
2016-04-03 01:02:13 +02:00
'phabricator-dashboard-css' => 'bc6f2127',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
Replace height buffer behavior while dragging on workboards with infinite column height Summary: Ref T4900. The root problem is that dragging stuff near the bottom of the board can cause jittery, jumpy behaviors. Internal scrolling has changed the nature of this problem. Previously, the height of the board itself would jump around, but it's now fixed so the height of columns jumps around instead. We could take the same approach and add a chunk to the bottom of each column when a drag starts, but this is really distracting visually since it's obvious to the user. Instead, treat columns as infinitely tall (so dragging beneath them still counts as dragging to the bottom position). Test Plan: - View a board with a column taller than the screen (has a scrollbar). - Drag a card to near the bottom position. - Move the mouse down a little bit at a time, continuing toward the bottom of the page. - Before patch: at some point, UI flips out and starts rapidly adding, scrolling, and removing the ghost. - After patch: sensible behavior, ghost is in bottom position for all cursor locations. Also works for dragging to the top. (This leaves us with a little less dead space for cancelling drags, but you've still got the left menu, anything offscreen, and the escape key, which seems fine.) Reviewers: chad Reviewed By: chad Maniphest Tasks: T4900 Differential Revision: https://secure.phabricator.com/D15227
2016-02-09 14:40:56 +01:00
'phabricator-draggable-list' => '5a13c79f',
Add a friendlier "in flight" error page Summary: Ref T11589. When we hit a fatal setup issue (essentially always a connection failure) //after// we've already survived them on at least one request, we can be pretty sure a server went down and that the problem is not a setup/configuration issue. In this case, show a friendlier error page instead of the fairly detailed technical one. Test Plan: - Broke MySQL config. - Restarted Apache. - Got the "admin/setup" error page: {F1803268} - Fixed the MySQL config. - Loaded any page, to put us "in flight". - Broke MySQL config. - Loaded any page. - Got the friendly "in flight" error page: {F1803271} If you want to design this better, easiest way to get to it is: - Set `mysql.port` to `9999` in `conf/local/local.json`. - Reload any page while already running (don't restart). Reviewers: chad Reviewed By: chad Maniphest Tasks: T11589 Differential Revision: https://secure.phabricator.com/D16503
2016-09-06 22:48:22 +02:00
'phabricator-fatal-config-template-css' => '8f18fa41',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'phabricator-favicon' => '1fe2510c',
[Redesign] Update Feed Summary: Ref T8099, minor spacing improvements and more icons for feed. Test Plan: Test feed in Feed, in a Dashboard, Profile, and Project {F443366} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13045
2015-05-28 20:47:06 +02:00
'phabricator-feed-css' => 'ecd4ec57',
Support drag-and-drop to set cover images on workboard cards Summary: This was slightly more complex than I believed, but not too terrible. Test Plan: {F1096126} - Also used some normal file uploaders to make sure I didn't break that. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15202
2016-02-06 23:05:15 +01:00
'phabricator-file-upload' => '680ea2c8',
[Redesign] Update Filetree CSS Summary: Tweaks colors, updates icons Test Plan: Tested a filetree view, clicked and hovered. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9335
2014-05-30 01:04:50 +02:00
'phabricator-filetree-view-css' => 'fccf9f82',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'phabricator-flag-css' => '5337623f',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-keyboard-shortcut' => '1ae869f2',
Fix "\" keyboard shortcut on German keyboard layouts Summary: Ref T10252. This is similar to D16259, but makes KeyboardShortcutManager more relaxed about `altKey` when typing obscure characters. Test Plan: Pressed Option + Shift + 7 on a German keyboard layout, saw Conphernece sidebar toggle. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16260
2016-07-08 17:30:30 +02:00
'phabricator-keyboard-shortcut-manager' => '4a021c10',
Always show a menu on durable column Summary: If you don't have any rooms, we currently show no menu and users have no logical means of closing the column. This lets "Hide Column" at least still appear. Fixes T9195 Test Plan: Fresh install, hit {key \}, see menu. Close Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9195 Differential Revision: https://secure.phabricator.com/D16516
2016-09-07 23:23:07 +02:00
'phabricator-main-menu-view' => 'f03e17be',
Fix scrollbar in filetree sidenav Summary: Fixes T11457, I guess. It feels wierd when you drag it a bit, and Im not positive if it's the calc css or javascript. Test Plan: Enable filetree, shorten browser, see scrolling appear if files too long. Reviewers: avivey, epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11457 Differential Revision: https://secure.phabricator.com/D16393
2016-08-12 02:12:53 +02:00
'phabricator-nav-view-css' => 'b29426e9',
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'phabricator-notification' => 'ccf1cbf8',
Lay `cluster.databases` configuration groundwork for database clustering Summary: Ref T4571. This adds a new option which allows you to upgrade your one-host configuration to a multi-host configuration by configuring it. Doing this currently does nothing. I wrote a lot of words about what it is //supposed// to do in the future, though. Test Plan: - Tried to configure the option in all the possible bad ways, got errors. - Read documentation. Reviewers: chad Reviewed By: chad Subscribers: eadler Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15663
2016-04-09 14:41:08 +02:00
'phabricator-notification-css' => '3f6c89c9',
Add an icon to aphlict connection status Summary: A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc). Test Plan: Test in Notifications menu, Conpherence full, Durable Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16647
2016-10-02 05:37:28 +02:00
'phabricator-notification-menu-css' => '1e055865',
[Redesign] Update Object Selector UI Summary: Ref T8099, Better colors and spacing on the Object Selector. Test Plan: Hover and test new spacing. Reviewers: epriestley, btrahan Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13524
2015-07-02 23:39:43 +02:00
'phabricator-object-selector-css' => '85ee8ce6',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-phtize' => 'd254d646',
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'phabricator-prefab' => 'cfd23f37',
Add a {key ..} Remarkup rule for discussing keystrokes Summary: Ruleset for styles in D16506. Test Plan: {F1803883} Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16510
2016-09-07 17:19:14 +02:00
'phabricator-remarkup-css' => 'cd912f2c',
Revert "Allow search results to be snippeted, roughly" Summary: This reverts commit 15837388428d6dd3c37cf4b1d302e78657fce24e. See T8646 for discussion. This version of the feature feels terrible on real data. Test Plan: Strict revert. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14097
2015-09-11 05:57:26 +02:00
'phabricator-search-results-css' => '7dea472c',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
'phabricator-shaped-request' => '7cbe244b',
Solidify PHUITwoColumnView as a page layout Summary: Rolls out a new "Object Page" design with PHUITwoColumnView. This is reasonably polished, but wanted to post it up for you now for feedback before chasing down minor bugs. This implements TwoColumn in the following applications: - Ponder - Paste - Slowvote - Countdown - Projects - Profile - Passphrase This helped track down display issues and inconsistencies and make sure the layout was flexible for different pages. Test Plan: Test each of the applications on mobile, tablet, and desktop breakpoints. {F1135705} {F1135706} {F1135707} {F1135708} {F1135709} {F1135710} {F1135711} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15366
2016-02-26 23:34:51 +01:00
'phabricator-slowvote-css' => 'a94b7230',
Normalize Paste, Remarkup code embed colors Summary: These currently use different yellows, and more importantly when pygmentized, is hard to read. This lightens up code embeds and pastes. Test Plan: Review Diviner docs, Pastes, and normal code embeds. {F820471} Reviewers: epriestley Reviewed By: epriestley Subscribers: tycho.tatitscheff, Korvin Differential Revision: https://secure.phabricator.com/D14123
2015-09-17 17:23:22 +02:00
'phabricator-source-code-view-css' => 'cbeef983',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'phabricator-standard-page-view' => '79176f5a',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'phabricator-textareautils' => '320810c8',
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'phabricator-title' => '485aaa6c',
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'phabricator-tooltip' => '6323f942',
Clean up FontAwesome / Timeline CSS Summary: Normalize FA CSS, expand timeline icons to 14px, fix mobile browsers, give attribution in uiexamples Test Plan: tested iOS simulator, chrome, ie Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8845
2014-04-23 03:29:14 +02:00
'phabricator-ui-example-css' => '528b19de',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phabricator-uiexample-javelin-view' => 'd4a14807',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'phabricator-uiexample-reactor-button' => 'd19198c8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'phabricator-uiexample-reactor-checkbox' => '519705ea',
'phabricator-uiexample-reactor-focus' => '40a6a403',
'phabricator-uiexample-reactor-input' => '886fd850',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
'phabricator-uiexample-reactor-mouseover' => '47c794d8',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
'phabricator-uiexample-reactor-radio' => '988040b4',
'phabricator-uiexample-reactor-select' => 'a155550f',
'phabricator-uiexample-reactor-sendclass' => '1def2711',
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
Basic Conpherence Search in Thread Summary: Adds a search bar toggle and results for searching inside a Conpherence Room. The UI of the results itself are not styled yet, and will follow up with another diff. Test Plan: Go to Conpherence, search for "asdf", get lots of results. Search for nothing, get no change, search for something fictitious, get no threads found (will follow up with search result UI). Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16697
2016-10-13 20:09:54 +02:00
'phabricator-zindex-css' => 'd1270942',
Use CommentEditEngine in PhamePost Summary: Ref T9360. Moves PhamePost to CommentEditEngine. [x] HTTP Parameters dropdown on New Post goes to 404 [x] Implement EditEngine Comments Test Plan: Make Post, Make Comment, Laugh. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9360 Differential Revision: https://secure.phabricator.com/D16222
2016-07-06 21:24:36 +02:00
'phame-css' => '8efb0729',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'pholio-css' => 'ca89d380',
Allow Pholio mocks to be created and edited without drag-and-drop Summary: Ref T6523. Allows you to click stuff instead of using drag-and-drop. Test Plan: On iOS simulator, created and updated a mock. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6523 Differential Revision: https://secure.phabricator.com/D16088
2016-06-09 17:34:00 +02:00
'pholio-edit-css' => '07676f51',
Add spacing under Pholio Inline Comments Summary: Adds a bit of space Test Plan: View 2 or more inline comments on same transaction. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9712
2014-06-25 00:23:57 +02:00
'pholio-inline-comments-css' => '8e545e49',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phortune-credit-card-form' => '2290aeef',
Make it easier to add payment methods for subscription autopay Summary: Fixes T7424. Ref T6308. Currently, there's no option to just add a card directly from the autopay UI. Add a button so this works. Also, chip away at T6308 a bit. This isn't perfect but looks a little less out of place. Test Plan: {F327637} - Added a payment method, then set it as autopay. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6308, T7424 Differential Revision: https://secure.phabricator.com/D11935
2015-03-02 22:01:08 +01:00
'phortune-credit-card-form-css' => '8391eb02',
Add print styles for Phortune carts Summary: Fixes T10899, adds styles specifically for printing Phortune carts. Test Plan: Print a Phortune cart Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10899 Differential Revision: https://secure.phabricator.com/D16079
2016-06-08 05:55:18 +02:00
'phortune-css' => '5b99dae0',
Add a basic invoice view for printing to Phortune Summary: Makes a more complete PDF looking invoice form for printing in Phortune. Test Plan: Make an invoice, click print view, print. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16762
2016-10-30 02:45:10 +02:00
'phortune-invoice-css' => '476055e2',
New icons for play, pause, etc. Summary: New icons Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7893
2014-01-06 06:47:21 +01:00
'phrequent-css' => 'ffc185ad',
Fix Phriction document linking in mail bodies Summary: Fixes T10840. When rendering mail, this rule wasn't falling through in quite the right way. Also adjust where the rules are for this so the special styles show up in Maniphest, etc. Test Plan: Made this comment: {F1238266} Which produced this HTML: {F1238267} ...and sent this mail: {F1238283} Reviewers: hach-que, chad Reviewed By: chad Maniphest Tasks: T10840 Differential Revision: https://secure.phabricator.com/D15767
2016-04-20 15:00:10 +02:00
'phriction-document-css' => '4282e4ad',
Usability updates to ActionPanel Summary: Wraps entire element in the anchor tag, gives a hover state, makes icons bounce. Test Plan: Hover and click. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14124
2015-09-17 17:22:23 +02:00
'phui-action-panel-css' => '91c7b835',
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'phui-badge-view-css' => '3baef8db',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'phui-basic-nav-view-css' => '7093573b',
Add more NUX states Summary: Adds basic NUX to Dashboards, Herald, Repositories, Maniphest. Note Herald and Dashboard Panels don't fine the nux for some reason, assume they will when modernized? Test Plan: Read text, click buttons. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14844
2015-12-21 20:15:44 +01:00
'phui-big-info-view-css' => 'bd903741',
Increase specificity in blue property boxes Summary: Feels a little hairy, but should be fine overall. Ups the css specificity enough that it's always displayed the same. The main problem is headers and boxes get put everywhere, and sometimes override each other. Fixes T10757 Test Plan: review a countdown in a phame post and phriction document. Check diviner, phriction for regressions. Reviewers: epriestley, #phacility Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10757 Differential Revision: https://secure.phabricator.com/D15664
2016-04-09 19:07:02 +02:00
'phui-box-css' => '5c8387cf',
Clean up menu folding in action list Summary: Just removing the animation for now, can't find anything decent, I think that the issue is the animation is applying to all items in the list, and not just as a list as a single block. That is, I'd like to slide down all three at one. Any animation that slides them down when attached to each item makes them overlap at the first frame and it's a little distracting. Not a big deal to leave this out for now. Whatever we come up with should likely be applied to phuix-dropdown as well. Test Plan: Clicky Clicky. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16159
2016-06-21 21:54:35 +02:00
'phui-button-css' => '4a5fbe3d',
Redesign Application Search Summary: This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut. Test Plan: Config, Maniphest, Differential, Diffusion, Home. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16346
2016-08-01 21:06:35 +02:00
'phui-calendar-css' => '477acfaa',
Provide better headers and crumbs for Calendar result views Summary: Ref T11326. This isn't perfect, but should be a little easier to use and less weird/confusing. Generally, provide a "Query > Month > Day" crumb on day views, and a "Wed, July 3" header. Generally, provide a "Query > Month" crumb on month views, and a "July 2019" header. Also try to fix a bit of padding/spacing on the day view. Test Plan: {F1739128} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16338
2016-07-27 18:07:29 +02:00
'phui-calendar-day-css' => '572b1893',
'phui-calendar-list-css' => 'fcc9fb41',
Give Calendar days from adjacent months a background color hint Summary: Ref T11326. When viewing "February", add a class to dates in January and March to let them be styled a little differently as a UI hint. For now, I've given them a grey background. (Calendar.app changes the date number color instead.) Test Plan: {F1738990} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16336
2016-07-27 16:23:07 +02:00
'phui-calendar-month-css' => '8e10e92c',
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'phui-chart-css' => '6bf6f78e',
Rough in of NUX Guide steps Summary: Ref T11132. Will work on CSS tomorrow, but wanted to rough in the UI Steps to get guidance. Not sure what you have in mind for the "app" part, if you want to explain it and I build or you build. Test Plan: Visit each page and click on links. Very rough and unfinished. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11132 Differential Revision: https://secure.phabricator.com/D16419
2016-08-20 22:11:02 +02:00
'phui-cms-css' => 'be43c8a8',
Printable pages for PHUIDocumentViewPro Summary: Fixes T10131. Adds new CSS to better present document pages for printing. Added a print link to Phriction. Test Plan: Tested Phriction, Phame, and Legalpad. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10131 Differential Revision: https://secure.phabricator.com/D16524
2016-09-09 03:46:19 +02:00
'phui-crumbs-view-css' => '195ac419',
Add a few more high contrast CSS rules Summary: In new PHUITwoColumnLayout, some new colors were used that aren't in the High Contrast PostProcessor. Adding them and proper fallbacks. Test Plan: High Contrast on/off on a timeline page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16515
2016-09-07 20:02:54 +02:00
'phui-curtain-view-css' => '947bf1a4',
Add a Read More link to PHUIDocumentSummaryView Summary: Currently it's difficult to notice posts may be much longer than the summary (in most cases, actually), Adds a consistent "Read More" link to the full post. Also made sure "violet" was more consistantly used. Test Plan: Review summaries in Phame {F1031799} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14827
2015-12-19 21:28:18 +01:00
'phui-document-summary-view-css' => '9ca48bdf',
Remove PHUIDocumentView Summary: Converts final call site to PHUIDocumentViewPro. Test Plan: grep for PHUIDocumentView, view new Welcome Page Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16379
2016-08-08 05:04:57 +02:00
'phui-document-view-css' => 'c32e8dec',
Printable pages for PHUIDocumentViewPro Summary: Fixes T10131. Adds new CSS to better present document pages for printing. Added a print link to Phriction. Test Plan: Tested Phriction, Phame, and Legalpad. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10131 Differential Revision: https://secure.phabricator.com/D16524
2016-09-09 03:46:19 +02:00
'phui-document-view-pro-css' => 'ca1fed81',
Remove box-shadow from feed story actors Summary: We've been removing these, remove for consistency. Test Plan: profile image with transparency Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16687
2016-10-11 19:02:22 +02:00
'phui-feed-story-css' => '44a9c8e9',
Redesign Config Application Summary: Ref T11132, significantly cleans up the Config app, new layout, icons, spacing, etc. Some minor todos around re-designing "issues", mobile support, and maybe another pass at actual Group pages. Test Plan: Visit and test every page in the config app, set new items, resolve setup issues, etc. Reviewers: epriestley Reviewed By: epriestley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam, Korvin Maniphest Tasks: T11132 Differential Revision: https://secure.phabricator.com/D16468
2016-08-30 00:36:13 +02:00
'phui-font-icon-base-css' => '870a7360',
Update Phriction for PHUIDocumentViewPro Summary: Moves Phriction to use PHUIDocumentViewPro Test Plan: Read lots of documents, tablet, mobile, and desktop. Check ToC, non ToC, Edit a Maniphest Task, New Phriction Document, edit Phriction Document. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9826 Differential Revision: https://secure.phabricator.com/D14399
2015-11-22 22:10:41 +01:00
'phui-fontkit-css' => '9cda225e',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'phui-form-css' => 'aac1d51d',
Make Conpherence Pontificate Send-on-Enter Summary: Fixes T11623. Enables send-on-enter and shift-enter for linebreaks, per durable column. Also cleaned up UI for Joining Room or Logging In. Test Plan: See room I can join, click Join Room. Leave Room, Log out, visit room with login prompt. Login, Join Room again. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11623 Differential Revision: https://secure.phabricator.com/D16595
2016-09-28 04:26:02 +02:00
'phui-form-view-css' => '9e22b190',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'phui-head-thing-view-css' => 'fd311e5f',
Redesign Application Search Summary: This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut. Test Plan: Config, Maniphest, Differential, Diffusion, Home. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16346
2016-08-01 21:06:35 +02:00
'phui-header-view-css' => '06385974',
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'phui-hovercard' => '1bd28176',
Add ProjectCardView, use on Hovercards Summary: Builds a new ProjectCardView, starts basic Project Hovercard redesign (needs milestone, subproject support). Ref T10055 Test Plan: View all the colors. {F1092622} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10055 Differential Revision: https://secure.phabricator.com/D15186
2016-02-05 05:11:36 +01:00
'phui-hovercard-view-css' => 'de1a2119',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
'phui-icon-set-selector-css' => '1ab67aad',
Basic Conpherence Search in Thread Summary: Adds a search bar toggle and results for searching inside a Conpherence Room. The UI of the results itself are not styled yet, and will follow up with another diff. Test Plan: Go to Conpherence, search for "asdf", get lots of results. Search for nothing, get no change, search for something fictitious, get no threads found (will follow up with search result UI). Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16697
2016-10-13 20:09:54 +02:00
'phui-icon-view-css' => '417f80fb',
Move rgba rules into CelerityDefaultPostprocessor Summary: Should make it simpler here to have more `rgba` rules in CSS for things like hovers, selected states. Maybe only use `rgb` colors? Color pallette probably needs an overhaul. Test Plan: Bounce around random pages, buttons, menus. Everything appears normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15273
2016-02-15 06:29:56 +01:00
'phui-image-mask-css' => 'a8498f9c',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phui-info-panel-css' => '27ea50a1',
Update Diffusion UI Summary: This updates (all?) of Diffusion/Audit to new UI, included edit and other extra form pages. It's fairly complete but I don't know all the nooks and crannies so to speak to fully verify I didn't mess anything up. Test Plan: Tested creating new repositories, browsing, searching, auditing. Need more eyes. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15487
2016-03-17 20:01:22 +01:00
'phui-info-view-css' => '28efab79',
Partially improve threading UI for adjacent inline comments Summary: Ref T10563. This isn't a complete fix, but should make viewing complex inline threads a little more manageable. This just tries to put stuff in thread order instead of in pure chronological order. We can likely improve the display treatment -- this is a pretty minimal approach, but should improve clarity. Test Plan: T10563 has a "before" shot. Here's the "after": {F1169018} This makes it a bit easier to follow the conversations. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10563 Differential Revision: https://secure.phabricator.com/D15459
2016-03-11 01:33:44 +01:00
'phui-inline-comment-view-css' => '5953c28e',
Added initial class for displaying invisible chars Summary: Fixes T11586. First pass at a class for displaying invisible characters. Still need to: - Write a couple unit tests - Add some styling to the .invisible-special spans - Actually start using the class when displaying form errors to users Currently this makes the string `"\nab\x00c\x01d\te\nf"` look like: {F1812711} Test Plan: Unit tests all pass and run in <1ms: {F1812998} Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley, yelirekim Maniphest Tasks: T11586 Differential Revision: https://secure.phabricator.com/D16541
2016-09-12 14:53:54 +02:00
'phui-invisible-character-view-css' => '6993d9f0',
Straighten out reorder permissions on form configurations Summary: Fixes T10012. The permissions here are little weird: you need edit permission on the //configurations//, not the //engines//. I was checking edit permission on the engines only. I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789. Test Plan: - Tried to reorder forms as a less-privileged user, got proper policy errors. - Reordered forms normally as a regular user. Reviewers: chad Reviewed By: chad Subscribers: Luke081515.2 Maniphest Tasks: T10012 Differential Revision: https://secure.phabricator.com/D14824
2015-12-19 15:29:48 +01:00
'phui-list-view-css' => '9da2aa00',
Convert Differential to new layout Summary: First pass at converting Differential, I likely have some buggy-poos but thought I'd toss this up now in case very bad bugs present. To do: - Need to put status back on Hovercards - "Diff Detail" probably needs a better design Test Plan: Looking at lots of diffs, admittedly I dont have harbormaster, etc, running locally. Checked Diffusion for Table of Content changes on small and large commits. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15463
2016-03-12 22:02:32 +01:00
'phui-object-box-css' => '6b487c57',
Add some icons/color to Config Settings UI Summary: This adds status icons, locked, hidden, editable, customized, to the list of options in config. Makes it easier to read and assertain state. Test Plan: View a hidden, customized, editable, and locked. {F1796320} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16475
2016-08-30 21:53:09 +02:00
'phui-object-item-list-view-css' => '87278fa0',
[Redesign] PHUIPagerView Summary: Ref T8099, Moves AphrontPagerView to PHUIPagerView, converts to standard PHUIButtons and adds some additional features for icon placement on buttons. Test Plan: Tested Advanced Search and Searching files in Diffusion. Works as expected. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8342, T8099 Differential Revision: https://secure.phabricator.com/D13092
2015-06-02 23:34:04 +02:00
'phui-pager-css' => 'bea33d23',
[Redesign] Center Pinboard Items Summary: Ref T8099, This centers, but floats, all pinboards items based on screen width. Test Plan: Test desktop, mobile break points. Items scale nicely. {F459680} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13085
2015-05-31 23:28:16 +02:00
'phui-pinboard-view-css' => '2495140e',
Fix collapse background color on profile-menu Summary: This color needs to be fixed since we want the collapse icon over the menu. Test Plan: Shrink window so area has to scroll, see collapse above the rest of the menu. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16674
2016-10-05 23:36:12 +02:00
'phui-profile-menu-css' => '4768721a',
Break white-space on tags in any property list Summary: Fixes T11209. We want to always break tags when displaying them in a list, but not in general (remarkup). Test Plan: Fake a tag on a differental revision with a really long name. See wrapping. Reviewers: avivey, epriestley Reviewed By: avivey, epriestley Subscribers: avivey, Korvin Maniphest Tasks: T11209 Differential Revision: https://secure.phabricator.com/D16175
2016-06-24 21:10:20 +02:00
'phui-property-list-view-css' => '6d8e58ac',
Use new DocumentView for Legalpad previews Summary: Moves to showing Legalpad previews using PHUIDocumentViewPro Test Plan: Create a new document, edit an existing document Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14550
2015-11-23 18:17:36 +01:00
'phui-remarkup-preview-css' => '1a8f2591',
Minor CSS touches to workboard quest experience Summary: minor spacing updates, but i need to likely take a more details pass, specifically points look janky with project tags since they are not in the same `li`. Test Plan: Zoom into tags, see they all are same height and align. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15255
2016-02-12 02:04:14 +01:00
'phui-segment-bar-view-css' => '46342871',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'phui-spacing-css' => '042804d6',
New icons, colors for per reviewer status Summary: Fixes T10906, Fixes T10820. Adds new icons, grey-er colors for previous states. Also, I think fixed a few bugs? Test Plan: Fake each state, verify icon is as intended. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T10820, T10906 Differential Revision: https://secure.phabricator.com/D15830
2016-05-01 21:48:56 +02:00
'phui-status-list-view-css' => 'd5263e49',
Update Maniphest for PHUITwoColumnView Summary: Reworks Maniphest into a two column view. Moves priority and color to header, assignee to sidebar. quest points to header, and author to gutter. may be some confusion since priority only displays on open tickets. Test Plan: with and without description, custom fields, points, tablet, mobile and desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15396
2016-03-05 00:44:24 +01:00
'phui-tag-view-css' => '6bbd83e2',
Remove phui-theme sidebar colors Summary: Removes the special CSS to change the sidebar when the header is called. Also switched to using a more standard background color. I'd also like to make collapsed the default, but can't find best way to do that. Test Plan: Vist profile, projects, collapse and open nav, try a workboard color. Still all good. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16673
2016-10-05 22:19:07 +02:00
'phui-theme-css' => '798c69b8',
add renderValue() in transactions Summary: fix T11290. Test Plan: Paste language type, view in web and in emails (It uses quotes in HTML emails, which I think is something else). Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: chad, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T11290 Differential Revision: https://secure.phabricator.com/D16252
2016-07-09 01:01:42 +02:00
'phui-timeline-view-css' => 'bc523970',
Clean up mobile css on config page Summary: I seemed to have missed this, lots of funky desktop padding on mobile. Test Plan: Review Config / Maniphest / etc on a mobile browser. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16731
2016-10-20 00:01:41 +02:00
'phui-two-column-view-css' => 'bbe32c23',
Revert "Clean up more Quicksand" Summary: This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b. Test Plan: Reload homepage, no scrollbars Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16645
2016-10-01 21:35:13 +02:00
'phui-workboard-color-css' => 'ac6fe6a7',
'phui-workboard-view-css' => 'e09eb53a',
Clean up "points" display on workboards Summary: Couple of edge cases here I never cleaned up. This inlines points and projects better, with spacing and use of grey to better differentate from project tag colors. Test Plan: Review edge cases on workboard with multiple short and long project names. {F1653998} {F1653999} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15956
2016-05-20 22:03:26 +02:00
'phui-workcard-view-css' => '0c62d7c5',
Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds Summary: Cleans up the backgrounds a little on Projects/Profiles and adds a number of colour choices for Workboards. Test Plan: Manually add each color for testing. Test new project / profile layouts with and without properties. {F1109325} {F1109326} {F1109327} {F1109328} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15269
2016-02-13 20:55:14 +01:00
'phui-workpanel-view-css' => '92197373',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
'phuix-action-list-view' => 'b5c256b8',
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'phuix-action-view' => '8cf6d262',
Trigger autocomplete when "@" is typed on German keyboards Summary: Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character. We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts. Test Plan: - Switched keyboard layout to German. - Typed Alt + L to generate an "@". - Typed some username text. - Got autocompleter. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16259
2016-07-08 17:17:51 +02:00
'phuix-autocomplete' => '6d86ce8b',
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'phuix-dropdown-menu' => '82e270da',
Implement a rough optgroup-based "Move on Workboard" stacked action Summary: Ref T6027. Try this out and see how it feels? Clear issues: - This definitely shouldn't be at the top. - You should probably be able to select it multiple times? - Some of the "which columns show up" rules might need adjustment? - Diamond marker maybe not great? Not sure I love this but it doesn't feel //terrible//... Test Plan: {F1207891} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6027 Differential Revision: https://secure.phabricator.com/D15638
2016-04-06 14:59:09 +02:00
'phuix-form-control-view' => 'e15869a8',
Basic stacked action support for EditEngine Summary: Ref T9132. This still has a lot of rough edges but the basics seem to work OK. Test Plan: {F1012627} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14653
2015-12-02 23:38:11 +01:00
'phuix-icon-view' => 'bff6884b',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'policy-css' => '957ea14c',
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'policy-edit-css' => '815c66f7',
Notifications - add a "Clear All Notifications" link to dropdown Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links? Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2576 Differential Revision: https://secure.phabricator.com/D8894
2014-04-29 19:43:38 +02:00
'policy-transaction-detail-css' => '82100a43',
Minor Ponder spacing updates Summary: Fix an issue where you've already answered, moved the summary section. Test Plan: Review an answer with a wiki that i've already answered Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15395
2016-03-04 00:18:41 +01:00
'ponder-view-css' => 'fbd45f96',
New People Hovercards Summary: Mimics the Project Hovercards, more custom UI. Test Plan: Hover over person with and without badges, hover over project. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15253
2016-02-11 23:55:44 +01:00
'project-card-view-css' => '9418c97d',
Fix properties box layout for profiles/projects on mobile Summary: The spacing here is incorrect and no longer needed. Test Plan: Test phone layout of project, profile. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16511
2016-09-07 18:52:32 +02:00
'project-view-css' => '55d99221',
Use standard UI elements to render pull requests in Releeph Summary: Ref T3718. Ref T3644. Ref T3092. Switches from the Releeph UI elements to standard ones. I'll attach some screenshots. Also fixes CSRF against the request action endpoint. Test Plan: - Viewed request details. - Took actions on a request from detail page. - Viewed request list. - Took actions on a request from list page. - Used keyboard shortcuts to navigate list. - Used keyboard shortcuts to take actions. - Simulated errors. - Viewed on devices. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: grp, FacebookPOC, mattlqx, tala, beng, LegNeato, epriestley Maniphest Tasks: T3718, T3092, T3644 Differential Revision: https://secure.phabricator.com/D8771
2014-04-18 15:44:45 +02:00
'releeph-core' => '9b3c5733',
Remove ReleephProjectController Summary: Ref T3657. General changes here: - Removes `ReleephProjectController`, which is the source of T3657. - Mostly moves requests from "RQ" as a monogram to "Y" (looks like a merge, mnemonic for "yank"?, we don't have too many characters left). This should be essentially only cosmetic. This reduces ambiguity with "rQ" and "R123", which are current and future repository monograms. This will continue in the next few diffs. - Makes requests implement policies correctly. Test Plan: Created, edited, browsed requests. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3657 Differential Revision: https://secure.phabricator.com/D8766
2014-04-14 21:06:56 +02:00
'releeph-preview-branch' => 'b7a6f4a5',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
'releeph-request-differential-create-dialog' => '8d8b92cd',
'releeph-request-typeahead-css' => '667a48ae',
Wrap long text in setup issues Summary: Really long text strings break this ui when first setting up Phabricator. Test Plan: MySQL sql_mode setup issue. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16455
2016-08-26 06:34:24 +02:00
'setup-issue-css' => 'f794cfc3',
Add Slack authentication adapter Summary: For phabricator. Adds a Slack auth adapater and icon. Test Plan: Create a new Slack Application for login, generate id and secret. Activate login and registration for Slack. Create a new account with Slack credentials. Log out. Log in with Slack credentials. Set my avatar with Slack. Slack. Slack. {F1802649} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16496
2016-09-06 17:50:37 +02:00
'sprite-login-css' => '6dbbbd97',
More tokens Summary: Ref T11244. 8 more tokens. Probably need better math on the selector? Test Plan: Award Dat Boi. Reviewers: epriestley Reviewed By: epriestley Subscribers: putnam, Korvin Maniphest Tasks: T11244 Differential Revision: https://secure.phabricator.com/D16228
2016-07-04 03:32:31 +02:00
'sprite-tokens-css' => '9cdfd599',
Generate syntax highlighting CSS from a reusable map Summary: Ref T9790. This prepares the syntax color rules to be reused in mail. This goes about halfway toward T5701 by sort-of supporting different styles but not really. Test Plan: - Ran `bin/celerity syntax` to regenerate syntax map. - Viewed some highlighted code, didn't see any differences. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9790 Differential Revision: https://secure.phabricator.com/D15846
2016-05-05 03:24:59 +02:00
'syntax-default-css' => '9923583c',
Wrap really long text properly in diffs Summary: Fixes T11236, breaks long words and inlines the spans. Test Plan: Use a diff with super long text like SSH keys, set Font to 24/48 Impact {F1705910} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11236 Differential Revision: https://secure.phabricator.com/D16198
2016-06-30 05:27:11 +02:00
'syntax-highlighting-css' => '769d3498',
Make tokens more accessible to assitive technologies Summary: Ref T4843. - The token award buttons are just icons. - The tokens themselves are just icons. - Also spread the tokens out a tiny bit, they feel a little tight to me right now. Test Plan: Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4843 Differential Revision: https://secure.phabricator.com/D8982
2014-05-05 19:54:34 +02:00
'tokens-css' => '3d0f239e',
Render browse results with global result style Summary: Ref T11034. This seems a little more promising. Two problems at the moment: - This doesn't actually provide any useful information at all right now. - Many object types have no profile images. Test Plan: {F1695254} {F1695255} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11034 Differential Revision: https://secure.phabricator.com/D16155
2016-06-20 22:52:18 +02:00
'typeahead-browse-css' => '8904346a',
[Redesign] Remove gradient headers Summary: Ref T8099, this removes the gradient headers and their edge cases in Pinboard View, Setup Issues, Exceptions, and Document Heiriarchy. Test Plan: Tested each of these, grep for "gradient" and verify all states are gone. {F410708} {F410709} {F410710} {F410714} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12944
2015-05-20 04:38:34 +02:00
'unhandled-exception-css' => '4c96257a',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'requires' => array(
Hide the autocompleter intelligently when you ignore it and keep typing Summary: Ref T10163. When we think the user has finished typing a word (because they typed a space, period, or other similar characters) and nothing else they might type could possibly change the outcome (usually because the words they have typed already match nothing), just deactivate the autocomplete. As a special case, if the word they have typed already select exactly one result, //and// they have already typed exactly that result, assume they just typed it from memory and deactivate. Test Plan: - Typed `@dog qwer zxcv` and saw autocomplete deactivate on the space before `z` (on my local install, `@dog` is ambiguous but `@dog qwer` matches nothing). - Typed `@epriestley ` and saw autocomplete deactivate on space. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10163 Differential Revision: https://secure.phabricator.com/D15039
2016-01-16 23:33:03 +01:00
'013ffff9' => array(
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-typeahead-source',
),
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'019f36c4' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
),
Make "/" focus the search input again Summary: See D1902, T989, T11263, D15984, T4103 , D15976, https://secure.phabricator.com/w/changelog/2016.22/, T2527, T11231, T8286, T11264 for discussion! When we get another copy of T989, I will rename it to "Build a complicated keybinding settings page like a cool video game" and leave it open forever. Test Plan: Pressed "/" in Firefox, had my pristine browsing experience inexplicably hijacked by this horrible application. Reviewers: avivey, chad Reviewed By: avivey Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15984
2016-07-08 22:57:33 +02:00
'01fca1f0' => array(
'javelin-behavior',
'javelin-workflow',
'javelin-json',
'javelin-dom',
'phabricator-keyboard-shortcut',
),
Clean up some log spam caused by races in VersionedDraft Summary: Two minor issues that I caught in the log while fixing Phame permissions: - We had a JS bug which would cause us to immediately generate two comment previews at the exact same time -- one for loading the page, and one for "switching to desktop". Instead, only generate the "switch to desktop" preview if we really switched to desktop from a different device layout. - These two requests could end up reading/writing the VersionedDraft table at exactly the same time fairly often (e.g., after a comment submission, the page would load, send two preview requests at exactly the same time, and they'd race fairly reliably for me locally). If we do race, recover from the race. Test Plan: Submitted some Phame comments. - No more error log errors about VersionedDraft keys. - Saw only one preview request when loading the page instead of two. Here's the specific stack trace I caught: ``` [Mon Sep 05 12:15:33.639930 2016] [:error] [pid 50608] [client 127.0.0.1:55278] [2016-09-05 14:15:33] EXCEPTION: (AphrontDuplicateKeyQueryException) #1062: Duplicate entry 'PHID-POST-fknnpzjnsdgc3rqobhst-PHID-USER-pr5rjpuilpfserepsd2k-13' for key 'key_object' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:314] [Mon Sep 05 12:15:33.640801 2016] [:error] [pid 50608] [client 127.0.0.1:55278] arcanist(head=master, ref.master=9e82ef979e81), corgi(head=master, ref.master=5b9171222bc9), instances(head=stable, ref.master=485bc8128198, ref.stable=2983bc917601), ledger(head=master, ref.master=4da4a24b8779), libcore(), phabricator(head=phame2, ref.master=4b6da9735ba7, ref.phame2=4b6da9735ba7), phutil(head=stable, ref.master=97f05269fdb1, ref.stable=c14343ee620e), services(head=stable, ref.master=1fcb5cdb7582, ref.stable=2d8088a5b4b3) [Mon Sep 05 12:15:33.640815 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #0 <#2> AphrontBaseMySQLDatabaseConnection::throwCommonException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:348] [Mon Sep 05 12:15:33.640830 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #1 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryCodeException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:289] [Mon Sep 05 12:15:33.640833 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #2 <#2> AphrontBaseMySQLDatabaseConnection::throwQueryException(mysqli) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:185] [Mon Sep 05 12:15:33.640836 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #3 <#2> AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:8] [Mon Sep 05 12:15:33.640839 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #4 <#2> queryfx(AphrontMySQLiDatabaseConnection, string, string, string, array, string) [Mon Sep 05 12:15:33.640841 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #5 <#2> call_user_func_array(string, array) called at [<phutil>/src/aphront/storage/connection/AphrontDatabaseConnection.php:42] [Mon Sep 05 12:15:33.640844 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #6 <#2> AphrontDatabaseConnection::query(string, string, string, array, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1261] [Mon Sep 05 12:15:33.640846 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #7 <#2> LiskDAO::insertRecordIntoDatabase(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1106] [Mon Sep 05 12:15:33.640849 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #8 <#2> LiskDAO::insert() called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1075] [Mon Sep 05 12:15:33.640851 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #9 <#2> LiskDAO::save() called at [<phabricator>/src/applications/draft/storage/PhabricatorVersionedDraft.php:65] [Mon Sep 05 12:15:33.640854 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #10 <#2> PhabricatorVersionedDraft::loadOrCreateDraft(string, string, integer) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1669] [Mon Sep 05 12:15:33.640857 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #11 <#2> PhabricatorEditEngine::buildCommentResponse(PhamePost) called at [<phabricator>/src/applications/transactions/editengine/PhabricatorEditEngine.php:894] [Mon Sep 05 12:15:33.640859 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #12 <#2> PhabricatorEditEngine::buildResponse() called at [<phabricator>/src/applications/phame/controller/post/PhamePostEditController.php:60] [Mon Sep 05 12:15:33.640862 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #13 <#2> PhamePostEditController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:237] [Mon Sep 05 12:15:33.640865 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #14 phlog(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/handler/PhabricatorAjaxRequestExceptionHandler.php:27] [Mon Sep 05 12:15:33.640868 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #15 PhabricatorAjaxRequestExceptionHandler::handleRequestException(AphrontRequest, AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:644] [Mon Sep 05 12:15:33.640870 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #16 AphrontApplicationConfiguration::handleException(AphrontDuplicateKeyQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:242] [Mon Sep 05 12:15:33.640873 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #17 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:149] [Mon Sep 05 12:15:33.640879 2016] [:error] [pid 50608] [client 127.0.0.1:55278] #18 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:17] ``` Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16494
2016-09-05 21:24:58 +02:00
'0300eae6' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phuix-form-control-view',
'phuix-icon-view',
'javelin-behavior-phabricator-gesture',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'05270951' => array(
'javelin-util',
'javelin-magical-init',
),
Add coverage tooltips in Diffusion file browse mode Summary: Fixes T10816. The way these work is a little unusual since these chunks of file-rendering code are unusuall performance-sensitive, so the Differential version doesn't adapt directly to Diffusion. Both can possibly be unified at some point in the future, although they do slightly different things. Test Plan: {F1220170} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10816 Differential Revision: https://secure.phabricator.com/D15719
2016-04-15 14:37:58 +02:00
'054a0f0b' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-tooltip',
),
Tweak grey tag color Summary: This is a bit too grey, and doesn't match our theme well (see sequence navs) Test Plan: Remarkup reference article, sequence navs Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14408
2015-11-04 22:51:51 +01:00
'056da01b' => array(
'aphront-typeahead-control-css',
'phui-tag-view-css',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'065227cc' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Improve type and icon information in typeahead Summary: Ref T10289. This probably doesn't cover everything but should do a little bit better. Although we should mabye just exlude milestones from this menu completely? Test Plan: {F1093937} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10289 Differential Revision: https://secure.phabricator.com/D15191
2016-02-05 21:39:00 +01:00
'06c32383' => array(
'javelin-behavior',
'javelin-typeahead-ondemand-source',
'javelin-typeahead',
'javelin-dom',
'javelin-uri',
'javelin-util',
'javelin-stratcom',
'phabricator-prefab',
'phuix-icon-view',
),
Fix Differental Filetree browser hotkey Summary: Adds a class for explicitly hiding the sidenav. Test Plan: Set Config to Enable Filetree. View a diff, see tree. Press `f`, see it go away. Reload page, see persistence. Reviewers: avivey, epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16359
2016-08-01 22:54:39 +02:00
'08675c6d' => array(
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-dom',
'javelin-magical-init',
'javelin-vector',
'javelin-request',
'javelin-util',
),
Refine durable column class toggling Summary: don't bother with margin class if column isn't visible. Ref T8151. Test Plan: using chrome with trackpad - loaded home with toggled off column - noted no margin class erroneously applied - toggled column off and on - correct - loaded home with toggled on column - correct - toggled column off and on - correct Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8151 Differential Revision: https://secure.phabricator.com/D12795
2015-05-11 22:50:44 +02:00
'087e919c' => array(
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-vector',
),
Remove old ObjectBox tab cruft Summary: Ref T10628. Cleans up remaining weird, unused tab behaviors in ObjectBoxView to simplify ObjectBox. Test Plan: Toggled tabs in Files. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10628 Differential Revision: https://secure.phabricator.com/D16208
2016-07-01 01:55:28 +02:00
'0a0b10e9' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0a3f3021' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'javelin-router',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'0f764c35' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'116cf19b' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phabricator-phtize',
'phabricator-textareautils',
'javelin-workflow',
'javelin-vector',
'phuix-autocomplete',
),
Improve profile menu animation Summary: The text sliding around feels a bit jank to me. Instead, here's an attempt at a three-part effect: - Fade out the content of the menu (first quarter of the animation). - Shrink the menu (half the animation). - Fade the menu content back in (final quarter). This isn't perfect, but feels less weird to me since the text doesn't dance? Test Plan: clickey clickey Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15098
2016-01-23 23:24:09 +01:00
'12884df9' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Transactions - add "view raw" action Summary: Use cutlery icon for hilarity. Ref T5768. Test Plan: made something with remarkup in it, used 'view raw' and saw the remarkup raw in a nice little dialogue. Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5768 Differential Revision: https://secure.phabricator.com/D10183
2014-08-08 00:21:32 +02:00
'13c739ea' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'javelin-uri',
'phabricator-textareautils',
),
Minor JavaScript fix Summary: Currently, `editdata` is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable. Test Plan: `arc lint` showed one less warning. Reviewers: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11062
2014-12-30 11:50:26 +01:00
'1499a8cb' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-history',
),
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'14a1faae' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
'javelin-workflow',
'javelin-workboard-controller',
),
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'1aa4c968' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phuix-dropdown-menu',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'1ad0a787' => array(
Fix variable reference Summary: What do you think this is, PHP? Test Plan: Eyeball it. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11361
2015-01-13 21:03:48 +01:00
'javelin-install',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-reactor',
'javelin-util',
'javelin-reactor-node-calmer',
Fix variable reference Summary: What do you think this is, PHP? Test Plan: Eyeball it. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11361
2015-01-13 21:03:48 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'1ae869f2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'phabricator-keyboard-shortcut-manager',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'1bd28176' => array(
'javelin-install',
'javelin-dom',
'javelin-vector',
'javelin-request',
'javelin-uri',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'1def2711' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Substantially support character encodings and "Highlight As" in changesets Summary: Ref T5179. Ref T4045. Ref T832. We can now write non-utf8 hunks into the database, so try to do more reasonable things with them in the UI. Test Plan: (See screenshots...) Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T832, T4045, T5179 Differential Revision: https://secure.phabricator.com/D9294
2014-06-20 20:49:41 +02:00
),
Allow dialogs to opt in to being resizable Summary: Ref T11034. Ref T4788. This allows you to resize the typeahead browse dialog if you want. I plan to let you resize the object selector dialog in the future. Test Plan: {F1695433} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788, T11034 Differential Revision: https://secure.phabricator.com/D16156
2016-06-21 02:29:56 +02:00
'1e911d0f' => array(
'javelin-stratcom',
'javelin-request',
'javelin-dom',
'javelin-vector',
'javelin-install',
'javelin-util',
'javelin-mask',
'javelin-uri',
'javelin-routable',
),
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'1fe2510c' => array(
'javelin-install',
'javelin-dom',
),
When summing points on a workboard, display sum with same precision as most-precise value Summary: Fixes T11703. This mostly avoids rounding errors. If point values include "0.001", we also get three digits of precision: 1.000. Maybe useful if your point field is called "bitcoins" or something. Test Plan: Before: {F1851404} After: {F1851405} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11703 Differential Revision: https://secure.phabricator.com/D16601
2016-09-27 18:29:43 +02:00
'21df4ff5' => array(
'javelin-install',
'javelin-workboard-card',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'2290aeef' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-json',
'javelin-workflow',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'2926fff2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'29274e2b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'2a171a9d' => array(
'javelin-behavior',
'javelin-request',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-uri',
'javelin-behavior-device',
'phabricator-title',
'phabricator-favicon',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'2b8de964' => array(
'javelin-install',
'javelin-util',
),
diffusion / differential - better handle case where no comment selected Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107. Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6107 Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 21:26:22 +01:00
'2c426492' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-keyboard-shortcut',
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'2caa8fb8' => array(
Make scroll keys active immediately upon page load Summary: When JX.Scrollbar activates, the page needs to be clicked before scrolling keys work. Instead, set focus into the content after we set the page frame (if something else isn't already focused). Also fixes T7042. Test Plan: In Safari, Chrome and Firefox, scrolling with key commands is now immediately active. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7042 Differential Revision: https://secure.phabricator.com/D11508
2015-01-26 18:34:57 +01:00
'javelin-install',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'javelin-event',
Make scroll keys active immediately upon page load Summary: When JX.Scrollbar activates, the page needs to be clicked before scrolling keys work. Instead, set focus into the content after we set the page frame (if something else isn't already focused). Also fixes T7042. Test Plan: In Safari, Chrome and Firefox, scrolling with key commands is now immediately active. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7042 Differential Revision: https://secure.phabricator.com/D11508
2015-01-26 18:34:57 +01:00
),
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'2ee659ce' => array(
'javelin-install',
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'320810c8' => array(
'javelin-install',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
'javelin-dom',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-vector',
Allow installs to customize project icons Summary: Ref T10010. Ref T5819. General alignment of the stars: - There were some hacks in Conduit around stripping `fa-...` off icons when reading and writing that I wanted to get rid of. - We probably have room for a subtitle in the new heavy nav, and using the icon name is a good starting point (and maybe good enough on its own?) - The project list was real bad looking with redundant tag/names, now it is very slightly less bad looking with non-redundant types? - Some installs will want to call Milestones something else, and this gets us a big part of the way there. - This may slightly help to reinforce "tag" vs "policy" vs "group" stuff? --- I'm letting installs have enough rope to shoot themselves in the foot (e.g., define 100 icons). It isn't the end of the world if they reuse icons, and is clearly their fault. I think the cases where 100 icons will break down are: - Icon selector dialog may get very unwieldy. - Query UI will be pretty iffy/huge with 100 icons. We could improve these fairly easily if an install comes up with a reasonable use case for having 100 icons. --- The UI on the icon itself in the list views is a little iffy -- mostly, it's too saturated/bold. I'd ideally like to try either: - rendering a "shade" version (i.e. lighter, less-saturated color); or - rendering a "shade" tag with just the icon in it. However, there didn't seem to be a way to do the first one right now (`fa-example sh-blue` doesn't work) and the second one had weird margins/padding, so I left it like this for now. I figure we can clean it up once we build the thick nav, since that will probably also want an identical element. (I don't want to render a full tag with the icon + name since I think that's confusing -- it looks like a project/object tag, but is not.) Test Plan: {F1049905} {F1049906} Reviewers: chad Reviewed By: chad Subscribers: 20after4, Luke081515.2 Maniphest Tasks: T5819, T10010 Differential Revision: https://secure.phabricator.com/D14918
2015-12-30 13:36:48 +01:00
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'327a00d1' => array(
Add a basic remarkup typeahead for users and projects Summary: Ref T3725. This probably has 900,000 bugs. This will need updates for subprojects/milestones. Test Plan: - Tested very gently in Safari, Firefox and Chrome. - Reasonable inputs appear to work. - Clicking, escape, tab, return, arrow keys work OK? Reviewers: chad Reviewed By: chad Maniphest Tasks: T3725 Differential Revision: https://secure.phabricator.com/D15029
2016-01-15 13:25:22 +01:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-workflow',
),
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'358c717b' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-aphlict',
'javelin-workflow',
'javelin-router',
'javelin-behavior-device',
'javelin-vector',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'3ab51e2c' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-magical-init',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Rename Passphrase credential control JS Summary: This filename is wrong ("phame" should be "passphrase"). Test Plan: Read filename. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11934
2015-03-02 22:01:00 +01:00
'3cb0b2fc' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'javelin-uri',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'3dbf94d5' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-stratcom',
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'3f5d6dbf' => array(
'javelin-behavior',
'javelin-dom',
'phortune-credit-card-form',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'40a6a403' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Make query panels editable by normal humans Summary: Ref T4986. Instead of requiring you to know engine class names and copy/paste URLs, provide select dropdowns that use SCARY JAVASCRIPT to do magical things. I think this is mostly reasonable, the only issue is that it's hard to create a panel out of a completely ad-hoc query (you'd have to save it, then create a panel out of the saved query, then remove the saved query). Once we develop T5307 we can do a better job of this. Test Plan: See screenshots. Reviewers: chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T4986 Differential Revision: https://secure.phabricator.com/D9572
2014-06-16 21:27:12 +02:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
42126667 => array(
'javelin-behavior',
'javelin-dom',
'javelin-request',
),
Don't mutate DOM by showing a tooltip on touch events Summary: This fix further addresses T10229. The problem and solution are the same: - If the DOM is mutated during a touch, it never registers as a 'click' so the tapped button does not activate. - This was partially addressed in D15136, which covered taps on code lines in a Differential view. - Tapping on some buttons, like "Reply" or "Hide Comment" still caused the problem by showing a tooltip. - There are probably similar buttons elsewhere, other than in Differential, exhibiting the same 'needs multiple taps to work' behaviour. - The testing in the iOS simulator performed for D15136 did not reveal that the problem with "Hide comment" and such remained because the small device size used for testing triggered the `!= 'desktop'` path for tooltips. To fix it: - Don't show tooltips for touch events. You can't 'hover' with a finger (with today's tech) so that UI paradigm doesn't apply. - Show the tooltips for regular mouse events, even if they are on the same device. Some devices have both touch and a mouse. - No longer try to rely on a distinction between 'desktop' and 'mobile' devices. Mobile devices like the iPad Pro are essentially desktop like, and as mentioned above, a single device could be both touch and mouse enabled. It's not about the nature of the device, it's about the nature of the interaction. Test Plan: - Tapped "Hide Comment", "Reply" on an iPad Pro running iOS 9.2 and got single touch responses with no tooltips. - Tried the same on an iPhone 6 running iOS 9.2. - Hovered over the same on a regular desktop in Safari and saw tooltips. Clicked and saw regular reactions. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15310
2016-02-19 14:06:14 +01:00
'42fcb747' => array(
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'phabricator-tooltip',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'44959b73' => array(
'javelin-util',
'javelin-uri',
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'453c5375' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'469c0d9e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-workflow',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
47830651 => array(
'javelin-behavior',
'javelin-dom',
'javelin-view-renderer',
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'47c794d8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
48086888 => array(
'javelin-behavior',
'javelin-dom',
'javelin-workflow',
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'484a6e22' => array(
'javelin-behavior',
'javelin-dom',
'phabricator-drag-and-drop-file-upload',
'phabricator-textareautils',
),
JX.Favicon for Conpherence Summary: I think maybe these should be more separate from JX.Title, but seems to work ok. May build new favicons just for messages though. Proof of concept UI. Test Plan: Send message on one browser, see red icon in other browser. Click on menu, count and favicon switch back to normal. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16734
2016-10-20 20:41:57 +02:00
'485aaa6c' => array(
'javelin-install',
),
Add client-side check for protocol mismatch Summary: Fixes T10402. I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable. Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about. Test Plan: Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T10402 Differential Revision: https://secure.phabricator.com/D16064
2016-06-07 00:01:18 +02:00
'491416b3' => array(
'javelin-behavior',
'javelin-uri',
'phabricator-notification',
),
Improve "thread" rendering of unusually-shaped graphs Summary: Ref T4788. This fixes all the bugs I was immediately able to catch: - "Directory-Like" graph shapes could draw too many vertical lines. - "Reverse-Directory-Like" graph shapes could draw too few vertical lines. - Terminated, branched graph shapes drew the very last line to the wrong place. This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything. Test Plan: - Added failing tests and made them pass. {F1708158} {F1708159} {F1708160} {F1708161} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 18:22:00 +02:00
'49ae8328' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
),
Fix "\" keyboard shortcut on German keyboard layouts Summary: Ref T10252. This is similar to D16259, but makes KeyboardShortcutManager more relaxed about `altKey` when typing obscure characters. Test Plan: Pressed Option + Shift + 7 on a German keyboard layout, saw Conphernece sidebar toggle. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16260
2016-07-08 17:30:30 +02:00
'4a021c10' => array(
'javelin-install',
'javelin-util',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
),
Make Calendar day view a little more consistent Summary: Ref T11326. This just cleans things up a little and removes some of the obvious layout/CSS issues. Test Plan: - Viewed day view before/after. Also viewed profile panel. Before: {F1725547} After: {F1725548} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11326 Differential Revision: https://secure.phabricator.com/D16308
2016-07-15 23:02:24 +02:00
'4b3c4443' => array(
'phuix-icon-view',
),
Support field previews in EditEngine Summary: Ref T10004. This primarily supports moving Phame to EditEngine. Test Plan: {F1045166} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14887
2015-12-26 22:00:01 +01:00
'4b700e9e' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-shaped-request',
),
When the JS "Intl" API is available, use it to guess the timezone Summary: Ref T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in. Firefox also exposes "Intl" but this doesn't seem to be a reliable method to read the timezone. Test Plan: In Chrome, swapped my system date/time between zones, clicked the "reconcile" popup, got the dropdown prefilled accurately. In Safari (no `Intl` API) got the normal flow with no default selected. Reviewers: chad Reviewed By: chad Maniphest Tasks: T3025 Differential Revision: https://secure.phabricator.com/D15962
2016-05-22 15:50:12 +02:00
'4c193c96' => array(
'javelin-behavior',
'javelin-uri',
'phabricator-notification',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4e3e79a6' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'4fbbc3e9' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-util',
'javelin-vector',
'differential-inline-comment-editor',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'4fdb476d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Add flat text assertions to Phabricator remarkup rules Summary: Remarkup rules can not safely use arbitrary text in tag attributes, because it may include tokens which are later replaced. Precedence rules should prevent this in general. Use flat text assertions and adjust precedence rules in cases where they may not prevent tokens from appearing in attributes. Auditors: btrahan
2014-07-01 20:04:05 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'503e17fd' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-typeahead-source',
'javelin-util',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'519705ea' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Time controls should format end date value correctly (not 5:0 PM) Summary: Fixes T9296 Test Plan: Create an event, change start time to `3PM`, end value should update to `4:00 PM`, not `4:0 PM` Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9296 Differential Revision: https://secure.phabricator.com/D15725
2016-04-15 21:06:53 +02:00
'522431f7' => array(
'javelin-behavior',
'javelin-util',
'javelin-dom',
'javelin-stratcom',
'javelin-vector',
'javelin-typeahead-static-source',
),
Conpherence - make sure real time updates still work if you switch threads Summary: Fixes T8118. Turns out this also was broken in the main view if e.g. you went to just /conpherence/. The fix is to make sure the threadmanager js class explicitly manages subscriptions as the loaded thread changes. Test Plan: - from /conpherence/ was able to receive messages in real time. - from /conpherence/ changed threads and still received messages in real time - from durable column switched threads and received messages in real time Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8118 Differential Revision: https://secure.phabricator.com/D12758
2015-05-07 21:47:49 +02:00
'5359e785' => array(
'javelin-install',
'javelin-util',
'javelin-websocket',
'javelin-leader',
'javelin-json',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'54b612ba' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-color',
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'54f314a0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-typeahead-source',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'558829c2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-stratcom',
'javelin-behavior',
'javelin-vector',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Fix an issue with creating tasks directly into milestone columns Summary: These columns were conflating `projectPHID` (the defualt project to add to the task) with `boardPHID` (the board the column appears on). Separate them to fix the beahvior. Test Plan: Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15242
2016-02-11 18:51:32 +01:00
'55baf5ed' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
'javelin-workflow',
'phabricator-drag-and-drop-file-upload',
'javelin-workboard-board',
),
When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. Summary: Fixes T9295 Test Plan: Create event, open datepicker for start date, choose 1/31/2016, open datepicker again, click right button to scroll month. New suggested date should be 2/29/2016 Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T9295 Differential Revision: https://secure.phabricator.com/D15727
2016-04-15 22:52:00 +02:00
'568931f3' => array(
'javelin-behavior',
'javelin-util',
'javelin-dom',
'javelin-stratcom',
'javelin-vector',
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'58dea2fa' => array(
Save, then restore scroll position in Chrome textareas on remarkup assist Summary: Fixes T10396. Seems like this has been around for a while (references from 2011): http://stackoverflow.com/questions/4002312/chrome-resets-the-textarea-scroll-bar-scrolltop-when-focus-is-called https://bugs.chromium.org/p/chromium/issues/detail?id=75072 Commenting out this `focus()` seemed to fix the issue locally, at the cost of not focusing. Saving, focusing, then restoring seems to produce the correct behavior everywhere. Test Plan: - In Safari, Firefox and Chrome, typed a ton of text into a remarkup area (more than the height of the area, so it has a scrollbar). - Selected some text near the top. - Clicked "B" to bold the text. - Scroll position remained the same in all browsers (previously: in Chrome, it changed). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10396 Differential Revision: https://secure.phabricator.com/D15313
2016-02-19 22:41:03 +01:00
'javelin-install',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-util',
'javelin-request',
Save, then restore scroll position in Chrome textareas on remarkup assist Summary: Fixes T10396. Seems like this has been around for a while (references from 2011): http://stackoverflow.com/questions/4002312/chrome-resets-the-textarea-scroll-bar-scrolltop-when-focus-is-called https://bugs.chromium.org/p/chromium/issues/detail?id=75072 Commenting out this `focus()` seemed to fix the issue locally, at the cost of not focusing. Saving, focusing, then restoring seems to produce the correct behavior everywhere. Test Plan: - In Safari, Firefox and Chrome, typed a ton of text into a remarkup area (more than the height of the area, so it has a scrollbar). - Selected some text near the top. - Clicked "B" to bold the text. - Scroll position remained the same in all browsers (previously: in Chrome, it changed). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10396 Differential Revision: https://secure.phabricator.com/D15313
2016-02-19 22:41:03 +01:00
'javelin-dom',
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'javelin-uri',
'phabricator-file-upload',
Save, then restore scroll position in Chrome textareas on remarkup assist Summary: Fixes T10396. Seems like this has been around for a while (references from 2011): http://stackoverflow.com/questions/4002312/chrome-resets-the-textarea-scroll-bar-scrolltop-when-focus-is-called https://bugs.chromium.org/p/chromium/issues/detail?id=75072 Commenting out this `focus()` seemed to fix the issue locally, at the cost of not focusing. Saving, focusing, then restoring seems to produce the correct behavior everywhere. Test Plan: - In Safari, Firefox and Chrome, typed a ton of text into a remarkup area (more than the height of the area, so it has a scrollbar). - Selected some text near the top. - Clicked "B" to bold the text. - Scroll position remained the same in all browsers (previously: in Chrome, it changed). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10396 Differential Revision: https://secure.phabricator.com/D15313
2016-02-19 22:41:03 +01:00
),
Make busy indicator durable column aware Summary: Fixes T7699, moves busy indicator when durable column is present Test Plan: visit uiexamples busy page, toggle column on and off Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7699 Differential Revision: https://secure.phabricator.com/D12257
2015-04-02 05:10:32 +02:00
'59a7976a' => array(
'javelin-install',
'javelin-dom',
'javelin-fx',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'59b251eb' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Replace height buffer behavior while dragging on workboards with infinite column height Summary: Ref T4900. The root problem is that dragging stuff near the bottom of the board can cause jittery, jumpy behaviors. Internal scrolling has changed the nature of this problem. Previously, the height of the board itself would jump around, but it's now fixed so the height of columns jumps around instead. We could take the same approach and add a chunk to the bottom of each column when a drag starts, but this is really distracting visually since it's obvious to the user. Instead, treat columns as infinitely tall (so dragging beneath them still counts as dragging to the bottom position). Test Plan: - View a board with a column taller than the screen (has a scrollbar). - Drag a card to near the bottom position. - Move the mouse down a little bit at a time, continuing toward the bottom of the page. - Before patch: at some point, UI flips out and starts rapidly adding, scrolling, and removing the ghost. - After patch: sensible behavior, ghost is in bottom position for all cursor locations. Also works for dragging to the top. (This leaves us with a little less dead space for cancelling drags, but you've still got the left menu, anything offscreen, and the escape key, which seems fine.) Reviewers: chad Reviewed By: chad Maniphest Tasks: T4900 Differential Revision: https://secure.phabricator.com/D15227
2016-02-09 14:40:56 +01:00
'5a13c79f' => array(
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
'javelin-vector',
'javelin-magical-init',
),
Use transactions to apply "add auditors" action in Audit Summary: Ref T4896. Move the write for "Add Auditors" inside the new Editor. There are no longer any readers or writers for metadata, so remove the calls for it. Test Plan: Added auditors from the web UI. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10123
2014-08-02 23:44:35 +02:00
'5c54cbf3' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Add an icon to aphlict connection status Summary: A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc). Test Plan: Test in Notifications menu, Conpherence full, Durable Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16647
2016-10-02 05:37:28 +02:00
'5e2634b9' => array(
'javelin-behavior',
'javelin-aphlict',
'phabricator-phtize',
'javelin-dom',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'5e9f347c' => array(
'javelin-behavior',
'multirow-row-manager',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
'javelin-json',
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
60479091 => array(
'phabricator-busy',
'javelin-behavior',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'60821bc7' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'61cbc29a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-magical-init',
'javelin-util',
Make JX.Aphlict a real singleton with a more sensible initialization order Summary: Ref T5373. The control flow between `aphlict-listener` and `JX.Aphlict` is pretty weird right now, where the listener (which is the highest-level component) has intimate knowledge of how to put the SWF on the page. Instead: - Make `JX.Aphlict` a real singleton. - Instantiate it sooner. - Have it handle the flash setup handshake. Test Plan: Loaded page in debug mode, saw normal flow take place. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T5373 Differential Revision: https://secure.phabricator.com/D9699
2014-06-24 00:19:34 +02:00
),
Allow querying triggers by ID/PHID Summary: Ref T6881. I just want to show trigger info in the instance management console. Test Plan: Will test in Instances. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6881 Differential Revision: https://secure.phabricator.com/D11428
2015-01-20 01:55:08 +01:00
'62dfea03' => array(
'javelin-install',
'javelin-util',
),
Improve minor workboard drag behaviors Summary: Ref T5240. - Add proper class when dropping cards. - Add proper class when creating new cards. - Make X-drag explicit so that it works if there's only one column. - Stop tootips when dragging, resume them after dropping. - Move CSS rule for consistency. - Allow user to hit "Escape" to cancel an in-progress drag. Test Plan: - Dropped cards. - Created new cards. - X-dragged on a workboard with one column and a dashboard. - Dragged over a tooltip (no tip), dropped, moused over tooltip (tip). - Hit escape during a drag. Reviewers: chad Reviewed By: chad Subscribers: cspeckmim Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D15163
2016-02-02 15:26:42 +01:00
'6323f942' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-vector',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'635de1ec' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
),
Clean up browse/history links in Diffusion Summary: Fixes T9126. In particular: - Add "Browse" links to all history views. - Use icons to show "Browse" and "History" links, instead of text. - Use FontAwesome. - Generally standardize handling of these elements. This might need a little design attention, but I think it's an improvement overall. Test Plan: - Viewed repository history. - Viewed branch history. - Viewed file history. - Viewed table of contents on a commit. - Viewed merged changes on a merge commit. - Viewed a directory containing an external. - Viewed a deleted file. {F788419} {F788420} {F788421} {F788422} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9126 Differential Revision: https://secure.phabricator.com/D14096
2015-09-11 04:28:49 +02:00
'64a5550f' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-request',
'javelin-workflow',
),
Support drag-and-drop to set cover images on workboard cards Summary: This was slightly more complex than I believed, but not too terrible. Test Plan: {F1096126} - Also used some normal file uploaders to make sure I didn't break that. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15202
2016-02-06 23:05:15 +01:00
'680ea2c8' => array(
'javelin-install',
'javelin-dom',
'phabricator-notification',
),
Keep hovercards mostly on screen Summary: Ref T8980. Test Plan: {F1043268} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8980 Differential Revision: https://secure.phabricator.com/D14879
2015-12-24 20:59:38 +01:00
'6882e80a' => array(
Modernize Hovercard implementation Summary: Ref T8980. Move away from events to EngineExtensions. This also simplifies hovercards a bit: - Removes tasks from revision cards. - Removes blockers/blocked from task cards. - Removes "Send Message" from user cards. These mostly felt cluttery to me. Open to arguments to retain them. I think we can make better use of the space, though (e.g., flags, projects + board columns). Test Plan: - Viewed people, task, revision, commit and project hovercards. {F1043256} {F1043257} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8980 Differential Revision: https://secure.phabricator.com/D14878
2015-12-24 20:20:18 +01:00
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'69adf288' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Internet Explorer compatibility fixes Summary: A few fixes for IE that makes this work in IE9+ and at least you can drag things and have it fail horribly in IE8 now. Ref T5023. - try / catch around getBoundingClientRect because IE throws if the object is not attached to the DOM. The correct value can be inferred in these cases as 0,0 - turns out IE has different values for button here (1,2,4) than other browsers. special case this by using the other IE fact that 'which' will be null Test Plan: dragged and dropped tasks successfully in IE9, IE10, and IE11 on Windows 7. dragged and dropped tasks unsuccessfully in IE8 on Windows 7 - they always "drop" to the 2nd position or so as I think the ondrag code isn't firing properly or something Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5023 Differential Revision: https://secure.phabricator.com/D9118
2014-05-14 17:53:11 +02:00
),
Don't mutate DOM on touch-originated cursor events in Differential Summary: Fixes T10229. Broadly: - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event. - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch. To remedy this: - Distingiush between mouse-originated and touch-originated cursor events. - We do this, roughly, by setting a flag when we see "touchstart", and clearing it when we see the second copy of any unique cursor event. - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in). - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input. - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM. - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices. Test Plan: - In iOS Simulator (4s, iOS 9.2), clicked various inline actions ("Reply", "Hide", "Done", "Cancel", line numbers, etc). Got responses after a single touch. - Verified hover + click behavior on a desktop. - Logged and examined a bunch of events as a general sanity check. Reviewers: chad Reviewed By: chad Subscribers: aljungberg Maniphest Tasks: T10229 Differential Revision: https://secure.phabricator.com/D15136
2016-01-29 14:21:41 +01:00
'6ad39b6f' => array(
'javelin-install',
'javelin-event',
'javelin-util',
'javelin-magical-init',
),
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'6b8ef10b' => array(
'javelin-install',
),
Time control typeaheads. Summary: Ref T8031, Time control typeaheads Test Plan: Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Maniphest Tasks: T8031 Differential Revision: https://secure.phabricator.com/D12953
2015-05-20 18:51:26 +02:00
'6c0e62fa' => array(
'javelin-install',
'javelin-typeahead-source',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6c2b09a2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'6d3e1947' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-diffusion-locate-file-source',
'javelin-dom',
'javelin-typeahead',
'javelin-uri',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Trigger autocomplete when "@" is typed on German keyboards Summary: Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character. We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts. Test Plan: - Switched keyboard layout to German. - Typed Alt + L to generate an "@". - Typed some username text. - Got autocompleter. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10252 Differential Revision: https://secure.phabricator.com/D16259
2016-07-08 17:17:51 +02:00
'6d86ce8b' => array(
'javelin-install',
'javelin-dom',
'phuix-icon-view',
'phabricator-prefab',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'70baed2f' => array(
'javelin-install',
'javelin-dom',
'javelin-vector',
'javelin-util',
),
[Redesign] Fix Maniphest subpriority editing Summary: Ref T8099, Fixes T8338. This allows re-ordering of Maniphest Tasks in the redesign. Somehow seems more fragile, but I couldn't break anything with it. Test Plan: Try ordering into first position after header, last position, changing priority outright, everything I can drag. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099, T8338 Differential Revision: https://secure.phabricator.com/D13487
2015-06-30 18:37:12 +02:00
71237763 => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
),
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
'7319e029' => array(
'javelin-behavior',
'javelin-dom',
),
Fix scrolling behavior in Diffusion Summary: Fixes T7084. This doesn't use the same anchor logic as other applications. Test Plan: `$245` lines now jump to line 245 on page load. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7084 Differential Revision: https://secure.phabricator.com/D11563
2015-01-29 19:20:35 +01:00
'73d09eef' => array(
'javelin-behavior',
'javelin-vector',
'javelin-dom',
),
Don't show participants in Conpherence left open on mobile Summary: Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile. Test Plan: Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11764 Differential Revision: https://secure.phabricator.com/D16725
2016-10-19 06:49:02 +02:00
'7524fcfa' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'javelin-behavior-device',
'javelin-history',
'javelin-vector',
'javelin-scrollbar',
'phabricator-title',
'phabricator-shaped-request',
'conpherence-thread-manager',
),
Wrap really long text properly in diffs Summary: Fixes T11236, breaks long words and inlines the spans. Test Plan: Use a diff with super long text like SSH keys, set Font to 24/48 Impact {F1705910} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11236 Differential Revision: https://secure.phabricator.com/D16198
2016-06-30 05:27:11 +02:00
'769d3498' => array(
'syntax-default-css',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'76b9fc3e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'76f4ebed' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactor',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Support Spaces in Maniphest batch editor Summary: Ref T8498. This editor is an artifact of the Old World at this point, but it still works fine. Test Plan: Moved tasks between spaces using the batch editor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8498 Differential Revision: https://secure.phabricator.com/D13249
2015-06-11 19:24:39 +02:00
'782ab6e7' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
'multirow-row-manager',
'javelin-json',
),
Generalize URI pattern blacklist for Quicksand Summary: Fixes T7060. Removes some hard-coding. This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand. Test Plan: - Clicked a revision with column open, got Quicksand navigation. - Clicked into Conpherence with column open, got real navigation. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7060 Differential Revision: https://secure.phabricator.com/D12036
2015-03-10 23:32:15 +01:00
'7927a7d3' => array(
'javelin-behavior',
'javelin-quicksand',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7a68dda3' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'owners-path-editor',
'javelin-behavior',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7b98d7c5' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7cbe244b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
'javelin-request',
'javelin-router',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7e41274a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7ebaeed3' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'herald-rule-editor',
'javelin-behavior',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'7ee2b591' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-history',
Fix some issues where Conpherence would make to many draft requests Summary: A few minor fixes: - When we build a tag with `"meta" => null`, strip the attribute like we do for all other attributes. Previously, we would actually set the metadata to `null`. This happened with the Conpherence form. - Just respond to the draft request with an empty (but valid) response, instead of building a dialog. - `PhabricatorShapedRequest` is confusingly named and I should have caught this in review, but the basic shape of it is: - You make one object. - You call `trigger()` when stuff changes (e.g., a keystroke). - It manages making a small number of requests (e.g., one request after the user stops typing for a moment). - The way it was being used previously would incorrectly send a request for every keystroke. I think I'm going to simplify `ShapedRequest` and merge it into some larger queue for T430. Test Plan: Typed some text, no longer saw a flurry of requests. Reloaded page, still saw draft text. Reviewers: btrahan, chad Reviewed By: chad CC: aran, chad Differential Revision: https://secure.phabricator.com/D8380
2014-03-01 20:23:08 +01:00
),
Fix an issue with "packages(...)" in typeaheads Summary: Fixes T9302. This datasource wasn't resolving package PHIDs correctly for the actual query. Also fixes an issue with the "Affected packages that need audit" Herald rule. Test Plan: Ran a "Needs Audit" query with only packages, and only `packages(user)`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9302 Differential Revision: https://secure.phabricator.com/D14029
2015-09-02 00:35:25 +02:00
'805b806a' => array(
'javelin-magical-init',
'javelin-install',
'javelin-util',
'javelin-vector',
'javelin-stratcom',
),
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'82e270da' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-vector',
'javelin-stratcom',
),
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'834a1173' => array(
'javelin-behavior',
'javelin-scrollbar',
),
Remove defunt project image choices Summary: These are old project image choices, remove and only go with FontAwesome related images. Test Plan: Project -> Edit Picture -> Save Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15051
2016-01-19 17:43:31 +01:00
'8499b6ab' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
),
[Redesign] Update Object Selector UI Summary: Ref T8099, Better colors and spacing on the Object Selector. Test Plan: Hover and test new spacing. Reviewers: epriestley, btrahan Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13524
2015-07-02 23:39:43 +02:00
'85ee8ce6' => array(
'aphront-dialog-view-css',
),
Rebuild Conpherence Participants Pane Summary: Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user. Test Plan: Add to room, remove from room. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16560
2016-09-15 22:21:21 +02:00
'8604caa8' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'phabricator-notification',
'conpherence-thread-manager',
),
Merge behavior-show-more into behavior-populate Summary: Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state. Test Plan: Interacted with changesets in Phriction, Differential and Diffusion. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D11979
2015-03-05 23:03:15 +01:00
'8694b1df' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-tooltip',
'changeset-view-manager',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'88236f00' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'phabricator-keyboard-shortcut',
'javelin-stratcom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'886fd850' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactor-dom',
'javelin-view-html',
'javelin-view-interpreter',
'javelin-view-renderer',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Replace the primary scrollbar with a fake one to prepare for a persistent chat column Summary: Ref T7014. With a mouse plugged in, multi-panel UIs are pretty hideous on OSX. This is somewhat offputting for me in Conpherence, and really jumps out at me with the new column mocks in T7014. Sites like Twitch and Facebook approach this by emulating the touchpad scrollbar to achieve a more aesthetic UI. Use a similar approach. This: - Replaces the main scrollbar with a prettier fake one. - This prepares the standard page frame for a persistent chat column. Test Plan: - Seems to work properly on OSX, Chrome and Firefox. Haven't tested on IE; my Windows setup is pretty iffy at the moment. - Tried Conpherence. - Tried Workboards. Reviewers: btrahan, chad Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7014 Differential Revision: https://secure.phabricator.com/D11472
2015-01-23 22:29:15 +01:00
'887ad43f' => array(
'javelin-behavior',
'javelin-request',
'javelin-stratcom',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'8a41885b' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'8bdb2835' => array(
'phui-fontkit-css',
),
Use `window.confirm` instead of `confirm` Summary: This silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js: Warning (W117) JSHintW117 'confirm' is not defined. 39 notification.listen( 40 'activate', 41 function() { >>> 42 if (!confirm('Close notification?')) { 43 JX.Stratcom.context().kill(); 44 } 45 }); ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11065
2014-12-30 11:54:21 +01:00
'8ce821c5' => array(
'phabricator-notification',
'javelin-stratcom',
'javelin-behavior',
),
Adds a setLabel function to ActionView Summary: I copied some JavaScript. I think I did OK. Though, I couldn't stop icons from writing HTML as undefined. Anyways, this give us more options, like labels, when drawing ActionViews. I'll update the UI in other places like Policy too. Test Plan: Built and tested on the search ui dropdown. {F379678} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12522
2015-04-23 16:03:03 +02:00
'8cf6d262' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
),
Give custom controls passable disabled states Summary: Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing. Test Plan: {F1029090} - Tried to use controls, got reasonable behavior. - Used normal controls to make sure I didn't break anything. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9871, T10004 Differential Revision: https://secure.phabricator.com/D14814
2015-12-17 22:27:36 +01:00
'8d3bc1b2' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
),
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'8ff5e24c' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Show a more reasonable status element for pull requests Summary: Ref T182. Replace the total mess we had before with a sort-of-reasonable element. This automatically updates using "javascript". Test Plan: {F901983} {F901984} Used "Land Revision", saw the land status go from "Waiting" -> "Working" -> "Landed" without having to mash reload over and over again. Reviewers: chad Reviewed By: chad Maniphest Tasks: T182 Differential Revision: https://secure.phabricator.com/D14314
2015-10-21 20:28:26 +02:00
'901935ef' => array(
'javelin-behavior',
'javelin-dom',
'javelin-request',
),
Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds Summary: Cleans up the backgrounds a little on Projects/Profiles and adds a number of colour choices for Workboards. Test Plan: Manually add each color for testing. Test new project / profile layouts with and without properties. {F1109325} {F1109326} {F1109327} {F1109328} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15269
2016-02-13 20:55:14 +01:00
92197373 => array(
'phui-workcard-view-css',
),
Links on badge card should be accessible Summary: Ref T10710 Test Plan: Open user profile with badge, flip badge card, open awarder link. Reviewers: epriestley, chad, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, Korvin Maniphest Tasks: T10710 Differential Revision: https://secure.phabricator.com/D15699
2016-04-13 18:20:15 +02:00
'92b9ec77' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'93d0c9e3' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'9414ff18' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-resource',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Conpherence - add icon-based room switcher to durable column view Summary: Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there. Test Plan: clicked the icons and noted new conpherences loaded in nicely Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7380 Differential Revision: https://secure.phabricator.com/D12037
2015-03-10 23:30:49 +01:00
'949c0fe5' => array(
'javelin-install',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'94b750d2' => array(
Attempt to workaround non-deterministic `sort` behavior Summary: Ref T6861. Some discussion in IRC. The behavior of `sort` is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings. Test Plan: @epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6861 Differential Revision: https://secure.phabricator.com/D11210
2015-01-04 22:23:22 +01:00
'javelin-install',
'javelin-stratcom',
'javelin-util',
'javelin-behavior',
'javelin-json',
'javelin-dom',
'javelin-resource',
'javelin-routable',
),
Make links to hidden comments work (Fixes T11117)
2016-07-08 15:08:51 +02:00
'94c65b72' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phabricator-busy',
),
Allow users to drop .ics files on calendar views to import them Summary: Ref T10747. When a user drops a ".ics" file or a bunch of ".ics" files into a calendar view, import the events. (Possibly we should just do this if you drop ".ics" files into any application, but we can look at that later.) Test Plan: Dropped some .ics files into calendar views, got imports. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10747 Differential Revision: https://secure.phabricator.com/D16722
2016-10-18 23:24:17 +02:00
'960f6a39' => array(
'javelin-behavior',
'javelin-dom',
'javelin-uri',
'javelin-mask',
'phabricator-drag-and-drop-file-upload',
),
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'988040b4' => array(
'javelin-install',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'javelin-dom',
Fix `next_src` being defined as a global variable Summary: This variable should be local, not global. This silences a bunch of JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11067
2014-12-30 11:56:42 +01:00
'javelin-reactor-dom',
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
),
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'9a6b9324' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'phabricator-phtize',
'changeset-view-manager',
),
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'9bbf3762' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-stratcom',
),
Fix mobile menu for files in Differential Changesets Summary: Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu. Test Plan: View on mobile, desktop, browser. Click an action, spawn new page. {F1717953} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T7754, T11305 Differential Revision: https://secure.phabricator.com/D16265
2016-07-09 22:53:57 +02:00
'9ef7d354' => array(
'phui-inline-comment-view-css',
),
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
'9f36c42d' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
),
Doritos are made from corn, and are thus a vegetable.
2015-01-25 17:46:22 +01:00
'a0b57eb8' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-util',
'phabricator-keyboard-shortcut',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a155550f' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Change wording of "Show Entire File" to "Show All Context" Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
2016-01-13 15:19:31 +01:00
'a2828756' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-install',
'javelin-workflow',
'javelin-router',
'javelin-behavior-device',
'javelin-vector',
),
Quicksand - make things work properly with high security mode Summary: Fixes T7064. We need to pass the quicksand magic request variable around and then instrument the javascript to handle quicksand page loads. Test Plan: Enabled two factor auth on my account and then - visited password page - filled out 2 factor auth request - saw high security bubble - clicked about still seeing high security bubble - refreshed page and still saw security bubble - dismissed bubble by following through workflow after clicking bubble Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7064 Differential Revision: https://secure.phabricator.com/D12536
2015-04-24 01:37:56 +02:00
'a464fe03' => array(
'javelin-behavior',
'javelin-uri',
'phabricator-notification',
),
Fold task-relationship actions into an accordion dropdown Summary: Ref T11179. Alternative to D16152. I think this turned out a bit better than the other one did. Currently, we render two copies of the menu (one for mobile, one for desktop). A big chunk of this is sharing the nodes instead: when you open the mobile dropdown menu, it steals the nodes from the document. When you close it, it puts them back. Magic! Sneaky! Test Plan: {F1695499} {F1695500} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11179 Differential Revision: https://secure.phabricator.com/D16157
2016-06-21 02:49:38 +02:00
'a6f7a73b' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a80d0378' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a8d8459d' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a8da01f0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-uri',
'phabricator-keyboard-shortcut',
Remove application small/hidden tiles Summary: Ref T5176. This paves the way for the redesign by making the homepage editor thing a little more manageable/coherent. Not perfect, but we can clean it up a bit after the new design. Test Plan: Home page: {F162093} New "Pinned Applications" settings panel (this supports drag-and-drop to reorder): {F162094} Pin an app: {F162095} Unpin an app: {F162096} Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5176 Differential Revision: https://secure.phabricator.com/D9332
2014-05-29 23:20:16 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'a9f88de2' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-workflow',
'javelin-fx',
'javelin-util',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'aa1733d0' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'multirow-row-manager',
'javelin-install',
'path-typeahead',
'javelin-dom',
'javelin-util',
'phabricator-prefab',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Remove 'full-display' setting from Conpherence, spruce up search results Summary: This removes 'full-display', 'minimal-display' from Conpherence, which I recall was because we had 2 UIs for column and regular chat. I'm also tossing in slightly nicer search results, with a link to the actual message and the full date shown for context. Test Plan: Post a message in mobile, tablet, full conpherence, and in durable column. Clean up UI in durable column. Do a search in Full UI, click on result date, get taken to the message... usually. My test data is a little wonky, but I think this works most of the time. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16710
2016-10-16 05:26:15 +02:00
'aa3bd034' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-behavior-device',
'javelin-scrollbar',
'javelin-quicksand',
'phabricator-keyboard-shortcut',
'conpherence-thread-manager',
),
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'ab2f381b' => array(
'javelin-request',
'javelin-behavior',
'javelin-dom',
'javelin-router',
'javelin-util',
'phabricator-busy',
),
Regenerate the Celerity map. Auditors: chad
2016-05-21 01:26:11 +02:00
'b003d4fb' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'phuix-dropdown-menu',
),
Maniphest + Differential - don't show transaction preview until user interacts with the form. Summary: Fixes T4846. These are one off (for now) since they have various crazy actions with them. I think this will get unified and more cleaned up when we refine the UI for taking multiple actions at once, etc. Test Plan: noted no "commented on x" in either maniphest or differential. starting making a comment and noted prevew showed. started adding a subscriber (added to tokenizer) and preview showed. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4846 Differential Revision: https://secure.phabricator.com/D12936
2015-05-20 22:54:22 +02:00
'b064af76' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-request',
'javelin-util',
'phabricator-shaped-request',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b1f0ccee' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-reactor-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Don't put a spacer line on the bottom of previews Summary: Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top. Test Plan: {F409078} Also looked at a couple other applications that use this and they looked correct. Reviewers: btrahan, lpriestley, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8182 Differential Revision: https://secure.phabricator.com/D12905
2015-05-18 21:18:10 +02:00
'b23b49e6' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-request',
'phabricator-shaped-request',
),
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'b25d5444' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-typeahead-normalizer',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b2b4fbaf' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-uri',
'javelin-request',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b3a4b884' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'phabricator-prefab',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b3e7d692' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
Provide a global router for Ajax requests Summary: Fixes T430. Fixes T4834. Obsoletes D7641. Currently, we do some things less-well than we could: - We just let the browser queue and prioritize requests, so if you load a revision with 50 changes and then click "Award Token", the action blocks until the changes load in most/all browsers. It would be better to prioritize this action and queue it immediately. - Similarly, changes tend to load in order, even if the user has clicked to a specific file. When the user expresses a preference for a specific file, we should prioritize it. - We show a spinning GIF when waiting on requests. This is appropriate for some types of reuqests, but distracting for others. To fix this: - Queue all (or, at least, most) requests into a new queue in JX.Router. - JX.Router handles prioritizing the requests. Principally: - You can submit a request with a specific priority (500 = general content loading, 1000 = default, 2000 = explicit user action) and JX.Router will get the higher stuff fired off sooner. - You can name requests and then adjust their prorities later, if the user expresses an interest in specific results. - Only use the spinner gif for "workflow" requests, which is bascially when the user clicked something and we're waiting on the server. I think it's useful and not-annoying in this case. - Don't show any status for draft requests. - For content requests, show a subtle hipster-style top loading bar. Test Plan: - Viewed a diff with 93 changes, and clicked award token. - Prior to this patch, the action took many many seconds to resolve. - After this patch, it resolves quickly. - Viewed a diff with 93 changes and saw a pleasant subtle hipster-style loading bar. - Viewed a diff with 93 changes and typed some draft text. Previews populated fairly quickly and there was no spinner. - Viewed a diff with 93 changes and clicked something with workflow, saw a spinner after a moment. - Viewed a diff with 93 changes and clicked a file in the table of contents near the end of the list. - Prior to this patch, it took a long time to show up. - After this patch, it loads directly. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T430, T4834 Differential Revision: https://secure.phabricator.com/D8979
2014-05-05 19:57:42 +02:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b42eddc7' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-typeahead-preloaded-source',
'javelin-util',
Change double quotes to single quotes in JavaScript. Summary: As advised by JSHint. Test Plan: I'm not really sure how to comprehensively test this. It looks okay to me. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9677
2014-06-23 19:35:39 +02:00
),
Allow form configurations to retitle and reorder forms and add preambles Summary: Ref T9132. This just makes edited forms do //something//, albeit not anything very useful yet. You can now edit a form and: - Retitle it; - add a preamble (instructions on top of the form); and - reorder the form's fields. Test Plan: {F974632} {F974633} {F974634} {F974635} {F974636} Reviewers: chad Reviewed By: chad Subscribers: hach-que Maniphest Tasks: T9132 Differential Revision: https://secure.phabricator.com/D14503
2015-11-17 18:33:06 +01:00
'b59e1e96' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'b5c256b8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Move all comment management junk into a dropdown menu Summary: man I sure hate Javascript I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice. If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though. Test Plan: - Took all the actions. - Used existing dropdown menus. {F150196} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8966
2014-05-05 19:57:23 +02:00
),
Clean up Multirow Manager UI Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways. Test Plan: Test editing a policy and some herald rules. Stuff lines up better. {F235086} {F235087} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4234 Differential Revision: https://secure.phabricator.com/D10864
2014-11-17 23:06:05 +01:00
'b5d57730' => array(
'javelin-install',
'javelin-stratcom',
'javelin-dom',
'javelin-util',
),
Fix custom field selector control in cases where the user doesn't edit anything Summary: The JS and PHP representations of state can differ; just have the JS write the state out immediately on page load. Test Plan: Saved `diffusion.fields` without making changes, reloaded, saw no effective change. Reviewers: joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12998
2015-05-25 14:34:23 +02:00
'b6993408' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-json',
'phabricator-draggable-list',
),
When Phabricator is in read-only mode, explain why Summary: Ref T4571. Allows users to click the "read-only mode" notification to get more information about why an install is in read-only mode. Installs can be in this mode for several reasons (explicit administrative action, no masters defined, no masters reachable), and it's useful to be able to tell the difference. Test Plan: {F1212930} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15671
2016-04-10 13:26:53 +02:00
'ba158207' => array(
'javelin-behavior',
'javelin-uri',
'phabricator-notification',
),
Move Tablet breakpoint from 768 -> 920 Summary: Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12" MacBook. Ref T10926 Test Plan: Durable Column, Workboards, Dashboards, Tasks. Reviewers: epriestley Reviewed By: epriestley Subscribers: avivey, Korvin Maniphest Tasks: T10926 Differential Revision: https://secure.phabricator.com/D15960
2016-05-21 21:08:47 +02:00
'bb1dd507' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
'javelin-install',
),
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'bcaccd64' => array(
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-vector',
'phui-hovercard',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'bdaf4d04' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-request',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Allow Pholio mocks to be created and edited without drag-and-drop Summary: Ref T6523. Allows you to click stuff instead of using drag-and-drop. Test Plan: On iOS simulator, created and updated a mock. Reviewers: chad Reviewed By: chad Maniphest Tasks: T6523 Differential Revision: https://secure.phabricator.com/D16088
2016-06-09 17:34:00 +02:00
'bee502c8' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-workflow',
'javelin-quicksand',
'phabricator-phtize',
'phabricator-drag-and-drop-file-upload',
'phabricator-draggable-list',
),
Clean up display of clone URIs a little bit Summary: Ref T10923. This makes the "Clone URI" UI a little nicer: - Show whether each URI is read-only, read-write, or external. - Clicking the button selects the URI. - Add a link to manage the appropriate credentials. Test Plan: {F1308302, size=full} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10923 Differential Revision: https://secure.phabricator.com/D15891
2016-05-11 19:17:33 +02:00
'bf5374ef' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
),
Give custom controls passable disabled states Summary: Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing. Test Plan: {F1029090} - Tried to use controls, got reasonable behavior. - Used normal controls to make sure I didn't break anything. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9871, T10004 Differential Revision: https://secure.phabricator.com/D14814
2015-12-17 22:27:36 +01:00
'bff6884b' => array(
Save stacked actions in drafts, not just comments Summary: Ref T9132. Fixes T4580. Thhat might actually have been fixed a while ago or something since it describes a buggy/bad interaction which doesn't reproduce for me at HEAD. This saves and restores all the stacked actions (subscribers, projects, etc) so that you don't lose anything if you close a window by accident. Test Plan: Added a bunch of actions in various states, reloaded the page, draft stuck around. Submitted form, actions didn't stick around anymore. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4580, T9132 Differential Revision: https://secure.phabricator.com/D14675
2015-12-04 23:37:27 +01:00
'javelin-install',
'javelin-dom',
),
Allow "0" to be a valid workboard column point limit Summary: Fixes T6580. Now: - Empty field means "unlimited". - Zero means 0. - Nonzero means that number. (Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.) Test Plan: {F1103688} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6580 Differential Revision: https://secure.phabricator.com/D15239
2016-02-11 00:06:20 +01:00
'c587b80f' => array(
'javelin-install',
),
Add mask-icon for Safari pinned tab Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
2015-11-22 22:03:58 +01:00
'c7ccd872' => array(
'phui-fontkit-css',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'c90a04fc' => array(
'javelin-dom',
'javelin-dynval',
'javelin-reactor',
'javelin-reactornode',
'javelin-install',
'javelin-util',
),
When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI Summary: Ref T10004. After a user logs in, we send them to the "next" URI cookie if there is one, but currently don't always do a very good job of selecting a "next" URI, especially if they tried to do something with a dialog before being asked to log in. In particular, if a logged-out user clicks an action like "Edit Blocking Tasks" on a Maniphest task, the default behavior is to send them to the standalone page for that dialog after they log in. This can be pretty confusing. See T2691 and D6416 for earlier efforts here. At that time, we added a mechanism to //manually// override the default behavior, and fixed the most common links. This worked, but I'd like to fix the //default// beahvior so we don't need to remember to `setObjectURI()` correctly all over the place. ApplicationEditor has also introduced new cases which are more difficult to get right. While we could get them right by using the override and being careful about things, this also motivates fixing the default behavior. Finally, we have better tools for fixing the default behavior now than we did in 2013. Instead of using manual overrides, have JS include an "X-Phabricator-Via" header in Ajax requests. This is basically like a referrer header, and will contain the page the user's browser is on. In essentially every case, this should be a very good place (and often the best place) to send them after login. For all pages currently using `setObjectURI()`, it should produce the same behavior by default. I'll remove the `setObjectURI()` mechanism in the next diff. Test Plan: Clicked various workflow actions while logged out, saw "next" get set to a reasonable value, was redirected to a sensible, non-confusing page after login (the page with whatever button I clicked on it). Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14804
2015-12-17 15:10:04 +01:00
'c989ade3' => array(
'javelin-install',
'javelin-util',
'javelin-stratcom',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'ca3f91eb' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'phabricator-phtize',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'ccf1cbf8' => array(
'javelin-install',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
'phabricator-notification-css',
),
Improve some typeahead matching behaviors Summary: Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery". Sort functions last. Rename function internal strings so they don't get over-promoted the prefix-match rules. Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results. Test Plan: Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc. Main project now sorts above milestones: {F1681773} Prefix matches now sort above other matches: {F1681774} Function results (rarely used) are now less prominent: {F1681775} Better function results here: {F1681776} More function results: {F1681777} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8510 Differential Revision: https://secure.phabricator.com/D16094
2016-06-09 22:13:11 +02:00
'cfd23f37' => array(
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-typeahead',
'javelin-tokenizer',
'javelin-typeahead-preloaded-source',
'javelin-typeahead-ondemand-source',
'javelin-dom',
'javelin-stratcom',
'javelin-util',
),
Slightly better spacing, colors on ProjectCards Summary: Fixes transparent background images, removes "checkered". Better spacing for tags. Test Plan: Upload a transparent logo, hover over project. {F1093753} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15188
2016-02-05 19:30:20 +01:00
'd0c516d5' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
'javelin-workflow',
'phuix-icon-view',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd19198c8' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-dynval',
'javelin-reactor-dom',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd254d646' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-util',
Point the Phabricator resource map back to webroot/, not webroot/rsrc/ Summary: Ref T4222. Earlier, I adjusted the root from `webroot/` to `webroot/rsrc/`. However, this means that all the `/rsrc/x/y/z.jpg` fragments in CSS are no longer recognized as resource names. Since we have like 9,000 things in CSS that do `url(/rsrc/xyz.jpg)` and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other. (Both URLs also work fine, but the parsed one will be better once we have real CDN support.) Test Plan: Verified CSS gets managed resource URIs transformed into it. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7875
2014-01-01 16:46:25 +01:00
),
Fix an issue with returning to a the initial page in Quicksand Summary: Fixes T7058. We weren't propagating `state` properly so some other code ended up doing the wrong thing. Test Plan: - Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests. - Used "back", saw back button work properly. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7058 Differential Revision: https://secure.phabricator.com/D12190
2015-03-28 15:38:14 +01:00
'd4505101' => array(
'javelin-stratcom',
'javelin-install',
'javelin-uri',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd4a14807' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
'javelin-view',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd4eecc63' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Fix an initialization issue in Herald rules in Chrome Summary: Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values. Currently, the logic just sets everything to `null` or `'default'`. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.) Instead of relying on the browser to pick the right value, set the correct value explicitly. Test Plan: - Created a new rule in Chrome, Safari. - Added fields and conditions in Chrome, Safari. - Edited existing rules in Chrome, Safari. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10646 Differential Revision: https://secure.phabricator.com/D15507
2016-03-22 17:08:26 +01:00
'd6a7e717' => array(
'multirow-row-manager',
'javelin-install',
'javelin-util',
'javelin-dom',
'javelin-stratcom',
'javelin-json',
'phabricator-prefab',
),
Allow EditEngine create and edit forms to be reordered Summary: Ref T9132. Ref T9908. Puts reordering UI in place: - For create forms, this just lets you pick a UI display order other than alphabetical. Seems nice to have. - For edit forms, this lets you create a hierarchy of advanced-to-basic forms and give them different visibility policies, if you want. Test Plan: {F1017842} - Verified that "Edit Thing" now takes me to the highest-ranked edit form. - Verified that create menu and quick create menu reflect application order. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9132, T9908 Differential Revision: https://secure.phabricator.com/D14704
2015-12-08 15:14:47 +01:00
'd7a74243' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'd835b03a' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-util',
'phabricator-shaped-request',
Fix anchor-clicking scroll positions Summary: Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong. Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff. Test Plan: - Clicked comment anchors. - Loaded pages with anchors in the URI. - Loaded pages with anchors hidden behind "show older comments". In all cases, got the right scroll position. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T7069 Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 17:26:10 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'de2e896f' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-typeahead',
'javelin-typeahead-ondemand-source',
'javelin-dom',
Introduce CAN_EDIT for ExternalAccount, and make CAN_VIEW more liberal Summary: Fixes T3732. Ref T1205. Ref T3116. External accounts (like emails used as identities, Facebook accounts, LDAP accounts, etc.) are stored in "ExternalAccount" objects. Currently, we have a very restrictive `CAN_VIEW` policy for ExternalAccounts, to add an extra layer of protection to make sure users can't use them in unintended ways. For example, it would be bad if a user could link their Phabricator account to a Facebook account without proper authentication. All of the controllers which do sensitive things have checks anyway, but a restrictive CAN_VIEW provided an extra layer of protection. Se T3116 for some discussion. However, this means that when grey/external users take actions (via email, or via applications like Legalpad) other users can't load the account handles and can't see anything about the actor (they just see "Restricted External Account" or similar). Balancing these concerns is mostly about not making a huge mess while doing it. This seems like a reasonable approach: - Add `CAN_EDIT` on these objects. - Make that very restricted, but open up `CAN_VIEW`. - Require `CAN_EDIT` any time we're going to do something authentication/identity related. This is slightly easier to get wrong (forget CAN_EDIT) than other approaches, but pretty simple, and we always have extra checks in place anyway -- this is just a safety net. I'm not quite sure how we should identify external accounts, so for now we're just rendering "Email User" or similar -- clearly not a bug, but not identifying. We can figure out what to render in the long term elsewhere. Test Plan: - Viewed external accounts. - Linked an external account. - Refreshed an external account. - Edited profile picture. - Viewed sessions panel. - Published a bunch of stuff to Asana/JIRA. - Legalpad signature page now shows external accounts. {F171595} Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3732, T1205, T3116 Differential Revision: https://secure.phabricator.com/D9767
2014-07-10 19:18:10 +02:00
),
When using the "Close as Duplicate" relationship action, limit the UI to 1 task Summary: Ref T4788. When closing a task as a duplicate of another task, you can only select one task, since it doesn't really make sense to merge one task into several other tasks (this operation is //possible//, but probably not what anyone ever wants to do, I think?). Make the UI understand this: after you select a task, disable all of the "select" buttons in the UI to make this clear. Test Plan: - Used "Close as Duplicate", only allowed to select 1 task. - Used other editors like "Merge Duplicates In", allowed to select lots of tasks. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16203
2016-06-30 20:37:38 +02:00
'e0ec7f2f' => array(
'javelin-behavior',
'javelin-dom',
'javelin-request',
'javelin-util',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e10f8e18' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'phabricator-prefab',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Implement a rough optgroup-based "Move on Workboard" stacked action Summary: Ref T6027. Try this out and see how it feels? Clear issues: - This definitely shouldn't be at the top. - You should probably be able to select it multiple times? - Some of the "which columns show up" rules might need adjustment? - Diamond marker maybe not great? Not sure I love this but it doesn't feel //terrible//... Test Plan: {F1207891} Reviewers: chad Reviewed By: chad Maniphest Tasks: T6027 Differential Revision: https://secure.phabricator.com/D15638
2016-04-06 14:59:09 +02:00
'e15869a8' => array(
'javelin-install',
'javelin-dom',
),
When dragging stuff around, compensate for changes in scroll position Summary: Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag. (It does not fix "dragging near the edge of the container should scroll it" yet.) Test Plan: Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5240 Differential Revision: https://secure.phabricator.com/D10186
2014-08-09 17:49:01 +02:00
'e1d25dfb' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e1ff79b1' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Namespace Aphlict clients by request path, plus other fixes Summary: Fixes T7130. Fixes T7041. Fixes T7012. Major change here is partitioning clients. In the Phacility cluster, being able to get a huge pile of instances on a single server -- without needing to run a process per instance -- is desirable. To accomplish this, just bucket clients by the path they connect with. This will let us set client URIs to `/instancename/` and then route connections to a small set of servers. This degrades cleanly in the common case and has no effect on installs which don't do instancing. Also fix two unrelated issues: - Fix the timeouts, which were incorrectly initializing in `open()` (which is called during reconnect, causing them to reset every time). Instead, initialize in the constructor. Cap timeout at 5 minutes. - Probably fix subscriptions, which were using a property with an object definition. Since this is by-ref, all concrete instances of the object share the same property, so all users would be subscribed to everything. Probably. Test Plan: - Hit notification status page, saw version bump and instance/path name. - Saw instance/path name in client and server logs. - Stopped server, saw reconnects after 2, 4, 16, ... seconds. - Sent test notification; received test notification. - Didn't explicitly test the subscription thing but it should be obvious by looking at `/notification/status/` shortly after a push. Reviewers: joshuaspence, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7041, T7012, T7130 Differential Revision: https://secure.phabricator.com/D11769
2015-02-16 20:31:15 +01:00
'e292eaf4' => array(
'javelin-install',
),
Allow profile menu items to be reordered Summary: Ref T10054. Allows users to drag menu items to reorder them. Test Plan: Reordered a project menu. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10054 Differential Revision: https://secure.phabricator.com/D15011
2016-01-13 18:40:27 +01:00
'e2e0a072' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e379b58e' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-vector',
'javelin-dom',
'javelin-uri',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Swap charts from gRaphael to D3 Summary: Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that. D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years. Test Plan: {F1085433} {F1085434} Reviewers: chad Reviewed By: chad Subscribers: cburroughs, yelirekim Differential Revision: https://secure.phabricator.com/D15155
2016-01-28 22:29:27 +01:00
'e4232876' => array(
'javelin-behavior',
'javelin-dom',
'javelin-vector',
'phui-chart-css',
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'e4cc26b3' => array(
'javelin-behavior',
'javelin-dom',
),
Symbol Search: Allow ctrl-click with no hover Summary: Fix T8710. I had hopes of doing something cleaver with `highlighted` (Like trying to understand `foo.bar` when clicking `bar`, but I obviously didn't do it. Test Plan: ctrl-click. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: joshuaspence, epriestley, gena2x, Korvin Maniphest Tasks: T8710 Differential Revision: https://secure.phabricator.com/D13550
2015-08-27 13:17:33 +02:00
'e5339c43' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
'javelin-uri',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e5822781' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-dom',
'javelin-json',
'javelin-workflow',
'javelin-magical-init',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Make Differential use viewer's token instead of viewer() token again Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445 Test Plan: Used Differential search, saw my token. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4100 Differential Revision: https://secure.phabricator.com/D12447
2015-04-17 16:55:17 +02:00
'e6e25838' => array(
'javelin-install',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'e9581f08' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior',
'javelin-stratcom',
'javelin-workflow',
'javelin-dom',
'phabricator-draggable-list',
Remove unused JavaScript variables. Summary: There are a bunch of unused variables in JavaScript files. These were identified with JSHint. Test Plan: It's pretty hard to test this thoroughly... on inspection, it seems that everything //should// be okay (unless we are doing weird things with the JavaScript). Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9676
2014-06-23 19:27:47 +02:00
),
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'edd1ba66' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-uri',
'phabricator-notification',
),
Rebuild redesign-2015 Celerity map
2015-06-23 22:43:47 +02:00
'edf8a145' => array(
'javelin-behavior',
'javelin-uri',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'efe49472' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Make Diffusion "Last Modified" rendering less fragile Summary: Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax. The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ. In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one). In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes. Test Plan: Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of. Applied this patch, got a clean render. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9524 Differential Revision: https://secure.phabricator.com/D14243
2015-10-07 16:32:27 +02:00
'f01586dc' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-json',
),
Always show a menu on durable column Summary: If you don't have any rooms, we currently show no menu and users have no logical means of closing the column. This lets "Hide Column" at least still appear. Fixes T9195 Test Plan: Fresh install, hit {key \}, see menu. Close Column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9195 Differential Revision: https://secure.phabricator.com/D16516
2016-09-07 23:23:07 +02:00
'f03e17be' => array(
'phui-theme-css',
),
Make Conpherence Pontificate Send-on-Enter Summary: Fixes T11623. Enables send-on-enter and shift-enter for linebreaks, per durable column. Also cleaned up UI for Joining Room or Logging In. Test Plan: See room I can join, click Join Room. Leave Room, Log out, visit room with login prompt. Login, Join Room again. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11623 Differential Revision: https://secure.phabricator.com/D16595
2016-09-28 04:26:02 +02:00
'f2e58483' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-workflow',
'javelin-stratcom',
'conpherence-thread-manager',
),
Quicksand - fix project board page and quicksand Summary: Fixes T7913. Collapse the separate board dropdown into the board projects behavior; we always need that anyway and now we can install the listener more granularly. Test Plan: - visted project board - invoked create task, cancelled dialog - visited project feed - visited project board - invoked create task, cancelled dialog (FAILED pre patch...!) Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7913 Differential Revision: https://secure.phabricator.com/D12599
2015-04-28 23:51:49 +02:00
'f411b6ae' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-util',
'javelin-dom',
'javelin-request',
'phabricator-keyboard-shortcut',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f6555212' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-reactornode',
'javelin-util',
'javelin-reactor',
Use "CommentPro" controller instead of "Comment" controller Summary: Ref T2222. This will probabaly have a few rough edges too, but seems to work well. Test Plan: - Made a bunch of comments while building this. - Made some new comments. - Verified that the Asana/JIRA integration is only a little bit janky, not completely broken. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8362
2014-02-27 20:06:55 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'f7fc67ec' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-typeahead',
'javelin-dom',
'javelin-request',
'javelin-typeahead-ondemand-source',
'javelin-util',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'f829edb3' => array(
'javelin-view',
'javelin-install',
'javelin-dom',
),
Catch undefinied title attribute in lightbox Summary: If the image name in not defined, don't set it. Fixes T6793 Test Plan: View a lightboxed image, no 'undefined' alt tag Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6793 Differential Revision: https://secure.phabricator.com/D11037
2014-12-23 18:28:57 +01:00
'f8ba29d7' => array(
'javelin-behavior',
'javelin-stratcom',
'javelin-dom',
'javelin-mask',
'javelin-util',
'phabricator-busy',
),
Desktop Notification support Summary: Fixes T4139. Adds a "Desktop Notifications" panel to settings. For now, we start with "Send Desktop Notifications Too" functionality. We can try to be fancy later and only send desktop notifications if the web app doesn't have focus, etc. Test Plan: Made some comments as a test user on a task and got purdy desktop notifications using Chrome. Then did it again with Firefox. Played around with permissions form with Chrome and got helpful information about what was up. Played around with Firefox and got similar results, except canceling the dialogue didn't invoke my handler code somehow. Oh Firefox! Reviewers: epriestley Reviewed By: epriestley Subscribers: rbalik, tycho.tatitscheff, joshuaspence, epriestley, Korvin Maniphest Tasks: T4139 Differential Revision: https://secure.phabricator.com/D13219
2015-06-22 22:11:37 +02:00
'fb20ac8d' => array(
'javelin-behavior',
'javelin-aphlict',
'javelin-stratcom',
'javelin-request',
'javelin-uri',
'javelin-dom',
'javelin-json',
'javelin-router',
'javelin-util',
'javelin-leader',
'javelin-sound',
'phabricator-notification',
),
Quicksand and Pholio - make mock edit work Summary: Fixes T8036. In addition to making the mock edit work, this tightens quicksand code such that the correct page id is returned even if start() has not been called yet. It also tightens mock view where some functions should respect statics.enabled a bit more. Test Plan: clicked edit mock, mock crumb, edit mock, mock crum, edit mock, made edits and they worked! clicked edit mock, mock crumb, edit mock, mock crumb, edit mock, profile icon, hit browser back to edit mock, made edits and they worked! also observed mock view page not occasionally wigging out from image_onload race not having statics.enabled respect during the above Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8036 Differential Revision: https://secure.phabricator.com/D12739
2015-05-07 19:42:07 +02:00
'fbe497e7' => array(
'javelin-behavior',
'javelin-util',
'javelin-stratcom',
'javelin-dom',
'javelin-vector',
'javelin-magical-init',
'javelin-request',
'javelin-history',
'javelin-workflow',
'javelin-mask',
'javelin-behavior-device',
'phabricator-keyboard-shortcut',
),
Define JavaScript functions before they are used Summary: This should be a fairly minor change that silences a bunch of JSHint warnings. Test Plan: `arc lint` showed less warnings. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11064
2014-12-30 11:53:27 +01:00
'fc91ab6c' => array(
'javelin-behavior',
'javelin-dom',
'phortune-credit-card-form',
),
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'fe287620' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-install',
'javelin-dom',
Float actions in header for better overflow Summary: Fixes T6964, makes action links float instead of absolutely positioned. Test Plan: Tested UIExamples, actions in single line headers, multi line headers, headers with images, workboard headers. Test desktop, mobile, and tablet breakpoints. Long titles wrap as expected as button list grows. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6964 Differential Revision: https://secure.phabricator.com/D11379
2015-01-14 01:10:57 +01:00
'javelin-view-visitor',
'javelin-util',
Update Phortune UI elements Summary: Ref T2787. Update some of the UI elements used by Phortune. Mostly gets rid of the old blue headers. Also adds some sweet art. Test Plan: Poked aroudn Phortune. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D9915
2014-07-13 18:18:50 +02:00
),
Survive receipt of too much workboard column position information Summary: Fixes T11468. I was able to find //a// reproduction case for the issue, at least, described in my comments there. When the server sends back position information for columns we aren't displaying, for whatever reason, just ignore that information. Future work in T4900 to do more synchronization may revisit this. Test Plan: See T11468#190177 for steps. Did that stuff with this patch, got a clean edit. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11468 Differential Revision: https://secure.phabricator.com/D16397
2016-08-14 17:58:17 +02:00
'fe7cb52a' => array(
'javelin-install',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'phabricator-draggable-list',
'javelin-workboard-column',
),
Probably improve behavior around duplicate notifications Summary: We're sometimes getting duplicate notifications right now. I think this is because multiple windows are racing and becoming leaders. Clean this up a little: - Fix the `timeoout` typo. - Only try to usurp once. - Use different usurp and expire delays, so we don't fire them at the exact same time. Not sure if this'll work or not but it should theoretically be a little cleaner. Test Plan: - Quit Safari, reopened Safari, still saw a fast reconnect to the notification server (this is the goal of usurping). - Did normal notification stuff like opening a chat in two windows, got notifications. - Hard to reproduce the race for sure, but this at least fixes the outright `timeoout` bug. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15806
2016-04-27 01:27:31 +02:00
'fea0eb47' => array(
'javelin-install',
),
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'packages' => array(
Package Conpherence CSS Summary: Ref T5390, creates a Conpherence CSS package for fewer download connections. Test Plan: celerity map Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T5390 Differential Revision: https://secure.phabricator.com/D16535
2016-09-13 00:22:04 +02:00
'conpherence.pkg.css' => array(
'conpherence-durable-column-view',
'conpherence-menu-css',
'conpherence-message-pane-css',
'conpherence-notification-css',
'conpherence-transaction-css',
Rebuild Conpherence Participants Pane Summary: Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user. Test Plan: Add to room, remove from room. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16560
2016-09-15 22:21:21 +02:00
'conpherence-participant-pane-css',
Rebuild Conpherence Summary: Minor rebuild / redesign of Conpherence. Most of this is new UX and tossing out things like widgets, device fallbacks. I expect some of the UI to get more polished after next pass, but most everything here is in place. - Removed "Widgets", now just a single Participants pane - Added "Topic" - New header - Settings, Edit are action icons - Removed a lot of JS - Simplified CSS as much as I could Test Plan: Desktop, Tablet, Mobile. Adding and removing people. Setting new topics, new rooms. {F1828662} {F1828669} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16550
2016-09-15 03:34:11 +02:00
'conpherence-header-pane-css',
Package Conpherence CSS Summary: Ref T5390, creates a Conpherence CSS package for fewer download connections. Test Plan: celerity map Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T5390 Differential Revision: https://secure.phabricator.com/D16535
2016-09-13 00:22:04 +02:00
),
Conpherence JS package for celerity Summary: Bundles up 8 JS files Test Plan: play with Conpherence Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16554
2016-09-15 05:05:14 +02:00
'conpherence.pkg.js' => array(
'javelin-behavior-conpherence-menu',
Rebuild Conpherence Participants Pane Summary: Mostly quality of life in renames and moving everything to the view class. Minor CSS tweaks. Fix room handles getting added when adding a new user. Test Plan: Add to room, remove from room. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16560
2016-09-15 22:21:21 +02:00
'javelin-behavior-conpherence-participant-pane',
Conpherence JS package for celerity Summary: Bundles up 8 JS files Test Plan: play with Conpherence Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16554
2016-09-15 05:05:14 +02:00
'javelin-behavior-conpherence-pontificate',
'javelin-behavior-toggle-widget',
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'core.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-core-css',
'phabricator-zindex-css',
'phui-button-css',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'phui-theme-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-standard-page-view',
'aphront-dialog-view-css',
'phui-form-view-css',
'aphront-panel-view-css',
'aphront-table-view-css',
'aphront-tokenizer-control-css',
'aphront-typeahead-control-css',
'aphront-list-filter-view-css',
Fix some Quicksand bugs Summary: Packages AppSearch, fixes body color, moves Differential filetree into differential package. Test Plan: Enable quicksand. Navigate home -> differential -> diff. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16641
2016-09-30 23:55:04 +02:00
'application-search-view-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-remarkup-css',
'syntax-highlighting-css',
Generate syntax highlighting CSS from a reusable map Summary: Ref T9790. This prepares the syntax color rules to be reused in mail. This goes about halfway toward T5701 by sort-of supporting different styles but not really. Test Plan: - Ran `bin/celerity syntax` to regenerate syntax map. - Viewed some highlighted code, didn't see any differences. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9790 Differential Revision: https://secure.phabricator.com/D15846
2016-05-05 03:24:59 +02:00
'syntax-default-css',
[Redesign] PHUIPagerView Summary: Ref T8099, Moves AphrontPagerView to PHUIPagerView, converts to standard PHUIButtons and adds some additional features for icon placement on buttons. Test Plan: Tested Advanced Search and Searching files in Diffusion. Works as expected. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8342, T8099 Differential Revision: https://secure.phabricator.com/D13092
2015-06-02 23:34:04 +02:00
'phui-pager-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'aphront-tooltip-css',
'phabricator-flag-css',
Move PHUIErrorView to PHUIInfoView Summary: Since this element isn't strictly about errors, re-label as info view instead. Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11867
2015-03-01 23:45:56 +01:00
'phui-info-view-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-main-menu-view',
'phabricator-notification-css',
'phabricator-notification-menu-css',
'lightbox-attachment-css',
'phui-header-view-css',
'phabricator-nav-view-css',
Redesign Application Search Summary: This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut. Test Plan: Config, Maniphest, Differential, Diffusion, Home. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16346
2016-08-01 21:06:35 +02:00
'phui-basic-nav-view-css',
Move Conduit client construction logic into Repository Summary: Ref T7020. I need this elsewhere, and it's relatively internal anyway. Test Plan: Browsed around my local, cluster-configured install and saw everything working fine. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7020 Differential Revision: https://secure.phabricator.com/D11474
2015-01-23 22:30:00 +01:00
'phui-crumbs-view-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phui-object-item-list-view-css',
'global-drag-and-drop-css',
'phui-spacing-css',
'phui-form-css',
'phui-icon-view-css',
Rough initial cut of profile new profile menu Summary: Ref T10054. I haven't done any of the big-picture layout stuff yet, but this should get look-and-feel somewhere in the ballpark of reasonablness, I think. Major missing stuff: - No "collapse" state or action yet. - Menu is not full-height (requires changes to the rendering pipeline). Test Plan: {F1060941} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10054 Differential Revision: https://secure.phabricator.com/D15016
2016-01-14 01:07:04 +01:00
'phui-profile-menu-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-application-launch-view-css',
'phabricator-action-list-view-css',
'phui-property-list-view-css',
'phui-tag-view-css',
'phui-list-view-css',
'font-fontawesome',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'font-lato',
'font-aleo',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phui-font-icon-base-css',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'phui-fontkit-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phui-box-css',
'phui-object-box-css',
'phui-timeline-view-css',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'phui-two-column-view-css',
'phui-curtain-view-css',
'sprite-login-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'sprite-tokens-css',
'tokens-css',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'auth-css',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phui-status-list-view-css',
Rewrite Aphlict to use Websockets Summary: Fixes T6559. No more flash, use Websockets. This is less aggressive than the earlier version, and retains more server logic. - Support "wss". - Make the client work. - Remove "notification.user" entirely. - Seems ok? Test Plan: In Safari, Firefox and Chrome, saw the browsers connect. Made a bunch of comments/updates and saw notifications. Notable holes in the test plan: - Haven't tested "wss" yet. I'll do this on secure. - Notifications are //too fast// now, locally. I get them after I hit submit but before the page reloads. - There are probably some other rough edges, this is a fairly big patch. Reviewers: joshuaspence, btrahan Reviewed By: joshuaspence, btrahan Subscribers: fabe, btrahan, epriestley Maniphest Tasks: T6713, T6559 Differential Revision: https://secure.phabricator.com/D11143
2015-01-08 19:03:00 +01:00
'phui-feed-story-css',
'phabricator-feed-css',
'phabricator-dashboard-css',
'aphront-multi-column-view-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'core.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-util',
'javelin-install',
'javelin-event',
'javelin-stratcom',
'javelin-behavior',
'javelin-resource',
'javelin-request',
'javelin-vector',
'javelin-dom',
'javelin-json',
'javelin-uri',
'javelin-workflow',
'javelin-mask',
'javelin-typeahead',
'javelin-typeahead-normalizer',
'javelin-typeahead-source',
'javelin-typeahead-preloaded-source',
'javelin-typeahead-ondemand-source',
'javelin-tokenizer',
'javelin-history',
'javelin-router',
'javelin-routable',
'javelin-behavior-aphront-basic-tokenizer',
'javelin-behavior-workflow',
'javelin-behavior-aphront-form-disable-on-submit',
'phabricator-keyboard-shortcut-manager',
'phabricator-keyboard-shortcut',
'javelin-behavior-phabricator-keyboard-shortcuts',
'javelin-behavior-refresh-csrf',
'javelin-behavior-phabricator-watch-anchor',
'javelin-behavior-phabricator-autofocus',
'phuix-dropdown-menu',
'phuix-action-list-view',
'phuix-action-view',
Rebuild CSS packages Summary: Review multimeter logs for new CSS/JS resources that should be in packages. Test Plan: Review some pages in sandbox, no CSS errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16490
2016-09-03 22:37:48 +02:00
'phuix-icon-view',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-phtize',
'javelin-behavior-phabricator-oncopy',
'phabricator-tooltip',
'javelin-behavior-phabricator-tooltips',
'phabricator-prefab',
'javelin-behavior-device',
'javelin-behavior-toggle-class',
'javelin-behavior-lightbox-attachments',
'phabricator-busy',
'javelin-aphlict',
'phabricator-notification',
'javelin-behavior-aphlict-listen',
'javelin-behavior-phabricator-search-typeahead',
'javelin-behavior-aphlict-dropdown',
'javelin-behavior-history-install',
'javelin-behavior-phabricator-gesture',
'javelin-behavior-phabricator-active-nav',
'javelin-behavior-phabricator-nav',
'javelin-behavior-phabricator-remarkup-assist',
'phabricator-textareautils',
'phabricator-file-upload',
'javelin-behavior-global-drag-and-drop',
'javelin-behavior-phabricator-reveal-content',
Move PhabricatorHovercard to PHUIHovercard Summary: No UI changes, just some search and replace for UI consistency. Test Plan: Test person and object hovercards still work. UIExamples too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15172
2016-02-03 17:26:30 +01:00
'phui-hovercard',
'javelin-behavior-phui-hovercards',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-color',
'javelin-fx',
'phabricator-draggable-list',
'javelin-behavior-phabricator-transaction-list',
Transactions - kill the old "show all" code pathways Summary: we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite... Test Plan: viewed a task with a lot of transactions. clicked "show older" and it worked! Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T4712 Differential Revision: https://secure.phabricator.com/D10926
2014-12-04 23:55:18 +01:00
'javelin-behavior-phabricator-show-older-transactions',
Give Phriction a real dropdown Summary: Fixes T8150. Small generalization: - Timeline has a dropdown with no special logic; make that generic. - Use it in Phriction. Test Plan: - Used Phriction dropdown on desktop and mobile. - Used timeline dropdown. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8150 Differential Revision: https://secure.phabricator.com/D12931
2015-05-19 21:14:44 +02:00
'javelin-behavior-phui-dropdown-menu',
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-doorkeeper-tag',
Rewrite Aphlict to use Websockets Summary: Fixes T6559. No more flash, use Websockets. This is less aggressive than the earlier version, and retains more server logic. - Support "wss". - Make the client work. - Remove "notification.user" entirely. - Seems ok? Test Plan: In Safari, Firefox and Chrome, saw the browsers connect. Made a bunch of comments/updates and saw notifications. Notable holes in the test plan: - Haven't tested "wss" yet. I'll do this on secure. - Notifications are //too fast// now, locally. I get them after I hit submit but before the page reloads. - There are probably some other rough edges, this is a fairly big patch. Reviewers: joshuaspence, btrahan Reviewed By: joshuaspence, btrahan Subscribers: fabe, btrahan, epriestley Maniphest Tasks: T6713, T6559 Differential Revision: https://secure.phabricator.com/D11143
2015-01-08 19:03:00 +01:00
'phabricator-title',
'javelin-leader',
'javelin-websocket',
'javelin-behavior-dashboard-async-panel',
'javelin-behavior-dashboard-tab-panel',
Update Celerity Packages Summary: Ref T6930. Looked at Multimeter data and used it to adjust package definitions. Test Plan: Browsed around. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6930 Differential Revision: https://secure.phabricator.com/D12672
2015-05-03 16:51:00 +02:00
'javelin-quicksand',
'javelin-behavior-quicksand-blacklist',
'javelin-behavior-high-security-warning',
Lay `cluster.databases` configuration groundwork for database clustering Summary: Ref T4571. This adds a new option which allows you to upgrade your one-host configuration to a multi-host configuration by configuring it. Doing this currently does nothing. I wrote a lot of words about what it is //supposed// to do in the future, though. Test Plan: - Tried to configure the option in all the possible bad ways, got errors. - Read documentation. Reviewers: chad Reviewed By: chad Subscribers: eadler Maniphest Tasks: T4571 Differential Revision: https://secure.phabricator.com/D15663
2016-04-09 14:41:08 +02:00
'javelin-behavior-read-only-warning',
Update Celerity Packages Summary: Ref T6930. Looked at Multimeter data and used it to adjust package definitions. Test Plan: Browsed around. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6930 Differential Revision: https://secure.phabricator.com/D12672
2015-05-03 16:51:00 +02:00
'javelin-scrollbar',
'javelin-behavior-scrollbar',
'javelin-behavior-durable-column',
'conpherence-thread-manager',
Update Celerity map.
2016-05-21 22:27:56 +02:00
'javelin-behavior-detect-timezone',
Add client-side check for protocol mismatch Summary: Fixes T10402. I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable. Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about. Test Plan: Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T10402 Differential Revision: https://secure.phabricator.com/D16064
2016-06-07 00:01:18 +02:00
'javelin-behavior-setup-check-https',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'darkconsole.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-dark-console',
'javelin-behavior-error-log',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'differential.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'differential-core-view-css',
'differential-changeset-view-css',
'differential-revision-history-css',
'differential-revision-list-css',
'differential-table-of-contents-css',
'differential-revision-comment-css',
'differential-revision-add-comment-css',
'phabricator-object-selector-css',
'phabricator-content-source-view-css',
'inline-comment-summary-css',
Update Celerity Packages Summary: Ref T6930. Looked at Multimeter data and used it to adjust package definitions. Test Plan: Browsed around. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6930 Differential Revision: https://secure.phabricator.com/D12672
2015-05-03 16:51:00 +02:00
'phui-inline-comment-view-css',
Fix some Quicksand bugs Summary: Packages AppSearch, fixes body color, moves Differential filetree into differential package. Test Plan: Enable quicksand. Navigate home -> differential -> diff. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16641
2016-09-30 23:55:04 +02:00
'phabricator-filetree-view-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'differential.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'phabricator-drag-and-drop-file-upload',
'phabricator-shaped-request',
'javelin-behavior-differential-feedback-preview',
'javelin-behavior-differential-edit-inline-comments',
'javelin-behavior-differential-populate',
'javelin-behavior-differential-diff-radios',
'javelin-behavior-differential-comment-jump',
'javelin-behavior-differential-add-reviewers-and-ccs',
'javelin-behavior-differential-keyboard-navigation',
'javelin-behavior-aphront-drag-and-drop-textarea',
'javelin-behavior-phabricator-object-selector',
'javelin-behavior-repository-crossreference',
'javelin-behavior-load-blame',
'differential-inline-comment-editor',
'javelin-behavior-differential-dropdown-menus',
'javelin-behavior-differential-toggle-files',
'javelin-behavior-differential-user-select',
'javelin-behavior-aphront-more',
Update Celerity Packages Summary: Ref T6930. Looked at Multimeter data and used it to adjust package definitions. Test Plan: Browsed around. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T6930 Differential Revision: https://secure.phabricator.com/D12672
2015-05-03 16:51:00 +02:00
'changeset-view-manager',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'diffusion.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'diffusion-icons-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'diffusion.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-diffusion-pull-lastmodified',
'javelin-behavior-diffusion-commit-graph',
'javelin-behavior-audit-preview',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'maniphest.pkg.css' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'maniphest-task-summary-css',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
Use `phutil_var_export` in `CelerityManagementMapWorkflow` Summary: `phutil_var_export` produces more readable output than `var_export`. Depends on D9923. Test Plan: Eye-balled the Celerity map. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9926
2014-07-14 17:33:33 +02:00
'maniphest.pkg.js' => array(
Phortune Carts and Purchases Summary: Ref T2787. Make carts and purchases real objects, with storage, that kind-of work. Roughly, the idea here is that applications create "purchases" (like "1 large t-shirt") and add them to "carts" (a user can have a lot of different carts at the same time), then hand things off to Phortune to deal with actualy charging a card. Roughly this works like Paypal or other similar systems do, except Phortune is the thing the user gets handed off to. This doesn't do anything interesting/useful yet. Also fix some bugs and update some UI. Test Plan: Added a product to a cart, saw it in cart screen. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D10001
2014-07-23 19:34:08 +02:00
'javelin-behavior-maniphest-batch-selector',
'javelin-behavior-maniphest-subpriority-editor',
'javelin-behavior-maniphest-list-editor',
Drive all Celerity operations from the new map Summary: Ref T4222. - Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map. - The new map is about 50% smaller and organized more sensibly. - This removes the `/pkg/` URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name. - Removes some junky old APIs. - Cleans up some other APIs. - Added some feedback for `bin/celerity map`. - `CelerityResourceMap` is still a singleton which is inextricably bound to the Phabricator map; this will change in the future. Test Plan: - Reloaded pages. - Verified packaging works by looking at generated includes. - Forced minification on and verified it worked. - Forced no-timestamps on and verified it worked. - Rebuilt map. - Ran old script and verified error message. - Checked logs. Reviewers: btrahan, hach-que Reviewed By: hach-que CC: chad, aran Maniphest Tasks: T4222 Differential Revision: https://secure.phabricator.com/D7872
2014-01-01 03:04:25 +01:00
),
),
);
Copy permalink