1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 02:08:47 +02:00
phorge-phorge/src/applications
epriestley 36ab0c3313 Fix local-clobbering iterators in phabricator/
Summary:
These are the issues identified by the linter in D2052. I don't think any cause bugs, but they are all reasonable errors to raise and the linter correctly
detected that they are suspicious.

Test Plan: Mostly inspection.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2053
2012-03-29 13:24:06 -07:00
..
audit Prevent audit email from sending as the wrong user 2012-03-29 13:23:45 -07:00
auth Minor, see rPc92e37c1b1b17b8c937ef618a6e856499c23cc80 2012-03-26 10:03:32 -07:00
base Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
calendar Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
chatlog Chatlog - add a pager 2012-03-27 16:53:47 -07:00
conduit Don't trim indentation in arc amend 2012-03-29 12:23:58 -07:00
countdown Add "final" to more classes 2012-03-13 11:18:11 -07:00
daemon Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
differential If there are no flagged revisions, don't show anything on "Active Revisions" 2012-03-28 20:03:16 -07:00
diffusion Fix local-clobbering iterators in phabricator/ 2012-03-29 13:24:06 -07:00
directory Add "Flags" to allow users to collect the things they love 2012-03-27 16:22:40 -07:00
draft/storage Add "final" to more classes 2012-03-13 11:18:11 -07:00
drydock More Drydock Stuff 2012-03-26 20:54:26 -07:00
feed Add "final" to more classes 2012-03-13 11:18:11 -07:00
files Prefer PNG for thumbnails of PNG 2012-03-28 10:08:32 -07:00
flag Add "Flags" to allow users to collect the things they love 2012-03-27 16:22:40 -07:00
help/controller Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
herald Inset view controller for inset elements of forms. 2012-03-15 17:10:38 -07:00
maniphest Fix local-clobbering iterators in phabricator/ 2012-03-29 13:24:06 -07:00
markup Use "~~del~~" remarkup style in Phabricator 2012-03-21 14:01:12 -07:00
metamta Use PhabricatorEnv::newObjectFromConfig() wherever possible 2012-03-21 14:57:52 -07:00
notifications/controller Make Aphlict client somewhat more approachable 2012-03-06 20:14:03 -08:00
oauthserver Fix OAuth Client Authorization bugs 2012-03-05 13:27:20 -08:00
owners Fix commit parsing in owners tool after bug introduced in 30ae22bfcf 2012-03-21 15:10:32 +00:00
paste Kind-of-terrible (?) oncopy handler 2012-03-15 19:04:59 -07:00
people Fix refresh profile picture functionality 2012-03-21 17:46:38 -07:00
phid Add "Flags" to allow users to collect the things they love 2012-03-27 16:22:40 -07:00
phriction Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
project Projects: Filter out archived projects from all project view 2012-03-25 09:33:33 -07:00
repository Improve Herald commit emails 2012-03-23 11:08:18 -07:00
search Use PhabricatorEnv::newObjectFromConfig() wherever possible 2012-03-21 14:57:52 -07:00
slowvote Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
status/base Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
typeahead/controller Make "subscribed" filter in Differential accept any mailable 2012-03-23 08:45:48 -07:00
uiexample Add UI elements for sortable tables 2012-03-19 19:48:22 -07:00
xhpastview Add "final" to (almost) everything else 2012-03-13 16:21:04 -07:00
xhprof Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00