revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper 9aa8d09d31 Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15318

Test Plan:
Applied these five changes on top of D25147 and D25153, and both `/p/username/`
and `/people/manage/userid/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15318

Differential Revision: https://we.phorge.it/D25167
2023-05-01 22:03:41 +02:00
..
almanac Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
aphlict Reduce the verbosity of the "Aphlict" log 2020-04-14 13:24:44 -07:00
arcanist/conduit
audit Give audit statuses API constants that match their UI strings 2021-03-10 10:20:03 -08:00
auth Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog 2023-05-01 01:08:28 +02:00
badges Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
base Fix PHP 8.1 "strlen(null)" exceptions to render the Account Creation page 2023-04-29 21:54:57 +02:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Fix editing a Calendar import ICS URI 2022-12-17 12:17:37 +01:00
celerity Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load 2023-04-27 10:51:19 +02:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page 2023-04-30 18:28:13 +02:00
config Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Module page 2023-04-30 15:18:08 +02:00
conpherence Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conpherence page 2023-04-30 18:24:49 +02:00
console Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
countdown Countdown: add a capability to decide who can Create 2023-04-23 15:15:50 -05:00
daemon Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
dashboard Fix PHP 8.1 "strlen(null)" exceptions which block rendering the "Add Panel to Dashboard" overlay dialog 2023-04-30 15:15:31 +02:00
differential Feed Differential retitled: do not repeat the title twice 2023-03-25 14:21:10 +01:00
diffusion Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page 2023-04-30 15:12:57 +02:00
diviner Fix some PHP 8.1 issues in Diviner generator 2023-04-20 18:00:31 +02:00
doorkeeper Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
fact Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Remove "feed.publish" API 2022-05-17 16:30:53 -07:00
files Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating new Diffusion repository 2023-05-01 22:01:41 +02:00
flag Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
fund Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Merge Phacility/master into phorge 2022-07-25 11:50:26 -07:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Herald Rule Creation Page: fix Back button in some cases 2023-03-27 20:54:28 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Merge Phacility/master into phorge 2022-07-25 11:50:26 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
maniphest Remove product literal strings in "pht()", part 20 2022-04-25 16:46:25 -07:00
meta Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the Applications page 2023-05-01 15:34:32 +02:00
metamta PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
nuance Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
oauthserver Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
owners Remove obsolete, policy-violating "owners.query" API method 2022-05-31 10:44:45 -07:00
packages Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
passphrase Allow to prefill name and description fields of a new Passphrase 2023-02-11 11:08:12 +01:00
paste Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
people Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user 2023-05-01 22:03:41 +02:00
phame Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
phid Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration 2021-12-16 15:24:21 -08:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Fix broken file PHID extraction that causes Pholio uploads to crash 2022-11-11 13:10:16 -07:00
phortune Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction Phriction: clarify its search results as "Wiki page" 2023-04-05 15:39:41 +02:00
phurl Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
policy Provide a simple "Attach File" explicit workflow for files referenced but not attached 2022-05-24 09:49:59 -07:00
ponder Ponder: strike code of resolved questions in query results 2023-03-27 20:55:18 +02:00
project Fix numerous PHP 8.1 "strlen(null)" exceptions trying to create a project 2023-04-29 14:41:20 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
search Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Dashboard page 2023-05-01 15:45:24 +02:00
settings Correct overbroad automatic capability grant of global settings objects 2022-05-09 15:10:50 -07:00
slowvote Update Slowvote poll status to use sensible string constants 2022-05-27 10:15:01 -07:00
spaces Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application
system Fix information page about Read-only status 2023-03-25 12:06:35 +01:00
tokens Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
transactions Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects 2023-05-01 15:55:42 +02:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Remove product literal strings in "pht()", part 9 2022-04-25 12:22:29 -07:00
xhprof Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00