revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Valerio Bozzolan fc9bbb9949 Workboard: fix regression caused by tags= prefiller 
Summary:
This change fixes a regression introduced here:

rP5e2b3677157889104a7e540d7772a04f13164037

Thank you to the user @dadalha for auditing that commit
and sharing a stack trace to easily fix the issue.

In short, if you see this exception you are affected:

```
EXCEPTION: (InvalidArgumentException)
Value provided to "replaceQueryParam()" for key "tags" is NULL.
Use "removeQueryParam()" to remove a query parameter.
at [<arcanist>/src/parser/PhutilURI.php:341]
```

This change just fixes that specific problem.

Closes T15221

Test Plan:
1. Create a new Project
2. Create a new Milestone inside
3. Create the Milestone's Workboard
4. Visit the Milestone's Workboard and note that now it works

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno, dadalha

Tags: #workboard

Maniphest Tasks: T15221

Differential Revision: https://we.phorge.it/D25103
2023-03-31 11:05:22 +02:00
..
almanac Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
aphlict Reduce the verbosity of the "Aphlict" log 2020-04-14 13:24:44 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Give audit statuses API constants that match their UI strings 2021-03-10 10:20:03 -08:00
auth PHP 8.2: fix deprecated creation of dynamic properties 2023-03-27 07:10:04 +02:00
badges Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
base Provide a simple "Attach File" explicit workflow for files referenced but not attached 2022-05-24 09:49:59 -07:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Fix editing a Calendar import ICS URI 2022-12-17 12:17:37 +01:00
celerity Added cross-platform default fonts 2022-10-09 03:30:07 -07:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Show the API summary on the top of each Conduit API page 2023-02-11 11:11:20 +01:00
config Fix "Undefined index: icon" when visiting Search Servers using MySQL 2023-03-03 12:16:51 +01:00
conpherence Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
console Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
countdown Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
daemon Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
dashboard Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
differential Feed Differential retitled: do not repeat the title twice 2023-03-25 14:21:10 +01:00
diffusion PHP 8.2: fixes for deprecated use of ${var} in strings 2023-03-26 22:08:22 +02:00
diviner Remove product literal strings in "pht()", part 18 2022-04-25 16:46:25 -07:00
doorkeeper Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
fact Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Remove "feed.publish" API 2022-05-17 16:30:53 -07:00
files Update "Files" attachment table to show more attachment details and support detachment 2022-05-25 12:56:37 -07:00
flag Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
fund Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Merge Phacility/master into phorge 2022-07-25 11:50:26 -07:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Herald Rule Creation Page: fix Back button in some cases 2023-03-27 20:54:28 +02:00
home Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
legalpad Merge Phacility/master into phorge 2022-07-25 11:50:26 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
maniphest Remove product literal strings in "pht()", part 20 2022-04-25 16:46:25 -07:00
meta Remove product literal strings in "pht()", part 20 2022-04-25 16:46:25 -07:00
metamta PHP 8.2: fix deprecated use of "parent" in callables 2023-03-29 20:37:25 +02:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification Remove product literal strings in "pht()", part 21 2022-04-25 16:46:26 -07:00
nuance Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
oauthserver Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
owners Remove obsolete, policy-violating "owners.query" API method 2022-05-31 10:44:45 -07:00
packages Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
passphrase Allow to prefill name and description fields of a new Passphrase 2023-02-11 11:08:12 +01:00
paste Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
people Merge Phacility/master into phorge 2022-07-25 11:50:26 -07:00
phame Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
phid Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration 2021-12-16 15:24:21 -08:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Fix broken file PHID extraction that causes Pholio uploads to crash 2022-11-11 13:10:16 -07:00
phortune Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
phurl Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
policy Provide a simple "Attach File" explicit workflow for files referenced but not attached 2022-05-24 09:49:59 -07:00
ponder Ponder: strike code of resolved questions in query results 2023-03-27 20:55:18 +02:00
project Workboard: fix regression caused by tags= prefiller 2023-03-31 11:05:22 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository Fix repository URI generation for SVN commit identifiers represented with integer types 2022-06-03 15:01:04 -07:00
search Fix a policy issue where permissions were not properly checked when disabling global builtin queries 2022-05-31 11:00:53 -07:00
settings Correct overbroad automatic capability grant of global settings objects 2022-05-09 15:10:50 -07:00
slowvote Update Slowvote poll status to use sensible string constants 2022-05-27 10:15:01 -07:00
spaces Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Fix information page about Read-only status 2023-03-25 12:06:35 +01:00
tokens Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
transactions Flatten "RemarkupValue" objects when setting field defaults for custom forms 2022-06-14 09:37:35 -07:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Remove product literal strings in "pht()", part 9 2022-04-25 12:22:29 -07:00
xhprof Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00