2011-01-24 20:01:53 +01:00
|
|
|
<?php
|
|
|
|
|
2013-02-15 16:47:14 +01:00
|
|
|
final class DifferentialRevision extends DifferentialDAO
|
2013-03-30 17:32:29 +01:00
|
|
|
implements
|
|
|
|
PhabricatorTokenReceiverInterface,
|
|
|
|
PhabricatorPolicyInterface,
|
2013-10-25 21:52:00 +02:00
|
|
|
PhabricatorFlaggableInterface,
|
2013-12-26 19:40:52 +01:00
|
|
|
PhrequentTrackableInterface,
|
2014-02-12 17:53:40 +01:00
|
|
|
HarbormasterBuildableInterface,
|
2014-02-19 01:32:55 +01:00
|
|
|
PhabricatorSubscribableInterface,
|
|
|
|
PhabricatorCustomFieldInterface {
|
2011-01-24 20:01:53 +01:00
|
|
|
|
2013-10-09 22:58:00 +02:00
|
|
|
protected $title = '';
|
2012-06-14 05:52:10 +02:00
|
|
|
protected $originalTitle;
|
2011-01-24 20:01:53 +01:00
|
|
|
protected $status;
|
|
|
|
|
2013-10-09 22:58:00 +02:00
|
|
|
protected $summary = '';
|
|
|
|
protected $testPlan = '';
|
2011-01-24 20:01:53 +01:00
|
|
|
|
2011-01-30 19:37:36 +01:00
|
|
|
protected $authorPHID;
|
2012-03-05 19:51:47 +01:00
|
|
|
protected $lastReviewerPHID;
|
2011-01-24 20:01:53 +01:00
|
|
|
|
2013-10-09 22:58:00 +02:00
|
|
|
protected $lineCount = 0;
|
2011-02-17 23:32:01 +01:00
|
|
|
protected $attached = array();
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-05-05 08:09:42 +02:00
|
|
|
protected $mailKey;
|
2012-04-10 21:51:34 +02:00
|
|
|
protected $branchName;
|
|
|
|
protected $arcanistProjectPHID;
|
2013-09-26 21:36:30 +02:00
|
|
|
protected $repositoryPHID;
|
|
|
|
protected $viewPolicy = PhabricatorPolicies::POLICY_USER;
|
|
|
|
protected $editPolicy = PhabricatorPolicies::POLICY_USER;
|
2011-05-05 08:09:42 +02:00
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
private $relationships = self::ATTACHABLE;
|
|
|
|
private $commits = self::ATTACHABLE;
|
|
|
|
private $activeDiff = self::ATTACHABLE;
|
|
|
|
private $diffIDs = self::ATTACHABLE;
|
|
|
|
private $hashes = self::ATTACHABLE;
|
2013-09-26 21:36:45 +02:00
|
|
|
private $repository = self::ATTACHABLE;
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
private $reviewerStatus = self::ATTACHABLE;
|
2014-02-19 01:32:55 +01:00
|
|
|
private $customFields = self::ATTACHABLE;
|
2014-02-19 02:57:45 +01:00
|
|
|
private $drafts = array();
|
|
|
|
private $flags = array();
|
2012-04-10 21:51:34 +02:00
|
|
|
|
2011-04-08 06:59:42 +02:00
|
|
|
const TABLE_COMMIT = 'differential_commit';
|
2011-01-27 03:46:34 +01:00
|
|
|
|
|
|
|
const RELATION_REVIEWER = 'revw';
|
|
|
|
const RELATION_SUBSCRIBED = 'subd';
|
|
|
|
|
2013-10-09 22:58:00 +02:00
|
|
|
public static function initializeNewRevision(PhabricatorUser $actor) {
|
|
|
|
$app = id(new PhabricatorApplicationQuery())
|
|
|
|
->setViewer($actor)
|
|
|
|
->withClasses(array('PhabricatorApplicationDifferential'))
|
|
|
|
->executeOne();
|
|
|
|
|
|
|
|
$view_policy = $app->getPolicy(
|
|
|
|
DifferentialCapabilityDefaultView::CAPABILITY);
|
|
|
|
|
|
|
|
return id(new DifferentialRevision())
|
|
|
|
->setViewPolicy($view_policy)
|
|
|
|
->setAuthorPHID($actor->getPHID())
|
|
|
|
->attachRelationships(array())
|
|
|
|
->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getConfiguration() {
|
|
|
|
return array(
|
|
|
|
self::CONFIG_AUX_PHID => true,
|
2011-02-17 23:32:01 +01:00
|
|
|
self::CONFIG_SERIALIZATION => array(
|
2011-02-19 23:36:13 +01:00
|
|
|
'attached' => self::SERIALIZATION_JSON,
|
|
|
|
'unsubscribed' => self::SERIALIZATION_JSON,
|
2011-02-17 23:32:01 +01:00
|
|
|
),
|
2011-01-26 02:17:19 +01:00
|
|
|
) + parent::getConfiguration();
|
|
|
|
}
|
|
|
|
|
2014-02-27 01:53:42 +01:00
|
|
|
public function getMonogram() {
|
|
|
|
$id = $this->getID();
|
|
|
|
return "D{$id}";
|
|
|
|
}
|
|
|
|
|
2012-06-14 05:52:10 +02:00
|
|
|
public function setTitle($title) {
|
|
|
|
$this->title = $title;
|
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->originalTitle = $title;
|
|
|
|
}
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-06-23 01:52:08 +02:00
|
|
|
public function loadIDsByCommitPHIDs($phids) {
|
|
|
|
if (!$phids) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
$revision_ids = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT * FROM %T WHERE commitPHID IN (%Ls)',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$phids);
|
|
|
|
return ipull($revision_ids, 'revisionID', 'commitPHID');
|
|
|
|
}
|
|
|
|
|
2011-04-08 06:59:42 +02:00
|
|
|
public function loadCommitPHIDs() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return ($this->commits = array());
|
|
|
|
}
|
|
|
|
|
|
|
|
$commits = queryfx_all(
|
|
|
|
$this->establishConnection('r'),
|
|
|
|
'SELECT commitPHID FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
$commits = ipull($commits, 'commitPHID');
|
|
|
|
|
|
|
|
return ($this->commits = $commits);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCommitPHIDs() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->commits);
|
2011-04-08 06:59:42 +02:00
|
|
|
}
|
|
|
|
|
2011-12-21 02:05:52 +01:00
|
|
|
public function getActiveDiff() {
|
|
|
|
// TODO: Because it's currently technically possible to create a revision
|
|
|
|
// without an associated diff, we allow an attached-but-null active diff.
|
|
|
|
// It would be good to get rid of this once we make diff-attaching
|
|
|
|
// transactional.
|
|
|
|
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->activeDiff);
|
2011-12-21 02:05:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachActiveDiff($diff) {
|
|
|
|
$this->activeDiff = $diff;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getDiffIDs() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->diffIDs);
|
2011-12-21 02:05:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachDiffIDs(array $ids) {
|
|
|
|
rsort($ids);
|
|
|
|
$this->diffIDs = array_values($ids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachCommitPHIDs(array $phids) {
|
|
|
|
$this->commits = array_values($phids);
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-02-17 23:32:01 +01:00
|
|
|
public function getAttachedPHIDs($type) {
|
|
|
|
return array_keys(idx($this->attached, $type, array()));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setAttachedPHIDs($type, array $phids) {
|
|
|
|
$this->attached[$type] = array_fill_keys($phids, array());
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function generatePHID() {
|
2011-03-03 03:58:21 +01:00
|
|
|
return PhabricatorPHID::generateNewPHID(
|
2013-07-21 17:11:37 +02:00
|
|
|
DifferentialPHIDTypeRevision::TYPECONST);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-30 19:37:36 +01:00
|
|
|
public function loadComments() {
|
|
|
|
if (!$this->getID()) {
|
|
|
|
return array();
|
|
|
|
}
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
return id(new DifferentialCommentQuery())
|
Migrate Differential comments to ApplicationTransactions
Summary:
Ref T2222. This is the big one.
This migrates each `DifferentialComment` to one or more ApplicationTransactions (action, cc, reviewers, update, comment, inlines), and makes `DifferentialComment` a double-reader for ApplicationTransactions.
The migration is pretty straightforward:
- If a comment took an action not otherwise covered, it gets an "action" transaction. This is something like "epriestley abandoned this revision.".
- If a comment updated the diff, it gets an "updated diff" transaction. Very old transactions of this type may not have a diff ID (probably only at Facebook).
- If a comment added or removed reviewers, it gets a "changed reviewers" transaction.
- If a comment added CCs, it gets a "subscribers" transaction.
- If a comment added comment text, it gets a "comment" transaction.
- For each inline attached to a comment, we generate an "inline" transaction.
Most comments generate a small number of transactions, but a few generate a significant number.
At HEAD, the code is basically already doing this, so comments in the last day or two already obey these rules, roughly, and will all generate only one transaction (except inlines).
Because we've already preallocated PHIDs in the comment text table, we only need to write to the transaction table.
NOTE: This significantly degrades Differential, making inline comments pretty much useless (they each get their own transaction, and don't show line numbers or files). The data is all fine, but the UI is garbage now. This needs to be fixed before we can deploy this to users, but it's easily separable since it's all just display code.
Specifically, they look like this:
{F112270}
Test Plan:
I've migrated locally and put things through their paces, but it's hard to catch sketchy stuff locally because most of my test data is nonsense and bad migrations wouldn't necessarily look out of place.
IMPORTANT: I'm planning to push this to a branch and then shift production over to the branch, and run it for a day or two before bringing it to master.
I generally feel good about this change: it's not that big since we were able to separate a lot of pieces out of it, and it's pretty straightforward. That said, it's still one of the most scary/dangerous changes we've ever made.
Reviewers: btrahan
CC: chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D8210
2014-02-12 00:36:58 +01:00
|
|
|
->withRevisionPHIDs(array($this->getPHID()))
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
->execute();
|
2011-01-30 19:37:36 +01:00
|
|
|
}
|
|
|
|
|
2011-01-30 22:20:56 +01:00
|
|
|
public function loadActiveDiff() {
|
|
|
|
return id(new DifferentialDiff())->loadOneWhere(
|
|
|
|
'revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
|
|
$this->getID());
|
|
|
|
}
|
2011-05-05 08:09:42 +02:00
|
|
|
|
|
|
|
public function save() {
|
|
|
|
if (!$this->getMailKey()) {
|
Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()
Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.
Test Plan:
- Generated a new PHID.
- Logged out and logged back in (to test sessions).
- Regenerated Conduit certificate.
- Created a new task, verified mail key generated sensibly.
- Created a new revision, verified mail key generated sensibly.
- Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.
Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews
Reviewed By: jungejason
CC: aran, epriestley, jungejason
Differential Revision: 1000
2011-10-11 04:22:30 +02:00
|
|
|
$this->mailKey = Filesystem::readRandomCharacters(40);
|
2011-05-05 08:09:42 +02:00
|
|
|
}
|
|
|
|
return parent::save();
|
|
|
|
}
|
2011-01-30 22:20:56 +01:00
|
|
|
|
2012-06-19 20:52:50 +02:00
|
|
|
public function delete() {
|
|
|
|
$this->openTransaction();
|
2013-09-17 22:55:41 +02:00
|
|
|
$diffs = id(new DifferentialDiffQuery())
|
|
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
|
|
->withRevisionIDs(array($this->getID()))
|
|
|
|
->execute();
|
2012-06-19 20:52:50 +02:00
|
|
|
foreach ($diffs as $diff) {
|
|
|
|
$diff->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$conn_w = $this->establishConnection('w');
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
self::TABLE_COMMIT,
|
|
|
|
$this->getID());
|
|
|
|
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
$comments = id(new DifferentialCommentQuery())
|
Migrate Differential comments to ApplicationTransactions
Summary:
Ref T2222. This is the big one.
This migrates each `DifferentialComment` to one or more ApplicationTransactions (action, cc, reviewers, update, comment, inlines), and makes `DifferentialComment` a double-reader for ApplicationTransactions.
The migration is pretty straightforward:
- If a comment took an action not otherwise covered, it gets an "action" transaction. This is something like "epriestley abandoned this revision.".
- If a comment updated the diff, it gets an "updated diff" transaction. Very old transactions of this type may not have a diff ID (probably only at Facebook).
- If a comment added or removed reviewers, it gets a "changed reviewers" transaction.
- If a comment added CCs, it gets a "subscribers" transaction.
- If a comment added comment text, it gets a "comment" transaction.
- For each inline attached to a comment, we generate an "inline" transaction.
Most comments generate a small number of transactions, but a few generate a significant number.
At HEAD, the code is basically already doing this, so comments in the last day or two already obey these rules, roughly, and will all generate only one transaction (except inlines).
Because we've already preallocated PHIDs in the comment text table, we only need to write to the transaction table.
NOTE: This significantly degrades Differential, making inline comments pretty much useless (they each get their own transaction, and don't show line numbers or files). The data is all fine, but the UI is garbage now. This needs to be fixed before we can deploy this to users, but it's easily separable since it's all just display code.
Specifically, they look like this:
{F112270}
Test Plan:
I've migrated locally and put things through their paces, but it's hard to catch sketchy stuff locally because most of my test data is nonsense and bad migrations wouldn't necessarily look out of place.
IMPORTANT: I'm planning to push this to a branch and then shift production over to the branch, and run it for a day or two before bringing it to master.
I generally feel good about this change: it's not that big since we were able to separate a lot of pieces out of it, and it's pretty straightforward. That said, it's still one of the most scary/dangerous changes we've ever made.
Reviewers: btrahan
CC: chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D8210
2014-02-12 00:36:58 +01:00
|
|
|
->withRevisionPHIDs(array($this->getPHID()))
|
Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.
I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.
I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:
- Wrap the new objects in the old objects for reads/writes.
- Migrate all the existing data to the new table.
- Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.
This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:
- The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
- The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
- The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.
This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.
Test Plan: Viewed a revision; made revision comments
Reviewers: btrahan
Reviewed By: btrahan
CC: edward, chad, aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 21:51:18 +02:00
|
|
|
->execute();
|
2012-06-19 20:52:50 +02:00
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$comment->delete();
|
|
|
|
}
|
|
|
|
|
2013-06-21 21:54:56 +02:00
|
|
|
$inlines = id(new DifferentialInlineCommentQuery())
|
|
|
|
->withRevisionIDs(array($this->getID()))
|
|
|
|
->execute();
|
2012-06-19 20:52:50 +02:00
|
|
|
foreach ($inlines as $inline) {
|
|
|
|
$inline->delete();
|
|
|
|
}
|
|
|
|
|
2012-10-04 00:50:42 +02:00
|
|
|
// we have to do paths a little differentally as they do not have
|
|
|
|
// an id or phid column for delete() to act on
|
|
|
|
$dummy_path = new DifferentialAffectedPath();
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
|
|
$dummy_path->getTableName(),
|
2012-06-19 20:52:50 +02:00
|
|
|
$this->getID());
|
|
|
|
|
|
|
|
$result = parent::delete();
|
|
|
|
$this->saveTransaction();
|
|
|
|
return $result;
|
|
|
|
}
|
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function loadRelationships() {
|
2011-01-27 03:46:34 +01:00
|
|
|
if (!$this->getID()) {
|
|
|
|
$this->relationships = array();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-02-12 17:53:40 +01:00
|
|
|
$data = array();
|
|
|
|
|
|
|
|
$subscriber_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
|
|
|
|
$this->getPHID(),
|
|
|
|
PhabricatorEdgeConfig::TYPE_OBJECT_HAS_SUBSCRIBER);
|
|
|
|
$subscriber_phids = array_reverse($subscriber_phids);
|
|
|
|
foreach ($subscriber_phids as $phid) {
|
|
|
|
$data[] = array(
|
|
|
|
'relation' => self::RELATION_SUBSCRIBED,
|
|
|
|
'objectPHID' => $phid,
|
|
|
|
'reasonPHID' => null,
|
|
|
|
);
|
|
|
|
}
|
2013-10-05 22:48:45 +02:00
|
|
|
|
|
|
|
$reviewer_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
|
|
|
|
$this->getPHID(),
|
|
|
|
PhabricatorEdgeConfig::TYPE_DREV_HAS_REVIEWER);
|
2013-10-05 04:57:15 +02:00
|
|
|
$reviewer_phids = array_reverse($reviewer_phids);
|
2013-10-05 22:48:45 +02:00
|
|
|
foreach ($reviewer_phids as $phid) {
|
|
|
|
$data[] = array(
|
|
|
|
'relation' => self::RELATION_REVIEWER,
|
|
|
|
'objectPHID' => $phid,
|
2013-10-05 04:57:15 +02:00
|
|
|
'reasonPHID' => null,
|
2013-10-05 22:48:45 +02:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2011-10-02 20:42:41 +02:00
|
|
|
return $this->attachRelationships($data);
|
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-10-02 20:42:41 +02:00
|
|
|
public function attachRelationships(array $relationships) {
|
|
|
|
$this->relationships = igroup($relationships, 'relation');
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this;
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getReviewers() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_REVIEWER);
|
2011-01-26 02:17:19 +01:00
|
|
|
}
|
2011-01-27 03:46:34 +01:00
|
|
|
|
2011-01-26 02:17:19 +01:00
|
|
|
public function getCCPHIDs() {
|
2011-01-27 03:46:34 +01:00
|
|
|
return $this->getRelatedPHIDs(self::RELATION_SUBSCRIBED);
|
|
|
|
}
|
|
|
|
|
|
|
|
private function getRelatedPHIDs($relation) {
|
2013-09-03 15:02:14 +02:00
|
|
|
$this->assertAttached($this->relationships);
|
2011-02-03 04:38:43 +01:00
|
|
|
|
2011-02-03 02:38:03 +01:00
|
|
|
return ipull($this->getRawRelations($relation), 'objectPHID');
|
2011-01-27 03:46:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getRawRelations($relation) {
|
|
|
|
return idx($this->relationships, $relation, array());
|
|
|
|
}
|
2011-04-30 07:26:22 +02:00
|
|
|
|
2012-05-18 09:33:21 +02:00
|
|
|
public function getPrimaryReviewer() {
|
2012-08-08 22:27:52 +02:00
|
|
|
$reviewers = $this->getReviewers();
|
|
|
|
$last = $this->lastReviewerPHID;
|
|
|
|
if (!$last || !in_array($last, $reviewers)) {
|
2012-05-18 09:33:21 +02:00
|
|
|
return head($this->getReviewers());
|
|
|
|
}
|
2012-08-08 22:27:52 +02:00
|
|
|
return $last;
|
2012-05-18 09:33:21 +02:00
|
|
|
}
|
|
|
|
|
2011-10-19 08:35:45 +02:00
|
|
|
public function loadReviewedBy() {
|
|
|
|
$reviewer = null;
|
|
|
|
|
2012-01-10 20:39:11 +01:00
|
|
|
if ($this->status == ArcanistDifferentialRevisionStatus::ACCEPTED ||
|
2012-04-24 02:40:57 +02:00
|
|
|
$this->status == ArcanistDifferentialRevisionStatus::CLOSED) {
|
2011-10-19 08:35:45 +02:00
|
|
|
$comments = $this->loadComments();
|
|
|
|
foreach ($comments as $comment) {
|
|
|
|
$action = $comment->getAction();
|
|
|
|
if ($action == DifferentialAction::ACTION_ACCEPT) {
|
|
|
|
$reviewer = $comment->getAuthorPHID();
|
|
|
|
} else if ($action == DifferentialAction::ACTION_REJECT ||
|
|
|
|
$action == DifferentialAction::ACTION_ABANDON ||
|
|
|
|
$action == DifferentialAction::ACTION_RETHINK) {
|
|
|
|
$reviewer = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $reviewer;
|
|
|
|
}
|
2012-06-26 18:07:52 +02:00
|
|
|
|
|
|
|
public function getHashes() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->hashes);
|
2012-06-26 18:07:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachHashes(array $hashes) {
|
|
|
|
$this->hashes = $hashes;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-02-15 16:47:14 +01:00
|
|
|
public function getCapabilities() {
|
|
|
|
return array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getPolicy($capability) {
|
2013-09-26 21:36:45 +02:00
|
|
|
switch ($capability) {
|
|
|
|
case PhabricatorPolicyCapability::CAN_VIEW:
|
|
|
|
return $this->getViewPolicy();
|
|
|
|
case PhabricatorPolicyCapability::CAN_EDIT:
|
|
|
|
return $this->getEditPolicy();
|
|
|
|
}
|
2013-02-15 16:47:14 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function hasAutomaticCapability($capability, PhabricatorUser $user) {
|
2013-09-26 21:36:45 +02:00
|
|
|
|
|
|
|
// A revision's author (which effectively means "owner" after we added
|
|
|
|
// commandeering) can always view and edit it.
|
|
|
|
$author_phid = $this->getAuthorPHID();
|
|
|
|
if ($author_phid) {
|
|
|
|
if ($user->getPHID() == $author_phid) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-02-15 16:47:14 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-09-27 17:43:41 +02:00
|
|
|
public function describeAutomaticCapability($capability) {
|
|
|
|
$description = array(
|
|
|
|
pht('The owner of a revision can always view and edit it.'),
|
|
|
|
);
|
|
|
|
|
|
|
|
switch ($capability) {
|
|
|
|
case PhabricatorPolicyCapability::CAN_VIEW:
|
|
|
|
$description[] = pht(
|
|
|
|
"A revision's reviewers can always view it.");
|
Allow applications to define new policy capabilities
Summary:
Ref T603. I want to let applications define new capabilities (like "can manage global rules" in Herald) and get full support for them, including reasonable error strings in the UI.
Currently, this is difficult for a couple of reasons. Partly this is just a code organization issue, which is easy to fix. The bigger thing is that we have a bunch of strings which depend on both the policy and capability, like: "You must be an administrator to view this object." "Administrator" is the policy, and "view" is the capability.
That means every new capability has to add a string for each policy, and every new policy (should we introduce any) needs to add a string for each capability. And we can't do any piecemeal "You must be a {$role} to {$action} this object" becuase it's impossible to translate.
Instead, make all the strings depend on //only// the policy, //only// the capability, or //only// the object type. This makes the dialogs read a little more strangely, but I think it's still pretty easy to understand, and it makes adding new stuff way way easier.
Also provide more context, and more useful exception messages.
Test Plan:
- See screenshots.
- Also triggered a policy exception and verified it was dramatically more useful than it used to be.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: chad, aran
Maniphest Tasks: T603
Differential Revision: https://secure.phabricator.com/D7260
2013-10-07 22:28:58 +02:00
|
|
|
$description[] = pht(
|
|
|
|
'If a revision belongs to a repository, other users must be able '.
|
|
|
|
'to view the repository in order to view the revision.');
|
2013-09-27 17:43:41 +02:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $description;
|
|
|
|
}
|
|
|
|
|
2013-02-19 02:44:45 +01:00
|
|
|
public function getUsersToNotifyOfTokenGiven() {
|
|
|
|
return array(
|
|
|
|
$this->getAuthorPHID(),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2013-07-15 04:18:55 +02:00
|
|
|
public function getReviewerStatus() {
|
2013-09-03 15:02:14 +02:00
|
|
|
return $this->assertAttached($this->reviewerStatus);
|
2013-07-15 04:18:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
public function attachReviewerStatus(array $reviewers) {
|
|
|
|
assert_instances_of($reviewers, 'DifferentialReviewer');
|
|
|
|
|
|
|
|
$this->reviewerStatus = $reviewers;
|
|
|
|
return $this;
|
|
|
|
}
|
2013-09-26 21:36:45 +02:00
|
|
|
|
|
|
|
public function getRepository() {
|
|
|
|
return $this->assertAttached($this->repository);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachRepository(PhabricatorRepository $repository = null) {
|
|
|
|
$this->repository = $repository;
|
|
|
|
return $this;
|
|
|
|
}
|
2013-11-26 02:39:24 +01:00
|
|
|
|
|
|
|
public function isClosed() {
|
|
|
|
return DifferentialRevisionStatus::isClosedStatus($this->getStatus());
|
|
|
|
}
|
|
|
|
|
2014-02-19 02:57:45 +01:00
|
|
|
public function getFlag(PhabricatorUser $viewer) {
|
|
|
|
return $this->assertAttachedKey($this->flags, $viewer->getPHID());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachFlag(
|
|
|
|
PhabricatorUser $viewer,
|
|
|
|
PhabricatorFlag $flag = null) {
|
|
|
|
$this->flags[$viewer->getPHID()] = $flag;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getDrafts(PhabricatorUser $viewer) {
|
|
|
|
return $this->assertAttachedKey($this->drafts, $viewer->getPHID());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachDrafts(PhabricatorUser $viewer, array $drafts) {
|
|
|
|
$this->drafts[$viewer->getPHID()] = $drafts;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-12-26 19:40:52 +01:00
|
|
|
|
|
|
|
/* -( HarbormasterBuildableInterface )------------------------------------- */
|
|
|
|
|
|
|
|
|
|
|
|
public function getHarbormasterBuildablePHID() {
|
|
|
|
return $this->loadActiveDiff()->getPHID();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getHarbormasterContainerPHID() {
|
|
|
|
return $this->getPHID();
|
|
|
|
}
|
|
|
|
|
2014-02-12 17:53:40 +01:00
|
|
|
|
|
|
|
/* -( PhabricatorSubscribableInterface )----------------------------------- */
|
|
|
|
|
|
|
|
|
|
|
|
public function isAutomaticallySubscribed($phid) {
|
2014-02-21 20:55:35 +01:00
|
|
|
if ($phid == $this->getAuthorPHID()) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: This only happens when adding or removing CCs, and is safe from a
|
|
|
|
// policy perspective, but the subscription pathway should have some
|
|
|
|
// opportunity to load this data properly. For now, this is the only case
|
|
|
|
// where implicit subscription is not an intrinsic property of the object.
|
|
|
|
if ($this->reviewerStatus == self::ATTACHABLE) {
|
|
|
|
$reviewers = id(new DifferentialRevisionQuery())
|
|
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
|
|
->withPHIDs(array($this->getPHID()))
|
|
|
|
->needReviewerStatus(true)
|
|
|
|
->executeOne()
|
|
|
|
->getReviewerStatus();
|
|
|
|
} else {
|
|
|
|
$reviewers = $this->getReviewerStatus();
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($reviewers as $reviewer) {
|
|
|
|
if ($reviewer->getReviewerPHID() == $phid) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
2014-02-12 17:53:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function shouldShowSubscribersProperty() {
|
2014-02-21 20:55:35 +01:00
|
|
|
// TODO: Differential does its own thing for now.
|
2014-02-12 17:53:40 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function shouldAllowSubscription($phid) {
|
2014-02-21 20:55:35 +01:00
|
|
|
return true;
|
2014-02-12 17:53:40 +01:00
|
|
|
}
|
|
|
|
|
2014-02-19 01:32:55 +01:00
|
|
|
|
|
|
|
/* -( PhabricatorCustomFieldInterface )------------------------------------ */
|
|
|
|
|
|
|
|
|
|
|
|
public function getCustomFieldSpecificationForRole($role) {
|
2014-02-21 20:52:52 +01:00
|
|
|
$fields = array(
|
|
|
|
new DifferentialTitleField(),
|
|
|
|
new DifferentialSummaryField(),
|
2014-02-21 20:53:37 +01:00
|
|
|
new DifferentialTestPlanField(),
|
2014-02-21 20:54:32 +01:00
|
|
|
new DifferentialReviewersField(),
|
2014-02-21 20:54:08 +01:00
|
|
|
new DifferentialSubscribersField(),
|
2014-02-21 20:53:37 +01:00
|
|
|
new DifferentialRepositoryField(),
|
2014-02-21 20:53:48 +01:00
|
|
|
new DifferentialViewPolicyField(),
|
|
|
|
new DifferentialEditPolicyField(),
|
2014-02-21 20:52:52 +01:00
|
|
|
);
|
2014-02-19 01:32:55 +01:00
|
|
|
|
2014-02-21 20:52:52 +01:00
|
|
|
return array_fill_keys(
|
|
|
|
mpull($fields, 'getFieldKey'),
|
2014-02-19 01:32:55 +01:00
|
|
|
array('disabled' => false));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCustomFieldBaseClass() {
|
|
|
|
return 'DifferentialCustomField';
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCustomFields() {
|
|
|
|
return $this->assertAttached($this->customFields);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachCustomFields(PhabricatorCustomFieldAttachment $fields) {
|
|
|
|
$this->customFields = $fields;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-24 20:01:53 +01:00
|
|
|
}
|