revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-05 20:31:03 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley c428f60a97 Partially modularize AlmanacService transactions 
Summary:
Ref T13120. Ref T12414. See PHI145. See PHI473. This partially modernizes AlmanacService transactions by moving them to ModularTransactions.

This isn't complete because the "update property" and "remove property" transactions aren't modularized. They still //work//, since the parent Editor implements them, but they no longer render properly on the timeline since the `Transaction` object no longer has rendering logic for them.

Tentatively, I'm going to try to convert the rest of the Almanac objects and then modularize those transactions. (Currently, all of Binding, Device, Namespace and Service support properties, although they can only actually be edited on Service, Device and Binding.)

If that turns out to be really tricky for some reason I can just copy/paste the timeline rendering for now, but I think it won't be too hard.

Test Plan:
  - Created and edited Services.
  - Tried to create a service with: a bad name, no name, a name which put it in a namespace I can't edit (got errors in all cases).
  - Edited and removed properties. The edits worked, the timeline just renders a generic story now ('X edited this object (transaction type "almanac:property:update").').

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13120, T12414

Differential Revision: https://secure.phabricator.com/D19317
2018-04-11 10:22:34 -07:00
..
almanac Partially modularize AlmanacService transactions 2018-04-11 10:22:34 -07:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit
audit Make sure auditors are attached to commits on new pathways 2018-02-09 17:09:00 -08:00
auth Include OAuth targets in "form-action" Content-Security-Policy 2018-02-28 19:28:35 -08:00
badges Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
base Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
cache Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps 2017-10-04 12:09:33 -07:00
calendar Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
celerity Emit a "Content-Security-Policy" HTTP header 2018-02-27 10:17:30 -08:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Add a bin/conduit call support binary 2018-02-05 12:20:49 -08:00
config Fix argument ordering in error message 2018-04-10 10:18:51 -07:00
conpherence Read lock all transaction edits 2018-02-10 20:07:46 -08:00
console Fix some minor errors (DarkConsole warning, unstable Ferret sort) 2018-03-18 15:12:25 -07:00
countdown Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
daemon Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
dashboard Make dashboard arrange actions (move, add, remove) work again after read locking from "chaos reduction" 2018-02-20 17:23:24 -08:00
differential Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
diffusion Colorize lines in blame under DocumentEngine, to show relative age of changes 2018-04-09 06:11:47 -07:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper Allow Doorkeeper references to have multiple display variations (full, short, etc.) 2018-03-13 11:29:52 -07:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Fix usage of fprintf() in bin/drydock command 2018-03-28 16:19:55 -07:00
fact Fix some of the most obvious bugs in fact generation from Maniphest tasks 2018-02-19 12:07:28 -08:00
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed Add a rough "bin/repository unpublish" workflow to attempt to cleanup improperly published repositories 2018-03-30 08:46:11 -07:00
files Mostly make blame work with DocumentEngine 2018-04-09 04:48:21 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
guides Make "simple" a "button type", not a "color" 2017-05-30 17:59:37 -07:00
harbormaster When publishing buildables in Differential, ignore autobuilds (local lint and unit) 2018-04-03 11:02:12 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Provide a more tailored error message when a Herald rule fails because of PCRE limits 2018-03-06 12:18:58 -08:00
home Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
legalpad Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Use "-dispose background" to improve reassembly of GIFs with transparency 2018-03-13 09:19:53 -07:00
maniphest Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
meta Add transactions for installing/uninstalling applications 2018-04-11 08:54:55 -07:00
metamta Add some delivery diagnostic headers to outbound mail 2018-02-22 12:47:20 -08:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Make "No Notifications" setting less broad, and fix a bug with default display behavior 2017-09-13 15:32:46 -07:00
nuance Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
oauthserver Remove client OAuth redirect code which was only partially cleaned up 2018-03-06 20:41:13 -08:00
owners Fix two issues with Differential updates and Owners 2018-03-29 11:32:23 -07:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Fix spelling 2017-10-09 10:48:04 -07:00
paste Move Paste line range reading code into AphrontRequest 2018-03-01 11:15:06 -08:00
people When a revision has more than 7 reviewers, render only the first 7 in the list view 2018-04-03 12:47:43 -07:00
phame Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
phid Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
phlux Update Phlux edit UI 2017-09-07 12:47:36 -07:00
pholio Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
phortune Include OAuth targets in "form-action" Content-Security-Policy 2018-02-28 19:28:35 -08:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Fix spelling 2017-10-09 10:48:04 -07:00
phriction Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
phurl Explicitly add rel="noreferrer" to all external links 2018-02-17 17:46:11 -08:00
policy Fix spelling 2017-10-09 10:48:04 -07:00
ponder Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
project Allow projects to be queried by slug in "project.search" 2018-03-16 13:08:40 -07:00
releeph Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
remarkup/conduit
repository Mostly make blame work with DocumentEngine 2018-04-09 04:48:21 -07:00
search Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
settings Make the filetree view width sticky across show/hide and reload 2018-02-22 13:47:41 -08:00
slowvote Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
spaces Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
subscriptions When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer 2018-03-14 12:59:31 -07:00
support/application
system Dynamically composite favicons from customizable sources 2018-03-12 15:28:41 -07:00
tokens Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens 2017-12-01 18:16:26 +00:00
transactions Move PhabricatorModularTransaction slightly closer to having "final" methods again 2018-04-03 11:13:58 -07:00
typeahead Stop the debugging view for typeahead datasources from fataling 2018-04-08 06:16:56 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00